From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8442AC77B7F for ; Mon, 23 Jun 2025 14:13:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FF586B00C6; Mon, 23 Jun 2025 10:13:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AE8C6B00C7; Mon, 23 Jun 2025 10:13:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 276906B00C8; Mon, 23 Jun 2025 10:13:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 128926B00C6 for ; Mon, 23 Jun 2025 10:13:25 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A467312123C for ; Mon, 23 Jun 2025 14:13:24 +0000 (UTC) X-FDA: 83586857928.15.621DDC8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 369C6A0002 for ; Mon, 23 Jun 2025 14:13:22 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="LNwtsv/a"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750688002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dcmfif/cyuIAAd71gi3Imj5PORuy7iF/abJiROicq34=; b=SdlO+MxByOmoSZt3Q7+r6COQwNikcw+kVreNGH+4cAC/ASSrYcMKdUzZya3k2kUaQjB47M DyVLJvKZO1KZMwdfCkK0tROCJcdK1bgWXwMEfvR7psAHi45q37bhLNNVhKjM/fVSOHsL6q YXexEWp+SIB+PYtTczQ2YLcqZMvi0As= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="LNwtsv/a"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750688002; a=rsa-sha256; cv=none; b=k/XWr5bEv9GYaxBvoRAbocp9XP1qxxVF+2bAtK1jLQZy/imgTNJ8STpkXfOrcPQuXaHNFn v86WvOsMM6s/16AdVeArx1qXC/eQTnUkguhcFghUJ1GbuXbsSKlkWPo2k/SsvcmMwWq/eO B1R95pKolisIngwLCNIafdwAv1SA4pU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750688001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dcmfif/cyuIAAd71gi3Imj5PORuy7iF/abJiROicq34=; b=LNwtsv/af75PT8VpB6I+bDwLOlE02WorLL0ycljVMFyuEaJ59ImU3PV4/TGqRJNpXmdqbX aCbHIz9CAheHcHslX07Nhix1r6dLfuF6g0mtzmZ6eKVvyiRyCTOH51ZbQwPVTwYpTiNZ1d 6x1uuQg65hPwim+PKu8+xRjPc6bIHw8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-75-Om-uP9uIOIK_UwqmsSLkkg-1; Mon, 23 Jun 2025 10:13:20 -0400 X-MC-Unique: Om-uP9uIOIK_UwqmsSLkkg-1 X-Mimecast-MFC-AGG-ID: Om-uP9uIOIK_UwqmsSLkkg_1750687999 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f85f31d9so2147573f8f.1 for ; Mon, 23 Jun 2025 07:13:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750687999; x=1751292799; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Dcmfif/cyuIAAd71gi3Imj5PORuy7iF/abJiROicq34=; b=KvqrrTRELFOfba9xstO8B7R92I+Lte17U7dcU2KC2EByC9EzSBtb7nuAwrU/WxxvCm fCTP95f2pzSPO24B7Aak/vLZ3r/jmLDNtSM2QuSzw+jxGaL3cPooW4w1hsIVGw44z1j9 sxYajAUx2c3m639wGOZMPfrBGG/PXXNW+x/Je6dkhN0n/3ujZrerpUqNavBzO//OmD38 OHljhh9MICnTLS7pgKV+amdLkhHCWcQpZBR2YTRXK+XP31KzjfaUHI639DmMdDE84v0p BSiutbb7BC1jsPRqDRlw6Guv57sZ+IVbRAsEpQmfLGrPZ7iP2JH90KI+GpASnrtszCip zYaw== X-Forwarded-Encrypted: i=1; AJvYcCX3zGhmU3/7Yjbx4Yrs3fSiOcjO/31EbxRpfSN5/PpZ+LHXiX2R3b+HKb/ZU92Z+pd5KOuabzw0Rw==@kvack.org X-Gm-Message-State: AOJu0Ywx8+fVkSJaTa0jS9cdy5JK9hwnoQhRPjuE91UPNHV3bSOKMDMm 4DyFGS+UxjPr2QzLbXWGycUaEotw7UY6HaPnGusBAOAlkfOMhkNOOLUKiIqvh/Bb7Nx9IYFRlXQ MWoJMyuhUagsaHBzswe330q812RY84azYx7X+yNjLy8fS0Rq3Yblu X-Gm-Gg: ASbGncuJDg9umCfF/7BFVQ/rMSvXLnB5cHKuFGqKu1W85P05ahJUS1R5rfiCCJFCPmI JjEKNIirYmTApsCSnuV0RPxkGlN/4lIgsAw+Of0JlokaRf77W7heZcJywUv4Ena8DmPKa9AjFnz J2RgJxmYyGSeefxVkihCDBB+/aJxn2gpK+UVRH/5C8jptXWiBUwtlRcCn8U2zGP8rQ02P/GEvuT LZ58pNRLnUhiDOgH2OUtUjyUvsB/j7ZE54ZMqDwfKSZxphRp64vDIn7eWetI9lYmWrFVMxm8G6w QTMY7OTAUyJZusWHBAtGlNFPf71GV3ymP5mXRIEiTeIjiVcWB6KZ7qzfmxaeMwtlg7Ssz86/B96 E1aOfu9B5g6/a3aK46p2jq4t9mhF/xuIeM82SnymuxvBw10nNWg== X-Received: by 2002:a5d:64cd:0:b0:3a4:f90c:31e3 with SMTP id ffacd0b85a97d-3a6d12d7abdmr9907635f8f.31.1750687998917; Mon, 23 Jun 2025 07:13:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDUxnL3nJvmH4q+Xsnf1SS41C8BCtvEsE0B/HMLIC6UVS0ZbdeBSca4irkSqkOWPXMG44KTg== X-Received: by 2002:a5d:64cd:0:b0:3a4:f90c:31e3 with SMTP id ffacd0b85a97d-3a6d12d7abdmr9907613f8f.31.1750687998529; Mon, 23 Jun 2025 07:13:18 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f18152sm9367133f8f.27.2025.06.23.07.13.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 07:13:18 -0700 (PDT) Message-ID: <7f8ac35d-89f0-41e7-acfb-bcf54991612e@redhat.com> Date: Mon, 23 Jun 2025 16:13:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] mm,hugetlb: Rename anon_rmap to new_anon_folio and make it boolean To: Oscar Salvador , Andrew Morton Cc: Muchun Song , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250620123014.29748-1-osalvador@suse.de> <20250620123014.29748-4-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250620123014.29748-4-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cyA1BWRdw_9Z4fMGQbFhYmnNkqEMlu6hA_k_eUiDa1U_1750687999 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 369C6A0002 X-Stat-Signature: oxuyxpw4mznzsphs7k18isqo3oxuxdyi X-HE-Tag: 1750688002-436611 X-HE-Meta: U2FsdGVkX1+cLWUNHaeL5X1rCnZNNPtphY39AcTO7uS7HdaTnE36fcXWqnkygTNxJGZEwjilA/P8JZCwWjS9iw8orD54dvf6n6g6B6ZW9DSGL7gj7Yc8Ko37d+LG6su7Z+vf6GXxIY7gm+77pIjKwXaqnDy6eSP+R9JlJ7Y6nVUkuV8rBz8FVrVLAD8SMVNZIJASfJDvzv4hRPY78eSrCEOic6av5rR3aA6XrTpdvCtYHYtaYlLUFxOeoWBpuVR4S6RzgbfFOeqrwENIhUyeJUQxjS6Rs8YeskFBNFwA4p06kx18NFUkxbsnhdUJlHH7meCgZrA4QjRBzZmthqb3wXe6Q8a81L8h1uMkEa2QeEg4gRptlbJf6paOgkunQPxiXg3OOHWnq/1UdJbVgBaT0weDNh3mz6i+tYfzrcHsC2xwQhha9jAzywh+FwpJTiV9CwtqbNg+D3kp272YzdgdXnxkedZivxNZnIpC1bAo8xw9q5LNtHPPrHEn8+O9DMFowd/qWFf+pL3VludIYpWYSTQe1vEFChzjCsvVj4bGZkjL+UkX78Lp8Sj5e/+IQqgmP0NUqC9i9FHonoPZRXdRy4NCI73wldR6PSJFdvIB1QWq/HOtsR+y1JIJVpF0xRKtzdeTIMCHAdZwu1cLJmhixO/wH1vrKYMA5WuzZi5G+Lt9QNB07Au7zIyKzQ9kWQtY8eoG1OxacJDajFWXg3dzqgOnbeAzfz5pAeXlWmmZLFv2/OYk+AXThGEzpVNXiQSWZfum+XF5zhIBLvmc36NkuwFaRIvr2MhI7fmdEPk5AlDTsXWIlheZN8TDKDS/im5tJAgWOCAh4etyePNxm2zc38oSVvE3K34Obl6/gSZIb9A45j5JUQUzGp9QE3Rbopl3Ri/e5OpcWNeH0RcggeRvHmrJ7BKCEMlBTC01+G/mjbELmvyqelGmvq3psXWKzYU+73CSaQWpEN7pFfrd9YA KAo8eHZs G8YLCMwmAvoOU7NO7VROBPLbawOpwh87TcW7r3RLxQODpudyph5BSrOTqu0gYHX5r/gnUTIPZhLljRfBzsLaCBP4+rSJSpmQyye7A6stbN64HOKwzrUu4SXsfvYVeV+pDvfL/L/DPXRGe6Kh12zxtVE4rFBhebHbTvYvJoXrwlFs6QmDPArpLIk5sAyQeIj/gj0f86M1ic7GWox+OnGJfDgQ7bJCdtdFRm+iw7bq5RMLcJhImNK0xfpayDXc0/TZIKfV9mnZpU4m6lUuHRz1Kl7Gu+ACR9E09hdmaTIr61/NJmPYHnyuNppSnOffw4A+mg3FwBVtkl0PQymMb4ki615uUzSPPt12kFdJh4Ss1HRb969u8TCJiEfuZO0L0NhADeYJ4b1u873kAGt4YcWv8C56WIa58mHDymEa6ZzY+xznezaUSB0+loglzYEM77MGGSQoQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.06.25 14:30, Oscar Salvador wrote: > anon_rmap is used to determine whether the new allocated folio is anonymous. > Rename it to something more meaningul like new_anon_folio and make it boolean, > as we use it like that. > While we are at it, drop 'new_pagecache_folio' as 'new_anon_folio' is enough to > check whether we need to restore the consumed reservation. > > Signed-off-by: Oscar Salvador > --- } > @@ -6640,7 +6638,8 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping, > backout: > spin_unlock(vmf->ptl); > backout_unlocked: > - if (new_folio && !new_pagecache_folio) > + /* We only need to restore reservations for private mappings */ > + if (new_folio && new_anon_folio) Could this be simplified to if (new_anon_folio) { ... -- Cheers, David / dhildenb