From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72D32C6FD1D for ; Wed, 15 Mar 2023 14:19:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6DCC6B0074; Wed, 15 Mar 2023 10:19:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1D4F6B0078; Wed, 15 Mar 2023 10:19:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE4B46B007B; Wed, 15 Mar 2023 10:19:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9D3A56B0074 for ; Wed, 15 Mar 2023 10:19:03 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 60DF3A114A for ; Wed, 15 Mar 2023 14:19:03 +0000 (UTC) X-FDA: 80571339366.09.EE5344F Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf03.hostedemail.com (Postfix) with ESMTP id C771820021 for ; Wed, 15 Mar 2023 14:19:00 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="CNzoT/E5"; spf=none (imf03.hostedemail.com: domain of tvrtko.ursulin@linux.intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=tvrtko.ursulin@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678889941; a=rsa-sha256; cv=none; b=ga8SUegQ6U+TUcqoXih/ssTbM3ctKBLHXonU+ANtebU9aJGwfVU0Gsa9s3KZtn7wLIRwea YXvnurpXyhID5dfDGZYz/JG/5oRt/sGbarunVzb+gvO2v9FvTBZqt9FdrSn6POMJQ4Hy6h hSIgm22WHs8kHJcirur9CMWROEIRj88= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="CNzoT/E5"; spf=none (imf03.hostedemail.com: domain of tvrtko.ursulin@linux.intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=tvrtko.ursulin@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678889941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=++QqKxL3PFjs9huys/w6TAt47Sb0JQgQVcv0dOaML5I=; b=QgZPgci3sDHesqGhHhLQJ5CmGGngN2HHLaq2cfv4Qy0t/EHCnArl2Nz4hTIyUCS8BXciD2 PeH0JCae2lzM6lrupcThPOBNQz7iHfI6//UiNzpju3w7votpOt8vbv8au2hKoqxRLxILOs pndy82+6Wh3xBDCSQKAj4tUn1weVJcc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678889940; x=1710425940; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=QLmbsiwvupMvAjcg/HjKbM+oTZqTZfEMbms/hcTaWtk=; b=CNzoT/E5nseNAwb/Gx3Hv9t2/80qUOqIar1GY/4iwE8MzITfZKjiI+6z DbPzg9LVXMkejZE1l+fHHVcKKrjp7FGtOzPox9p+P+3XxFyaUIluVslGk 72oGHPa5POsOs0Kj+eecP9+QuRbdp1Lk0v+651q5m/bXxjw58L/fD7M7u sIDBZTvFvcGUaZvI6xmYVRi1kK+64BlEIOcnJn/SNPw1kbHHai89uFWMA pzJRnWbIdMFRydeKFA8TwBgiNUIMAeo+/knpfYglxHV3/MgEe/AOOP9eT TGduZST8ADnX5mpHLAGmneMCrnwkKY/YmTQk6uDWXSoHP/FZ3G0R/6RG2 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="365397275" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="365397275" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 07:18:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="822786477" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="822786477" Received: from rhdahlex-mobl2.amr.corp.intel.com (HELO [10.212.59.168]) ([10.212.59.168]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 07:18:54 -0700 Message-ID: <7fe9a4a0-9b30-38db-e739-1dc1f7a8f74e@linux.intel.com> Date: Wed, 15 Mar 2023 14:18:52 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 04/10] drm/i915: Fix MAX_ORDER usage in i915_gem_object_get_pages_internal() Content-Language: en-US To: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-5-kirill.shutemov@linux.intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <20230315113133.11326-5-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C771820021 X-Rspamd-Server: rspam01 X-Stat-Signature: 7hneeatpcoo8d1z9x7chyxaajdejq4y3 X-HE-Tag: 1678889940-145037 X-HE-Meta: U2FsdGVkX194wN9/GGb3hUi1wc3VCa3904bTJKoKAySFDA224EVO0QgFslh0hHEVjqVGbgY1Ih+CFi6HBm+O5rY4QuGa91gfes5dFTwfpshaA7pzPK4axtOXkhNmtkk62pmWk5c5uqVTDauKOqMVGwiMmUbM3W/WVfme0rh9BS7AoFQArcWOnSR1v0jAhieauZNMx0SesSpHC32UmW9Kg0ykdkSvdm+CHu4lF2HU7GC2DFRJwwZaIlYBW0zLwtt42wBYb0U1a1qPkXIVPlH8nzCjd/CWrZCzRbnOXhXNaluY3sVNZvP1UqmZmSFTIJnnttfdaTLpBU4JKnVk1yb71V8b8KMeFL2v1bxJW7buv96zdrUTk50QuVdcXFVRYAoMb3Xan1rsPltZlDtjwOITZRAOt9SRFfbD05dwDW1Ga24zOM1nkntezaMPh1YbbSw5Rz2cZeOZdom72CquEQGn6vvC/bIFPwZs7Awf/mtpTdakXguKizTZ4tNgdB554r3CGxxjUCLBj/bKxxAJs/dWCzlbsL5D1ahScXiyAtF2PM/s6jL9gLp/SZSxgcb+22SIZr0gvbRlPEiggGlZa4ZIa/EcG2OvhMmXi92H6DMSTSnsX/OSlJ/RMzDceqfybkzZI+orIZoVwaaH06N+WQ+ETAa+Rm5Tn2EZHb4KQOjDV4f1ipXlGm14ho5L//709LNHhm1oVvu1b8oz3e+7fnZp9UoXMzo0RMYsQwemkMQEp1pTUKUGUQWo7Ebgw2g6kI2mJE/KWfyU4hWbxa340sBTNupw5E2QUXloh24IkyodeMKfLZ89F88qqIYzw25YYEONHsLlQla/7segIqBShNOQ5gV9lbLdcEU6p5VimA0+KjAhY8mFuLUrOjkWyBeypO/ph0MAKBivV7bblcRBJ5e6agtFkyzbmMQRH+O5Ltq2cijiF1gxLaf03iaME94tIAKiwQlY00czZUvEGspk+Y5 s+TahFBA ONEypNI2/j3FGZv1iQppgKuI+Z8TAuP68dzaSNqZxE7BGOu/6ql59wO+Ut3gWvrof7i20sQF9N0s16wFi7Owp4/xMEqdIpHUpbkE86Qm1pWj6MCF4td9qt9IHSuK7MYemxOrK1dGfd3zx9CcVIXogtFlfn3Qf0T5XDup52rdpdZkuCOk+G+LmLM2/qA7rAmMATjCqJtJExtD/FSMc2UYGGQbDPTF7AQ+9PbeTQtpCbmsWDVxsIDp76nfc/I/4nCOEhjrQS739ijKoWGFg9PN9l3x63tMUxUffjDlq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15/03/2023 11:31, Kirill A. Shutemov wrote: > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > can deliver is MAX_ORDER-1. This looks to be true on inspection: __alloc_pages(): .. if (WARN_ON_ONCE_GFP(order >= MAX_ORDER, gfp)) So a bit of a misleading name "max".. For the i915 patch: Acked-by: Tvrtko Ursulin I don't however see the whole series to understand the context, or how you want to handle the individual patches. Is it a tree wide cleanup of the same mistake? Regards, Tvrtko > Fix MAX_ORDER usage in i915_gem_object_get_pages_internal(). > > Signed-off-by: Kirill A. Shutemov > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/gem/i915_gem_internal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_internal.c b/drivers/gpu/drm/i915/gem/i915_gem_internal.c > index 6bc26b4b06b8..eae9e9f6d3bf 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_internal.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_internal.c > @@ -36,7 +36,7 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj) > struct sg_table *st; > struct scatterlist *sg; > unsigned int npages; /* restricted by sg_alloc_table */ > - int max_order = MAX_ORDER; > + int max_order = MAX_ORDER - 1; > unsigned int max_segment; > gfp_t gfp; >