From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B6A9C4345F for ; Mon, 6 May 2024 01:54:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD0296B0083; Sun, 5 May 2024 21:54:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B800B6B0085; Sun, 5 May 2024 21:54:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A47846B0087; Sun, 5 May 2024 21:54:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 85CD46B0083 for ; Sun, 5 May 2024 21:54:01 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3386B80372 for ; Mon, 6 May 2024 01:54:01 +0000 (UTC) X-FDA: 82086300282.15.7396FC6 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf01.hostedemail.com (Postfix) with ESMTP id C0BE440005 for ; Mon, 6 May 2024 01:53:57 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714960439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QyBT0lAHzLPeca9KaIgdd7YFrx8OVmtiYmuD9TdCQiU=; b=b2EQfDXxlJdEEa9M3utAAmtQbTzHI1aMtysgiEqp9M9jmc6HC6dwfs0Tx1fr/e05+OUtBZ sgoIGQNtb2Hu4Da25tSXJplJg0tXucGZc5NDqGjdjRmaWmMWaQyCujEZBtCFsDDHxWKJmn 1tF/cS3KXerunqAHKMZKaDeOorbQE+I= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714960439; a=rsa-sha256; cv=none; b=ipUu411NinGPK1470rO5Qzk2+hwW9gy9Ymou4zhlLb73cNjU98oG3rAndY5C/BBAhFlRiL VQ08h2rPJ+8jfyddajPa24HMFPkXKadzeTSmY7ZQO7U2sUVzYVmQqJT4BuUnRcV7ZHY0Rh ZbLpsMX7THYIZ+Fd3NnPB+/j/qHBRus= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4VXkw650Grz4f3khx for ; Mon, 6 May 2024 09:53:42 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id D8E661A017D for ; Mon, 6 May 2024 09:53:50 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP3 (Coremail) with SMTP id _Ch0CgDX3JQtODhmtM3MLg--.56156S2; Mon, 06 May 2024 09:53:50 +0800 (CST) Subject: Re: [PATCH 07/10] writeback: factor out wb_dirty_freerun to remove more repeated freerun code To: Tejun Heo Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-8-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: <7fecbde8-d4b8-c733-847e-a760efb41571@huaweicloud.com> Date: Mon, 6 May 2024 09:53:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:_Ch0CgDX3JQtODhmtM3MLg--.56156S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtFW3XF4kWFy8AFW5Jr45trb_yoWkWwc_Ca n0gry7C3yUJa1DGa47GFWfZFZ8Wa4xXry7Xr1jqw1DWay8JF4kWa43WrZ5CF1xGw48t3sx Cwnxta1kZ3429jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb78YFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxV AFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2 j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7x kEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487MxAIw28IcxkI7VAK I48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7 xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xII jxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw2 0EY4v20xvaj40_Wr1j6rW3Jr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY 1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU1zuWJUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Stat-Signature: 8ekm4xepcna5b7sj3m54sm8zycs75zoy X-Rspam-User: X-Rspamd-Queue-Id: C0BE440005 X-Rspamd-Server: rspam05 X-HE-Tag: 1714960437-653666 X-HE-Meta: U2FsdGVkX1+EGk62/VMdh3aibWNunEOn3QYWmMN6wCmlCgCCr8lBsxa4heQTUIjUpy9BhC6c5Tk+H6w2Xqu5lFndUR4Vwl7yW2NfdwP9prx9a9vLGowG3zbAHQnq93Pg7EAMYtcLi+eBQBm/qY4Mcq60M1O7W1zsYhU0Omtptiaw66a2BEgoxVIF71jT5yycwo/qjGQlAG7r2GeYEcirE2xWqCB0hh1W5J1WEnCs/f8IZFonL+LlBc3AKCJUqYjt1wmqsoFv51R5Bbfds4vlhkUV3e+LMlEvr9oL6XLmOz7gh85m/OP6fn/u2i27SsOLyDfax9rfuf1SyC773hayaoqDDLPC9+5xm4KgrINDKAap1hfJTyJItKm39IpxeQkK3CxlLsRf7D2IVq3xiD0wItyxEaqDK6YdnLFz8TyJR6M8+JZdbBmK2ThsZI3SNgW/GnupDH52l8QipMhfWJkPp2RtOLUIQff9KB0WGrtCP+4wVtvv6kWHMlzPgLF5hymjoop+V279PSiiL+Z2CX28rCGn5/DjEsJJ0D2Qd4Z2ePaYRE/PPpp1ttcxiWxdolXRswcnd9o0d//yJLJPD5VQyg1+9mfcDiF/H+7t8GbEMYDXtFUNvcRawIK6DvbSVBxnTJ/tUIcRXmp7my2piSw8FcaJgJ9JTbl6f/Cg4WmH4E5c6lYyXYrMfDetlNR7rlmiovWJk7HFSgiUCjFQRCcfpQYgVYnLu8tQbpBhr13xxLPZwdHWLRYT3njbbaRGk35tUUyVA+MC2UH0RVZWUIAUbEAjGLp29ZvWT6UI5w6MxubIB6AzQomeztcShtLg8UTsfycM4bPLeKwhde+kQMatdYCs0gRsELdEvFzScfjJFoGEIjpsilsswrd7xhzHRt+kH7RbCLNmvycRuCJk1Idi1U6ZDdlMmFuqpmXeSSHXiK1Lx56BbjN/ZgEItT5g1Evb5nGdidJwF584ybi0qq+ xLHQ91jJ ybAvxPbPHDzz2/VYC1zo0KgF2Dmln/Pga32Yjc5Iw5/CXPocOYaD+swy2brSbRg4XNWxYb0IaSIQ1LcYMAlgfbMAhLBayHWsPZ18n0wsA164kF9VwWKDYhXNGfYcpBYUU3QIUrVhbacTt4Rriq8CxuBydmLkmA22QtkbuXqdEQWGfy/JYDPwrodzANyGHX8pQT6hvGiwp/ZZ3AX3z2qjlGVrSZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, on 5/2/2024 1:18 AM, Tejun Heo wrote: > On Mon, Apr 29, 2024 at 11:47:35AM +0800, Kemeng Shi wrote: > ... >> +static void wb_dirty_freerun(struct dirty_throttle_control *dtc, >> + bool strictlimit) >> +{ > ... >> + /* >> + * LOCAL_THROTTLE tasks must not be throttled when below the per-wb >> + * freerun ceiling. >> + */ >> + if (!(current->flags & PF_LOCAL_THROTTLE)) >> + return; > > Shouldn't this set free_run to true? Originally, we will go freerun if PF_LOCAL_THROTTLE is set and number of dirty pages is under freerun ceil. So if PF_LOCAL_THROTTLE is *not* set, freerun should be false. Maybe I miss something and please correct me, Thanks. > > Also, wouldn't it be better if these functions return bool instead of > recording the result in dtc->freerun? As I try to factor out balance_wb_limits to calculate freerun, dirty_exceeded and position ratio of wb, so wb_dirty_freerun and wb_dirty_exceeded will be called indirectly and balance_dirty_pages has to retrieve freerun and dirty_exceeded from somewhere like dtc where position ratio is retrieved. Would like to know any better idea. Thanks. > > Thanks. >