Re: Sashiko change proposal

[Roman Gushchin <roman.gushchin@linux.dev>]

Yosry Ahmed <yosry@kernel.org> writes:

> On Thu, Oct 15, 2026 at 1:38 AM David Hildenbrand (Arm)
> <david@kernel.org> wrote:
>>
>> (CCing all people attending the mm-next call)
>>
>> Hi,
>>
>> After talking to Roman at MS, he just informed me that sashiko now has a new
>> feature combination:
>> - "embargo_hours": hours before review is public + emails sent
>> - Mechanism for signed-in maintainers to lift embargo immediately
>>
>> That solves the key issue I had with sashiko: people/agents re-spinning stuff
>> too fast before a human at least had the chance to jump in first.
>>
>> I suggest the following sashiko change for linux-mm:
>>
>> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
>> index a9198de..ba123da 100644
>> --- a/projects/linux/mailing_lists.toml
>> +++ b/projects/linux/mailing_lists.toml
>> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
>>  ["linux-integrity@vger.kernel.org"]
>>  ["linux-kernel@vger.kernel.org"]
>>  ["linux-kselftest@vger.kernel.org"]
>> -["linux-mm@kvack.org"]
>>  ["linux-nvme@lists.infradead.org"]
>>  ["linux-omap@vger.kernel.org"]
>>  ["linux-pm@vger.kernel.org"]
>> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
>>
>>  ["fsverity@lists.linux.dev"]
>>  reply_to = ["author", "list", "recipients"]
>> +
>> +["linux-mm@kvack.org"]
>> +reply_to = ["author", "list", "recipients"]
>> +embargo_hours = 24
>>
>>
>> Which means:
>> - Embargo 24h
>> - Mails sent to everybody (author, list, CC list)
>> - No positive-review ("looks great") mails (default)
>> - No other static email addresses that receive a copy (default)
>> - No additional ignored author email addresses (default)
>>
>> I'd say we start with 24h and see how it goes.
>>
>> Thoughts?
>
> Thanks for doing this, it's much more convenient to notice and respond
> to the review when Sashiko replies to the patches.
>
> FWIW, I prefer no 24hr embargo, seems to work well on the KVM side --
> but I will take what I can get :P
>
> Reviewed-by: Yosry Ahmed <yosry@kernel.org>

Is it time for me to pick up the change? David, I'll let you decide when
the discussion is done or just send me a PR, up to you.

Btw I hope to deploy the new Gemini 4 Argon model really soon and I
expect better review quality. Also a big prompts rework is in the
process with a simpler way to put in subjective things. It will be
called maintainers notes. For stuff like "don't send me typo fixes
patches" or "don't use struct page outside of X".

Thanks