From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21516C54F30 for ; Wed, 28 May 2025 02:45:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 996BF6B00AF; Tue, 27 May 2025 22:45:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9487F6B00B0; Tue, 27 May 2025 22:45:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85E706B00B1; Tue, 27 May 2025 22:45:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 659076B00AF for ; Tue, 27 May 2025 22:45:55 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0B15AC1DC9 for ; Wed, 28 May 2025 02:45:55 +0000 (UTC) X-FDA: 83490776670.25.3FCAE94 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by imf06.hostedemail.com (Postfix) with ESMTP id 16BC8180002 for ; Wed, 28 May 2025 02:45:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=PrEkARw9; spf=pass (imf06.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748400353; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e5DGhkBS0/3wiNvr4ypo542Bb1jlsV5PO0xCqbJ1mWw=; b=v9X4+NuYLcCMhjB1znM3K+nj+2mgJgAzFCJfp6nlNjel0KAirKPEdBc/TcpBKggphGWVgj k7WxgW6y5QHaqY5tq6KqhP8Fdn/q2fNS9IZKzJJSIQQmgZTNgIroh5uDNU2CeYb9uiwLLu hg0JNRdhTmIps/XXCDeZ3niGgJU6DYo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=PrEkARw9; spf=pass (imf06.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748400353; a=rsa-sha256; cv=none; b=G3Fr0owRsQVELh00akqsIvjUxq0hNMF8NJezPy6mqr8w1b/cKOcEGjwbnCLAa0zN7LRtcW qh1BigThV8MiT/k6bPag5tBE7jTXsyP/69zn/BrIqQ2KyIEQc79WrTg+kWZK6UEteqDHBy jVeaDL4QXiXiVWoDsORgujONEzdVOx4= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1748400350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e5DGhkBS0/3wiNvr4ypo542Bb1jlsV5PO0xCqbJ1mWw=; b=PrEkARw9M+Px+dsbc/G/ZBaEH258vq9g8iLw5i5mI8Y40zMyy+za+UbyxBdSJCIDZBsHq+ bWNdAzkFCHdSq82RVM8wtogaiLm1fxlSWTKZznLAjLrT3/8nSww2IAcEJDeJPNWC6NszlO EuA1ct3+RUMRybkF3VIL8p7f5eA0VkI= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: [PATCH V2] mm/hugetlb: remove unnecessary holding of hugetlb_lock X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <1748317010-16272-1-git-send-email-yangge1116@126.com> Date: Wed, 28 May 2025 10:45:07 +0800 Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, osalvador@suse.de, liuzixing@hygon.cn Content-Transfer-Encoding: 7bit Message-Id: <8112FABF-726A-4C6F-ABE3-D2D917334366@linux.dev> References: <1748317010-16272-1-git-send-email-yangge1116@126.com> To: yangge1116@126.com X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 16BC8180002 X-Stat-Signature: t17rinitry6sc6hjfwqixbnu3g7hphkm X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748400352-240271 X-HE-Meta: U2FsdGVkX1/C+sfpTbmh8S+RTpQZXIOvb/V3Ml0b9QSiRQfLe0BVqh11BfXfgT/r5jwUSvobQF9xeWqDDQ9KwzTBcaliizGj6oo3x5VTOwbd0bbtJINnGRdmH4hdnfg776BEOnmjeMCoXZ4GXbQMJs3KSVRTBV9FEXox1Wlvu6SFbg/XF4+ryDYcA2TGkB9HRxJFsu5ziGwULQBPusWPNFFl7COAzBAgbOKgwNDZFHUsXIbjFy+S/9LBP+t+KAjdSg4/0V03lhAgSROfkeCMXpQdpc3ZajAPFZgiIQNPgDXyPurt+sfQXAFe72hsItANT9BPiEcsdgkGAwnve8RK1B3uxMyuCZFAVorkunT7YytOCNErYYU6J+MOGrnJDchhgymVJ3gaIw2LuA1ZI0u670mZaQQHGLhhPN9NcGucZiRR1eh2hCX58I+wrS0tRE/LDC0PRfhdJoUf1ESoEkjWsOqPeqG7YX/FVfRy47HuPYBVln7Sgwa9XlwLQo3no0FVO0uMOYFLlbd10a7VIp1AZFclS6Eh8ofmhQMLBQykkzJdFMEgugcf9l6Y12fmgCswKZtxXCXGlUyoXuy+uVQj0FrL4JaVJow26Ws0mDpJuYqyvRDgX2Qc49gcJ/Qz6xrxvWcPsNUC/rM1vysGYRRhyNh+y/TDE9YBjdvq0GVd+DSo7QxutDEC60XqDKthj75RQuwUzXW79+ovPWeW9M+PUlj8O3ftky4nN2Uel3PAtIuoVkCm9zFSQ+SEQyCyheTDa4CCRsxBzdTGlCD4RvN8Q6AP+WsIa+pXeb3BJZTlruvwLajEAogEAHr9h/1XFIsZkoZdgRnz3ajtxd6xg2fMLfIDRK/gJQg3Pc1bGavN5+fXI/2DGJ7NG42KipxL73i8wU2SkR3K+ITdrfFK0P5COispnXdCsv4BQwiocN40mfYb35aOMlTRMfuG8u1OGA5QQ2KwIE+nuYZ1vBf72hy 1TEizbEm wxF3d2oDbommq6HsqHTmye/aMdBDyBsWpBb5QaMGR6Q/KiEDfjm2FA+NQFnFpTjPZmms2uRM0TfREBbLMCsIOmgT5ogtp80ryArOK0gtr6T0r9vrkCDx60w/UpuZzQ2BIXoeyOmd2HEQXVrYQDYLLwVJreATWjA9KEsO6V782kxQotpJzn98n/y6dDInyr/0JBHu2W67210l8KMqVb34vrN7iOQTU5ndCjdibBm9ft5uWu16zcwjoCBNbZZGHNSu/wN+DJniCfrzNecdaXJc3jO5u3dhXM1Oadpsd81/Lom8TXQAbsUU4Xmy1towpcI1DP+YGhWOvjA1BnatPetjFgsUaUGxbjVSIuZsIVA6paCbB4x6rT4JYBk4hQpremaGbfS/x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On May 27, 2025, at 11:36, yangge1116@126.com wrote: > > From: Ge Yang > > In the isolate_or_dissolve_huge_folio() function, after acquiring the > hugetlb_lock, it is only for the purpose of obtaining the correct hstate, > which is then passed to the alloc_and_dissolve_hugetlb_folio() function. > > The alloc_and_dissolve_hugetlb_folio() function itself also acquires the > hugetlb_lock. We can have the alloc_and_dissolve_hugetlb_folio() function > obtain the hstate by itself, so that the isolate_or_dissolve_huge_folio() > function no longer needs to acquire the hugetlb_lock. In addition, we keep > the folio_test_hugetlb() check within the isolate_or_dissolve_huge_folio() > function. By doing so, we can avoid disrupting the normal path by vainly > holding the hugetlb_lock. > > The replace_free_hugepage_folios() function has the same issue, and we > should address it as well. > > Suggested-by: Oscar Salvador > Signed-off-by: Ge Yang Reviewed-by: Muchun Song Thanks.