From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF130C2D0CD for ; Mon, 19 May 2025 13:28:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55DDF6B00C9; Mon, 19 May 2025 09:28:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50B736B00CA; Mon, 19 May 2025 09:28:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 360096B00D8; Mon, 19 May 2025 09:28:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1180A6B00C9 for ; Mon, 19 May 2025 09:28:55 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A7DDC1A07C8 for ; Mon, 19 May 2025 13:28:55 +0000 (UTC) X-FDA: 83459737830.07.64E450F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 3F82614000E for ; Mon, 19 May 2025 13:28:52 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W036MQbW; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747661333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LnZPk51OG5730zmFf6blk68sjraSbAgAbyfB3yfDnXw=; b=6AsFRhkzOvA0vHG8z3WCS2ymdRgHmXAF85lOoCPWjIeTYH33bJThweXagPkwKR474cMofO Yl8sROm1Gvhfbh3ibSyXsuYWN9A0c/NM6A0z63iC2+ltdLJ8kvJMSuB+wUN4ap+/qlq0w/ w8xbgimvSPjY+YzE+xz1Tts0omm3mPA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W036MQbW; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747661333; a=rsa-sha256; cv=none; b=mCn62H0pC8HfaUwF2JOScljYij/KOX6SG8+XQ5WCGplSTct9PjR2q/ojI7LMQRLi52o9KL EtlrJJTgTjb8DPm3ue0maeHuD0hrXg6LSnYauTkuxmhP3kGxKpMmmi/R+k4Fp7n9RVGRaX DuuH3wx4lkVj42Lo2vJQnVWJBtH4Waw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747661332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LnZPk51OG5730zmFf6blk68sjraSbAgAbyfB3yfDnXw=; b=W036MQbW64V5XDFs8KbfhNqlesDvLNDcxUzwCbAF7ns675TC/lH89TJZirCZxwJNdRQnc0 piV6Ge0S7haVXX4XMcKW5nCW0VdTdr9amOSUO4ones3ehuznv1FE4v7RCZr3EH9fBT3eL+ FniZW1CDxsvKXRBtRxhuxDy9hRzmV1A= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-5FYNhayQO22NS0i1yITaSA-1; Mon, 19 May 2025 09:28:50 -0400 X-MC-Unique: 5FYNhayQO22NS0i1yITaSA-1 X-Mimecast-MFC-AGG-ID: 5FYNhayQO22NS0i1yITaSA_1747661329 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43cf172ff63so25849895e9.3 for ; Mon, 19 May 2025 06:28:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747661329; x=1748266129; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LnZPk51OG5730zmFf6blk68sjraSbAgAbyfB3yfDnXw=; b=OC7GIF+SZx17K5YkUNlEBy/dNVZ16wvlKrlRRBSqb0oUhL3ctGEs7R7lI9fW+AfM2Y wiHxs+UI68zx9Ve6k23oFrGuvKmjjlB/Sv9LGhIQK0KjXac2jyhp62aduNAQ0vLqPEf8 woS8k70i+omC5nMBx0jZc4sgIjzyzp8P8GTGYMLfif0orgbvPCKtedqNyonME/N+7ymO i80Dc+Yj3W74EWb3BJaGL41+2gRWO/FgNHH0QAlvm+TMBMVWe2h2O22fWOw9vE+tDgjs UYtCS6YeYWBUY7V2xZrOmRe58tqQpu9SmHMyJQHmKcao1GiwqsY3/1v3pleb1l+isJPX vAHQ== X-Forwarded-Encrypted: i=1; AJvYcCVwYl0wjVZwOeEKXAFpQqfFOibOh7xMPZSSFvFaq/r6GXs4zSml4KXlAs8HwpL0KsWUllhJ20rcRg==@kvack.org X-Gm-Message-State: AOJu0YzEMuLtQFeFHEy0PB1Huf9EH/KED+IyA/XHOe+aBKNuIaoP1hz9 ZVsaSVQ9LOJMEXuUdo/hE3yfiUODpSS0w+cyO3WH1k86zY1zHfcZi9h3Wq5vjtkybgmc5KAha78 nE69L+fj5uisyIJztifCLH0PCMM6xtxBNHC7QxZWAT29YUYvOMlwi X-Gm-Gg: ASbGncts9432Kgne1nztJhzBs4jTNwLBHhwuEF6N3Oy96a1lx1V2PI6BBscPto8HDDA dPv0L909JfTFCqGKZ6/4A4OmqAVDS2KWPSLpTeWDcrN6AshmImdxK3M4P+AneT53kWQLi/kpXxM cxHvpFaA+01jI1HrfDif4w9v9CijNhdiNtZxdiwErlxQjB0+bkkzwYg6FOiCI23oYjSOJWt0EM+ On6nI+Cd31oPJYR/6fKLrTr7B58jmaBbXP2bk1JCuzk22J9ruCBSMp2nE5TdNdkVPOvpkUo+v6u Kl+p9py1wbTG6uIxVI6kPvqDkg1Sn3b/WV8gYzRx3ac3nbPbVqQP546XGvqenuWNjVtqlQrX3Ye w04Cw/3UUyVjiPO82EaWhWLbjDkTOdVDK2uvZVV0= X-Received: by 2002:a05:600c:c0da:b0:43d:ed:ad07 with SMTP id 5b1f17b1804b1-442fe667ec9mr98110465e9.29.1747661329565; Mon, 19 May 2025 06:28:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGv/14e2S6T0zf4P7jwon6xq8VRpY0NANQiw20OZzdDZ81YY+TIomD54n5XNTVyMN7y1wWMJw== X-Received: by 2002:a05:600c:c0da:b0:43d:ed:ad07 with SMTP id 5b1f17b1804b1-442fe667ec9mr98110265e9.29.1747661329140; Mon, 19 May 2025 06:28:49 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442fd583f71sm136833005e9.27.2025.05.19.06.28.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 06:28:48 -0700 (PDT) Message-ID: <8131ce62-0cee-455f-9eeb-e2bbed244402@redhat.com> Date: Mon, 19 May 2025 15:28:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm To: Mark Brown Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250515-selftests-mm-gup-longterm-dups-v1-1-05f8f731cf63@kernel.org> <58dbef73-6e37-46de-9092-365456306b27@redhat.com> <46d151d7-c04b-4538-9725-dc4f46ac8ac1@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kXl5Erxymo_7fMn_PDdknOYJLvM7akb-bvVOrV7vklE_1747661329 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: dosnu877syzy3nwrc6oqmghakbw9jpak X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3F82614000E X-HE-Tag: 1747661332-580748 X-HE-Meta: U2FsdGVkX19LD4Wc8e18BStBq8QhSscOa70n1JwNyMs/xtTvYY9QUViDMSycO0/SQJfklX1ApGqAGzq5Jc2OABexRuJR4KdbpYbmisFj3x2M4svWy2T0FOy5/Id4BWobvDiVnG+6A/k27J/jhe7Kz5JITFZH3RKzi57F3Jv6bjySKRCFnmam6Wem3KTMBZo8P8pP0h34thc3+RsANmYBYpSN3Nb/G9FLT+0ETQ8USzAMMtFlx4bdVqTdJIQnoAd4/wEQM460rVpGZfB+zpuDNaIt+LV/2jn/+IWr/0clVX2rZkfweFaFIIDdJ5YI3es7L42ElRuoNTWwEbqYbhJDxON/rwlu01oJFpTpvZJ4NcpiE+o/AFy2MlbgZJbuSdj8YIE0MypjxrA8/dt48BWRhkWaANJEMnhHul/S6FFM1dL5DZ/ru1hzo4dZh5yvbxR+P+pL/KzRrLvXFD4mfhnCfBoLjd2VrU7JAjVGYc/8quti/7nRgFX/1QrQkS6AGt5Cq9IfosOtefYW1a5LsUdHKoXJ7lxKNtGd0MHlk/Aq1PIECswpJkGe7U5khDKSH92fpLeewnqIQ4+TyI3nIOa1HCqXUBYmjW1dhY6UInK7dU/J29VW+T70obFVIXXoYJwXlPrWVWNvvL9Qfww+Zviwvv2FfM/u1pOsvqpwmUGx6bM4IWXmfrWy0BqvvfOWrqFiuSrzCQIzgSIvVAegnut4Iih0glfGLCaEKuZiUHvKXZ5tS1L4gfR3f9cS9s9ZwICtopK6zK+3cNfGIJ8qmcY2ueRW86H1Gc0+lEYkn1JiKSY8Dg1nne/YLmGkfHSYvu5NaqZhTvQYPfugq6O5p8KfO5OEsMSMnNvmjj3Gylhxh1fd48N+/qt1JIv8TeJuQ1FMEXVyjg4KgFdRdvvxvPQFUOeEctwMvPW/RvNv79IPtnuhHt1O1IN8280hL1nd+unLO+FpxSmEfUxW1MtnEXu uRSrlW9X 2IV/GSShGG65eJ85OXsh5eHcRZpqdrXupWddqwRa1Qpc3xdaKXsqHS+zOWlkwyEF5JUmnYj7w/mv9PJN9Ie/Ou7s1SdJEG3DIzowqwdtqBSUg5wy9/JkC9oFI8F8u2aCRXWChWTj1byKAOkHXM4TOLJIMixx1bK3KbV49BtFQ2Gr0cZrrhz3JOpqQ2Ygi+9qEssbIe2QAt/qwVqCQUUH5fGVtBle51eNn6S3ZpiewDedL0LOTA+eX1msdkJ/zTbAF3xvpZthlmj5+R5Ywmq5oY8zk+r3XDAGWSXVoXN/RRsi+cg4exZwpG8nDOAxXp34Ee3IJJRLUhmK3JJygTO16PQ0jhsMtLrO4XycFhhtUjl6qU2lIJIksQ2CJWxNINU/d7QB8CV8rSo0umoDl48KsZrkUd+j4KbZeeaD8+qgUNe0IyOC1f6Oc6l1z5tZBwTJ/WSU6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.05.25 20:07, Mark Brown wrote: > On Fri, May 16, 2025 at 04:12:08PM +0200, David Hildenbrand wrote: >> On 16.05.25 15:09, Mark Brown wrote: > >>>> I'm afraid we have other such tests that report duplicate conditions. cow.c >>>> is likely another candidate (written by me ;) ). > >>> That one's not come up for me (this was one of four different patches >>> for mm selftests I sent the other day cleaning up duplicate test names). > >> $ sudo ./cow > > ... > >> 1..778 >> # [INFO] Anonymous memory tests in private mappings >> # [RUN] Basic COW after fork() ... with base page >> ok 1 No leak from parent into child >> # [RUN] Basic COW after fork() ... with swapped out base page >> ok 2 No leak from parent into child > >> Aren't the duplicate "No leak from parent into child" the problematic bits? >> But maybe I am getting it wrong, what needs to be "unique" :) > > Ah, yes - that's got the same issue. I'm not running that program one > way or another, it's not immediately clear to me why not - I can't see > any sign of it being invoked by the runner script but I also can't see > anything that I'd expect to stop that happening. I'll have to have a > poke at it, thanks for flagging that. > > [Converting to kselftet_harness] >>> That'd certainly work, though doing that is more surgery on the test >>> than I personally have the time/enthusiasm for right now. > >> Same over here. > >> But probably if we touch it, we should just clean it up right away. Well, >> if we decide that that is the right cleanup. (you mention something like that >> in your patch description :) > > OTOH there's something to be said for just making incremental > improvements in the tests where we can, they tend not to get huge > amounts of love in general which means perfect can very much be the > enemy of good. If there's some immediate prospect of someone doing a > bigger refactoring then that'd be amazing, but if not then it seems > useful to make things play better with the automation for now. I would agree if it would be a handful of small changes. But here we are already at 1 file changed, 107 insertions(+), 56 deletions(-) -- Cheers, David / dhildenb