From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C493CC87FC6 for ; Fri, 18 Jul 2025 10:54:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 544D98D000A; Fri, 18 Jul 2025 06:54:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F6008D0001; Fri, 18 Jul 2025 06:54:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E4948D000A; Fri, 18 Jul 2025 06:54:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 28E608D0001 for ; Fri, 18 Jul 2025 06:54:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8719E12E502 for ; Fri, 18 Jul 2025 10:54:46 +0000 (UTC) X-FDA: 83677077372.15.0B59EFC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 0BFD818000A for ; Fri, 18 Jul 2025 10:54:43 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UsxZeLdO; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752836084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9x+6SNZ1rUKJhJRi0vlqrQwvBIRb+ESC1w/j4s3Egps=; b=YQ4oxGJ5RLYvPF1qZO6RGC1pRoP3OZb1n3sJhh29y+i4OQnz8O3qMFtgDFO+rwjBUMDgpk zUzkAMb0zguWwf8BLcGhJEOzd2KV8RTqGnAysrKGREDTyIQJlpVJjiVYZbsTpw1XvIb7kV JYuf/LuGT8aB15F5aM/vn8ZX39pccaE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752836084; a=rsa-sha256; cv=none; b=ycQ7+N3gXZMvSRpwO2Eiw/t75p2lLnuyuLj9jKwdUNKZH2lupGPJzVf0/Zvc7x3MeRmUSP oGLRz/ub79oRqJAbHTRb8bqIsENNy/3kRnKFlELUViG5mQDkqPJKk9hH+EAaonNYIzzDGq 5ttbv8N5R2O2AJFC2bTfEZUbrCSScsU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UsxZeLdO; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752836083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9x+6SNZ1rUKJhJRi0vlqrQwvBIRb+ESC1w/j4s3Egps=; b=UsxZeLdO9oSjDAlxPuDdH8yl32QLLuebbx9TRpKTZE0uGxmSG85wDv1ehjQpil4req4kkM +tXPJkCvTFSChy3pV678zS5tGD/K3IEHLPG4AwmKRd5Jp+0VmKlKqp3DIBh12KeP07Nh07 xsjCRuTKARwoHI1Vm5alTGctdWQqXi0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-100-1SFYEc3BOdydZLL25JRbRQ-1; Fri, 18 Jul 2025 06:54:42 -0400 X-MC-Unique: 1SFYEc3BOdydZLL25JRbRQ-1 X-Mimecast-MFC-AGG-ID: 1SFYEc3BOdydZLL25JRbRQ_1752836081 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-455eda09c57so12929175e9.2 for ; Fri, 18 Jul 2025 03:54:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752836081; x=1753440881; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9x+6SNZ1rUKJhJRi0vlqrQwvBIRb+ESC1w/j4s3Egps=; b=DVYPPs5bkosXdhZzhCHeYIbT3OlOdu6O9sUIRuWI/LzXLnDlfqZb8FNfeo5kG0v/Op cwVFby8zXt9zGZbjJv4Zg2rWMMbG592OCTiLbr2Yp+AF0/Q7BvqOTDUiTt/1aqnZ4kex 1zsKrUBLxTTqo8atjpBNgDpBxiv6/x12h0htasf20Wi8WRW2fDsHqKzBhXzhgtzZ0S1r 8oBLIbjc56bHSREjHDXgVoasCFfTmLmO0nvl/Wyshx8IdZGHWChaIfuQ74eu71GYXTQ/ 2u+tV0eA59+vF5qh/0b0oEvoDFgEy40kOXpGEn+gVl9fwDH7pQYzC4C57S5H3XRmS2OV RPsA== X-Forwarded-Encrypted: i=1; AJvYcCUyjzS77QiB2033GuXw0FYl9V/rVoClsIbld7QD4PQ2PdrwMdcYeh02J6p5vcu0v7JwfMRPz/wKyA==@kvack.org X-Gm-Message-State: AOJu0YwOVoDs+ZrwHqP8leMe7hFgeTG4TGIx/BDggJTW+dXIV6PAZ6Oz F7dML1d35hH++d7d3/5Ak2NsdeTkKj3Zowyq4Y/DS2dBiwbDUmqFDnhHPGz2HRqULtY9dHwap/8 1LzAU/8gTt9G8kgB4wsndQXBAau9x6JQGQCAv5w4kptRI6i31iZRp X-Gm-Gg: ASbGncuxkQUINXht9lz2yRrPn0JJoD9WPQgcKHIERm7Tc3w1xAipSe+KaauiaUtg+bc Hth9LghEnDtHRBcR9KFzKzIM7pJs2nKwhGYAvkknKSbYF6JIodeefcQCv+0KD4yUUbq6nzG7tNE OLKZmQHXlw0s1lfUj6w0jP2Sp8j8s8rJIBYMvLrying2Pn+uS+HJMf8r06ag1EOT2KyjXqfVXZ7 kzAd4OKZ/NYc018+HVFEdt+JXYmAw4BC0eSajXb8swqA6w3LV6wo+NB4csqNKaJh+UNe8A6M1MY uhH/JlVS+4JF4RJQolFHwrvYNMB42FSdVu9L9eot4R+ciwHcLIbnRKgKsWXgVitfwQewIBTnYy+ oalDwYwbJ5B078iuO9IWycaVCqIbVaQPzr+T1u1N+DOwD0zeQ+kImT2+4QhctD3Fyn50= X-Received: by 2002:a05:600c:4e4a:b0:456:1f89:2483 with SMTP id 5b1f17b1804b1-4562e391fa5mr84761205e9.26.1752836081013; Fri, 18 Jul 2025 03:54:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHjQqxYszJ86M7j2Ywj9XErK7h/2M4wutBxbbGwenrhGaPC0WvCUT5o+u11Z+VyIFbNK+nV8Q== X-Received: by 2002:a05:600c:4e4a:b0:456:1f89:2483 with SMTP id 5b1f17b1804b1-4562e391fa5mr84760905e9.26.1752836080442; Fri, 18 Jul 2025 03:54:40 -0700 (PDT) Received: from ?IPV6:2003:d8:2f43:8900:f364:1333:2a67:d49e? (p200300d82f438900f36413332a67d49e.dip0.t-ipconnect.de. [2003:d8:2f43:8900:f364:1333:2a67:d49e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e886104sm76981725e9.25.2025.07.18.03.54.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 03:54:39 -0700 (PDT) Message-ID: <8292201e-0ca2-4a2a-b2a7-02391cbf7556@redhat.com> Date: Fri, 18 Jul 2025 12:54:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/9] mm/huge_memory: mark PMD mappings of the huge zero folio special To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , Pedro Falcato , Hugh Dickins , Oscar Salvador , Lance Yang References: <20250717115212.1825089-1-david@redhat.com> <20250717115212.1825089-6-david@redhat.com> <46c9a90c-46b8-4136-9890-b9b2b97ee1bb@lucifer.local> <7701f2e8-ae17-4367-b260-925d1d3cd4df@redhat.com> <9184274d-2ae8-4949-a864-79693308bf56@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <9184274d-2ae8-4949-a864-79693308bf56@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: K2fG4_AgdFGewk-hZBtX5Ey9TNiiAptmFSUkKxVbkl4_1752836081 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0BFD818000A X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: wzoo9yd311kpi5uyydcburbprj5phcbu X-HE-Tag: 1752836083-623531 X-HE-Meta: U2FsdGVkX1+uL7XbvtYxRv4yR0BKhWVV6CW1/FfWNCTSK3l2J9ui9Fb0uNLqB/w34WfIUgBbTmod07+a+CY4CwNhEey/GezGCT4Oo6/i1ONATim4LltRp9nF97WxaWSA9jmc6rxwI1ReAlRqD5/yq71PnT6/ITW/sl//ki9egT3JNmdR23IMNJJevS4nOIngeh4pxWKHKgMSeTHD3xCGn6kOeVZhqMAhYSiCy44nKtfD6Nhf/evev9WAXe/z6pb3kIskmAzPWHDkwCygKYXBmiekxGX5RZ9LFvUL8lH4tmWrrdJw7HNjR/iJyZgWEbm22L0L+Ue4n0hykd7ZtL+5LpkHOdD6TdPEAls9E7zDw4sEv7zM/oGkdetebzKPXZdoAa6qSkNKS/RTxrrktn6wJbNRd3fh0ANjh1CrEDQbpzSFZFDUzo7jkktrpbMzU8BO6SS4j2ClSGcA+pvu0zWfhWWXG+ur41oCR0s8A1OtT9wsjSzNl4vSR3sXGtiqa+qRdLSj4bPARTKOeQktuw6YQ05biVqWH5JjhdFwH1dgJi45+lc66AvZ4oYJqtZUH4ctxVuSIED42BLWrr7IkAQ3qUFOz1ADaKNJARRuSBOayUYqTfFk1WyoqO4m0KwGKoEnooSGPXalCaUtnkpXvcjJHaJAmhGjclT+cQwiDu7ykbOzLMuZt3twQF2b80HluliQWQA8Ppb5R++xWJHmyIu6HHX9/kxgM+FVFm4C4e1LHCi3VdqvpKlMiJFrNwq5WcDC1Neju9QgSdkxyr63baB4MQS8iMTZPlBQjUmFFmzB0IKExALRso2oE90x/KDLUYVlLexUMKnSryn4wrnMztSRLgsSPBl10+KS6AcHgx+IivwvRW5iH/tJVoWyUa90W8vwvYIrw7ClgHylgOYsiVys4ANDnjn3OhYXdZ6a//6JXMtWwO4c4nrGxrB0FnXXbq/1tGAaM0+xZZ6zLfmEmp0 gqlpHP8e nfW3VrjH6blFe/rGRl2IjP+tS7Q/Xvwtt+DjiJgxZJTVAXlWlj1ELrdkYu8CFQptc4nUwmRtnNwN1kLVRYMKFVwzEpaIvNyacxokuPXc7uVDwrY13c7nSlaaTUcCmCUWNnDdXYJIWyBUU74Lw2An6vXbJk6GiD9iFkP45K5oQubIyLoqxuyVHm1bnxzyKk9RUpph5beRBUF9/b6Q8+ZOlyoc1CiCMRIWeeNneTaQfshIF0Y5vnz3q9UTXZBzun9+eJTTm7e0N46o98r4HndYvsNotc0p4znUyuEqztc28aVJARLf9jVUw4W999IGgKEcp/I/5nrURcbloqEysPG8cFnPyRC1zAe417g+fhgyiVrOTpeiQ4yCIv8AMZU4cniRDuRrMmApuIkSkh2yJn+/VJA5HmvrVbqf7cXBX+4eF2/meG26SW3HiNBrUOCPOdY7EFB2HzrQkx9Kzs3NZtTn+yo4sqqF1WOBBmT2QEEbtfOEUmmbwnAtk9kMVfhZYDUlDLAlu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.07.25 12:41, Lorenzo Stoakes wrote: > On Thu, Jul 17, 2025 at 10:31:28PM +0200, David Hildenbrand wrote: >> On 17.07.25 20:29, Lorenzo Stoakes wrote: >>> On Thu, Jul 17, 2025 at 01:52:08PM +0200, David Hildenbrand wrote: >>>> The huge zero folio is refcounted (+mapcounted -- is that a word?) >>>> differently than "normal" folios, similarly (but different) to the ordinary >>>> shared zeropage. >>> >>> Yeah, I sort of wonder if we shouldn't just _not_ do any of that with zero >>> pages? >> >> I wish we could get rid of the weird refcounting of the huge zero folio and >> get rid of the shrinker. But as long as the shrinker exists, I'm afraid that >> weird per-process refcounting must stay. > > Does this change of yours cause any issue with it? I mean now nothing can grab > this page using vm_normal_page_pmd(), so it won't be able to manipulate > refcounts. Please look again at vm_normal_page_pmd(): we have a manual huge_zero_pfn() check in there! There is no change in behavior. :) It's not obvious from the diff below. But huge zero folio was considered special before this change, just not marked accordingly. >> >>> >>>> >>>> For this reason, we special-case these pages in >>>> vm_normal_page*/vm_normal_folio*, and only allow selected callers to >>>> still use them (e.g., GUP can still take a reference on them). >>>> >>>> vm_normal_page_pmd() already filters out the huge zero folio. However, >>>> so far we are not marking it as special like we do with the ordinary >>>> shared zeropage. Let's mark it as special, so we can further refactor >>>> vm_normal_page_pmd() and vm_normal_page(). >>>> >>>> While at it, update the doc regarding the shared zero folios. >>> >>> Hmm I wonder how this will interact with the static PMD series at [0]? >> >> No, it shouldn't. > > I'm always nervous about these kinds of things :) > > I'm assuming the reference/map counting will still work properly with the static > page? Let me stress again: no change in behavior besides setting the special flag in this patch. Return value of vm_normal_page_pmd() is not changed. >>> >>> Also, that series was (though I reviewed against it) moving stuff that >>> references the huge zero folio out of there, but also generally allows >>> access and mapping of this folio via largest_zero_folio() so not only via >>> insert_pmd(). >>> >>> So we're going to end up with mappings of this that are not marked special >>> that are potentially going to have refcount/mapcount manipulation that >>> contradict what you're doing here perhaps? >> >> I don't think so. It's just like having the existing static (small) shared >> zeropage where the same rules about refcounting+mapcounting apply. > > It feels like all this is a mess... am I missing something that would make it > all make sense? Let me clarify: The small zeropage is never refcounted+mapcounted when mapped into page tables. The huge zero folio is never refcounted+mapcounted when mapped into page tables EXCEPT it is refcounted in a weird different when first mapped into a process. The whole reason is the shrinker. I don't like it, but there was a reason it was added. Maybe that reason no longer exists, but that's nothing that this patch series is concerned with, really. :) -- Cheers, David / dhildenb