From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C166C25B4E for ; Fri, 20 Jan 2023 19:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B34CD6B0073; Fri, 20 Jan 2023 14:27:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE4666B0075; Fri, 20 Jan 2023 14:27:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95E286B0078; Fri, 20 Jan 2023 14:27:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 87C836B0073 for ; Fri, 20 Jan 2023 14:27:42 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5C6A7409E5 for ; Fri, 20 Jan 2023 19:27:42 +0000 (UTC) X-FDA: 80376161964.26.7D6AAEB Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2078.outbound.protection.outlook.com [40.107.93.78]) by imf12.hostedemail.com (Postfix) with ESMTP id 97C8F40005 for ; Fri, 20 Jan 2023 19:27:39 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=MoZvsmgf; spf=pass (imf12.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.93.78 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674242859; a=rsa-sha256; cv=pass; b=RMjOCmgbbjsF0c6eJyXf/CBTI32UyRz9n3bdhQ9rq1DtaA0p04CrnPDKzKieZBZo9jAWsi 2tOMMrtlRAdw5/QNuLedykCm+D342bi6n+7oFyzRtu8A6yVN1RjR1w9BlsGLYVd3elQrcM haGcuRFS26kFzVwlmophvnBMg0D8Lgs= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=MoZvsmgf; spf=pass (imf12.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.93.78 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674242859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ybdafi5Njm5tnjY3pmb0FSrDT1H5sFwiq/56DHHpsVM=; b=D/YYa4xIRyIvx3kDEU36e8shz+dkh2YJ+J76Qrs/TiJQQqzGOToyknRwuKZWIfLIC7DSYj /cSQ/ogjuT+jWaEuH7IJD7J+syhAurw5c4A4JiSA6JXWg5w58oilWwTa56hpLMs6rK/M8K /K1khfAyqts0GX4fNYmeQ7HEWG7v5m8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R1fFL7L0zNOK13CIVjUU3m0WVTsp5pf6sKAW86ck9fF7v5nrC2oWaN8d82lTGuQAKgLy2JsugzOXRvg4mPSS7SmhnvWDoHIASCjHyXdI1Wfvv1kO5iZND31syAqucrec0Zm4jxfOb5Mlx77I2tbgBmpZcb0kohlJ+fVoSImZM1Xy7tvH2Oo5QTj0+pSogo/wfLE7mLTFqc29VMiA9ipKdkzx6qxGpqzAv01krUwoI9oZW8VFcw2YE/eZOwkc2F3sPid36IkDzzzyDT198/Zh8LGzQgF5VqJZbS1sYhu0rUc3iuBVN0YsXOFO3bvcdfWmpJHMOtongd85Zb+EDLMfUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ybdafi5Njm5tnjY3pmb0FSrDT1H5sFwiq/56DHHpsVM=; b=UzZlovbJynTeUz8s1SZfU+cEYnW5jFVAvlWaOYKyajPZVfxFdfcQrJfrKMb2z1MuSvw0cwL2fphQCoLg2+0U+0w9eGhezg44idmSywqR9aAXQVKMNB6dsd/FLHecD/sx/8idswDj1DPgmNUBP3wdl3S5z0j9bfUjSLskJfrJ8oJQfepiQGtH6QSfulVTmIA5ZNXP7+kjzJQvhnhZHOz11ux05GRS7UIBcFsvP5eQeFvA6NIEKF7UojTeBgiXBxvgT8QiVDGkKhQrmyCzDlnnFP917NFoXpXXQey/XDd6hn5HtxTXGdLExaamhJdSb+2MQ3dc31+RF2Vq7qk5X6KHdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ybdafi5Njm5tnjY3pmb0FSrDT1H5sFwiq/56DHHpsVM=; b=MoZvsmgfix9bPlx/y1qYWp0177h1I2971vWySdXFtmvDb/oBZjswv70a1GKbmOvHUuayjzoZlNh5DfMGdV/RwVq8j8t76vasCcIsWm5eCYT1NTDjYPPqWQQTIeIqgtZcoh/meUfr62qwRBVrumDbEXEaWc68La66v6XjFzhfvABg+2NIXtflI18JF/AM6onBRpLLyVMIvs4+etbhMFkyJFPqcnx3C3XIC3F/51vh8hzmXnoBRt4LQQEfee6blqbR3jYDRYUu2h3gDLQlvXvEH1GeuVvDAPy3RI+OCVLlEhF/JAGZE0llIwZ2tbupWXrpMVeVIlkfIwKkOmlaBy80Gg== Received: from BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) by DM4PR12MB5197.namprd12.prod.outlook.com (2603:10b6:5:394::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.27; Fri, 20 Jan 2023 19:27:37 +0000 Received: from BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::7895:c4d1:27d2:5b0a]) by BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::7895:c4d1:27d2:5b0a%9]) with mapi id 15.20.6002.024; Fri, 20 Jan 2023 19:27:37 +0000 Message-ID: <82b47af7-aaf7-564a-48a2-46ae522cdf7f@nvidia.com> Date: Fri, 20 Jan 2023 11:27:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 8/8] mm/gup: make get_user_pages_fast_only() return the common return value Content-Language: en-US To: Jason Gunthorpe Cc: Alistair Popple , linux-mm@kvack.org References: <8-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> From: John Hubbard In-Reply-To: <8-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR13CA0231.namprd13.prod.outlook.com (2603:10b6:a03:2c1::26) To BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR12MB4130:EE_|DM4PR12MB5197:EE_ X-MS-Office365-Filtering-Correlation-Id: a9dddde4-f358-49e7-9788-08dafb1c6384 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uLByfWmZ/fsc4DgOaGYCYMOHAAI/SQdJGyyyavRDj9svJVpLTfzaPenDuntkUEwb4f0E+LtnJXGid67t/xBU5b0C9Zoj7B54KiXMGlWEH3C0Gh/I2i3/G6fWvHIMQUsZpeh08MFmsmxwDgYT9TdHTvKxysuNYLPiq9p5tPJCQPMxIrscoP/Ei797H3ps3u0UdgyAlFpwY8qSM1Ki8H8mFmbo1auxBL9gHSH5MXeWQ3MVxO2L/toxtpuBMh/+3IaI9ZZRa83Eyvvv9Tatob12l0tvf7Az2NxWsJehjf+wD2VnSPrqQ0u4r4bYR/h86VTJgKUabxKf+CkqcWdWS6KgSlxGkc+gxI4HUA67sNRDCqxubTKOb/F4BbbJLHz7KartLIuTqctaKXMOpbKh12tdv3HGCALzEQMArKh1TMha9w9Syk5YxYmDwoQBGqB0lGHq2gIC0gfMeidQ9BRls7MZeyWB3NsagznML7vQ7hQs+tQcNSrBixMnGevXHxwdaL0elWqcf/hEueWblEj4/42Yrxkz4QRaMG0BODOosRerkWcJZgE2KofrwGfxbv3sbxxuwumOETuPdiO6pDv0cc0q4XNsRAtVn7uouSkXcArM0E4uA5wc6NrcrhhhVzUqA7pXEb8Eau1k9cuQzUptcXU9+1im0rdHtLP+LaDoYenyJMgQ5j1usO/A2Yo58OwMgH0Y7XQMWUSOROvQ0ENd1J/0+HycC1zO2gFpVE8lVht8kuw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4130.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(136003)(346002)(366004)(451199015)(186003)(26005)(31686004)(6512007)(4744005)(86362001)(83380400001)(478600001)(2906002)(31696002)(66946007)(6486002)(66556008)(53546011)(316002)(37006003)(66476007)(4326008)(5660300002)(8676002)(6862004)(8936002)(6636002)(41300700001)(38100700002)(2616005)(6506007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHJ3S1AvVnUxaWhRcmN4ZkN1T3h2bldJQytPdTk1bXl6anhjdFVCSjJJdHRC?= =?utf-8?B?NCs2MWtMNGlXc2gxT2xrZHJjZDhJQTJycFI1Vlp6MXBWbnVxSjhOYnRleVhk?= =?utf-8?B?VTNLZS9sbkM1VkhORUk2RWpqa0I0dDE3b1FhalBzWG5ENDYyVTBtVFNOcWFH?= =?utf-8?B?bHB2NHBXWDVOS0tTbnZuaCtDRldIR1d2V243T3YzWjk4S0NsdmxNN2hFSUZN?= =?utf-8?B?UjVZS25HZ0lvR2xrSmxlU2FEMHdMMVdQR0VqZVJUb0IvVlRrdmlxM0JWUnNT?= =?utf-8?B?dzdlMEZZMzBkQm9WbkloTG51L3NFNnRtOGhmcFd1SmlzajZkNXdEaDZGUW40?= =?utf-8?B?a2h6MFFZV01ISDFIL3lKUkVScHMzeUJSZVYvUXlGbkpiZ1I1aWJydHRGanZE?= =?utf-8?B?YzZzNlNwSXVhb1BBanhzcEw4S3lLSUVZN0JFVHBpVEQzMUJtaVRZS2hhUkJR?= =?utf-8?B?cUpTOXArUksrN3UzL09oOVlSbm9SaWdsS1FCRFZxcEZoQ2NBY0prR0J4cmpG?= =?utf-8?B?MVRGL08zaE1Wamt0MDBaQlBXM1czZUFJRnc2eStieFhBbWNYSTNsOEpOOXAz?= =?utf-8?B?azUxeE13dGg4U0l3VGladzlOUDVHZ1FGeWVKMFc2VzBsa3huZ3htNGloYkJq?= =?utf-8?B?RmtSRzVaeGlJanBELzFUL2xtTEZWeW5TS1J4Q0YvVFJySm9qb1haZlZRWmlr?= =?utf-8?B?RW4yZUNQSjZyd3FhTFY5cEN1WWZLSjBPc28wZ2pTR0VyNHczOVhoTmhLblZ4?= =?utf-8?B?cWdSei8ycHpBd0pwQVFpUTBQVXl0d2N6MUcvVGpCbkxmUnU4WGpHZWxzS0p6?= =?utf-8?B?dnAvWFR6eWNLRnFnT3owV3owYXVES0xjWVhZc1JvaE85NmpyNGQvQ0p3Z3Bn?= =?utf-8?B?Yi84Q0tybEhmWFJQOGdPWk5VQ1ZSb2ZlblQ3UGVDby8vbm80ZHl0aXN2N3pB?= =?utf-8?B?V2phSUIrdWJoRnZLbzk5KzNvUGp0TkdaREI2Y3VpeWxOOWI2blhjc0FieDFa?= =?utf-8?B?L3NUOXRXWmNBVFE3QjhWRjBlZmJ1cFJzREZVbWJ4czdiV3NQUDNyRkJZeGtE?= =?utf-8?B?OEtReGJPNzFrRWNxM2FFbXpVZ3FtRzkySFdYVko0YVRRdG1kR2plYlllKzNT?= =?utf-8?B?M1VOQ2UwaGkxMXJvd21ZeGtIaC9zN1lYWHhhcHdpeDBpdFU1S0ZJVmJUS0ZG?= =?utf-8?B?MzFub21EVzZzTE9qdnQ0T0FpZmdnNkdLYmc3eDhwRG1kVmRIYlY4UXdmVGNE?= =?utf-8?B?Zm56SlF5d3pmN2IvWGhqdy9kUlJ0dkQ5aEpwN0c2cERVSHM1N3Z2TkFDMktv?= =?utf-8?B?SlFDZm1DRktiOGRsVmM1S0M4dW53a05CZjNGVnB5d0pncXk2M25rRzh4b1lv?= =?utf-8?B?S0F5L3JQTng5YkQ5M1lVZHlsUUplTldaaUJwVjNuRE1PY3VmQVJ4eEkvSWN1?= =?utf-8?B?ekpZcUJ6aDI5TVF4VnZoc2tBN3ZCb1ZGNlc3b3d3UThRYktndlozbzhRVmxJ?= =?utf-8?B?c3RNQ05jNXBFUytkS3UrUWdjYnpIWmNjR2V1NUZDakc3ZDdHMFM5S1RoRFZF?= =?utf-8?B?ZzdxYzgyWms3QXhOVTgwaWxNNjhkeTA2VVpKaFViQjVkK1A2aXJ5Q0IwR1NI?= =?utf-8?B?RjIxOFdKakorcEdYelhaNHVyaStZWE9tVmpSa3Z0SG9YMTNpRUE2Z2VlK1JU?= =?utf-8?B?ZDM0MXZrcXZ3RDhqYTM3eHZpWThNUzh0V0hHVjM1cWp1clpvYmxGRi9vYzVV?= =?utf-8?B?T01Hb21jUytRaHJKTWo4cTVrbTZvR3lad2pUMnp0MStSaW9PMGxrWmZBNW92?= =?utf-8?B?Vy9MMXQzRmlBcFlBdDBWVm9GanZXeUhwNEQxWGJycVVHang2dEkwa0NEUlFK?= =?utf-8?B?WXJNNE5WUVgyUGlQZzRoSG1sZW5KRVBNRjU5Ti92S2pSVENSWjlKU0xUaXRy?= =?utf-8?B?UWpIMlBLUE5MM0JVczY2ZVFXazlXb21zLzl1d1cvQjdWNjBnTFRJUUJJbzhX?= =?utf-8?B?M1piVEFsRFI3dUpIVVFUSzdHTE1LTmxvbHlJbnQ4blNxWUY2akhvWnowR1lu?= =?utf-8?B?akRBK0I5dVE2VkFNVzhWeDZ3V1NZV3ZHbTdSSEx3SHVVa0poUWozT1pXR0pQ?= =?utf-8?B?VE4zRjdrd3JYNlUrOU55MUczNWxxWC8xbmxaMTNaRlhGVHp6NWZ4SEtzanBE?= =?utf-8?B?VUE9PQ==?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9dddde4-f358-49e7-9788-08dafb1c6384 X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2023 19:27:37.5511 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: brXKCg3qM5Vw8iIyP34WYihRzctR3eSc00cekaQnE5P/tfQoKKN6jqP+j4a5C5DIlv0kUwDU4Q68TXrwmay6sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5197 X-Rspam-User: X-Rspamd-Queue-Id: 97C8F40005 X-Rspamd-Server: rspam01 X-Stat-Signature: asjkx1a8msbq5bije6str9aopbswdut4 X-HE-Tag: 1674242859-114671 X-HE-Meta: U2FsdGVkX18mFyHMPWmlcJCQjg/kgDZxuXsrRMNdXRGp2+u6DrecU4WN1E0wr2hLI04OT38rWwZi4Dul3QDwy1tw79t1YqXfrMkq9stQgTh/bVfv0Vpes+U2bTv07F7PTbOFIQVvtZvHspvZsitcg+42UOQP0hkOr3bqMUrwhk4zBnO2kMuE1g9heGlODk/K0c1bRlqMB5/ZtgriBmSWfxDlZhk79X0Ycc8/QuWCfx4u6su5d4nPXf6HTOnA3goXxfr28xFeWUj0nXKB2l8U+yoTzNet0RznzMoRElS5CgQsR8cgbnZj9OecrS904miwsx2gebzLqK+CCON1WhOpqxnNNxG9QlZixR3RQ1pGLjsaBvkJ5wL60U1zyXmKtrWfl8mwmEe3Xv21MpZOu9rlgc/6YmaXj3bjff460l7uRrpePWbY4K6lAwtIhUmKMt2fsue+psgK7JBhV+/2iQdpq/UAA+3p/mp8hW9uBi1I079p2ebMOXV+Xgo0+CA4l6usA49gzvrqpYGU5JjMyZhcD75o35WjdmGVGP3cHjD9c963uValkpYRXvB77Bca+Gu1kh4TIdd6YvG8dAuMXD8rIQUll7K3ey5qZYz0L4qYg/Yi/7mGMj+r8uWbM7cE704l+pXQ8CZQmmW052BCP4z8Xt05kL5nDqT+HC/GwrDXSEPYE/ErbU6JIGEK68DpsLVqGTHGd4r/KCDBkYzOiqGyGPcb9o1rd6ObcEqI53BjB45tc7WspHp8kxnt6bPiLEPfYVBB7irChp26thzbGrS+yb6WwmEmt3L9XHUEqo9Q1aGEjZS0ETB8Z6CPfamm1MWu3NhpGY73gOaAViHfvDXTKL0s/urzz1YtRxD959rhH3aZPmDsxpnNtPftdIdm3jhffpR8yKNbtqZ9NL0t4SG6WCHX85y5Nox5WEQPjqg9J43TYxD+jJP/IPNNID62wSdbCCGdPKoGc59NZEKLesr DYKmkROJ rkh+P+ufW1gDywOMdg8UM4+/CaHpRLbbDdXJu3OuoxU1BtNr+pd3JyduanY3v1TaeYbeLzeR4TnNHE3tD+Umin4q1ASXTOqKayhhuu0xbkML5Pjs67CWsz85VX/uXFeaxcsaYXMEDMrks6KckPGyN1UjtbLXtAwqGAeIdOSV/b+nLoTwDjStHfMqfDKYGODojk9szMZcnF5TNV/6bg2vtm7kck++DGFeC2S9DW2NAEC+l2l0+AZNnw3bGMJvRme+uhQc6cBbxXZQSC3klYA51fTkbzt/boqG1uoQN+vQ4Ls6vPPo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/17/23 07:58, Jason Gunthorpe wrote: > There are only two callers, both can handle the common return code: > > - get_user_page_fast_only() checks == 1 > > - gfn_to_page_many_atomic() already returns -1, and the only caller > checks for -ve Maybe "checks for negative return values" ? > > Remove the restriction against returning negative values. > > Signed-off-by: Jason Gunthorpe > --- > mm/gup.c | 17 +---------------- > 1 file changed, 1 insertion(+), 16 deletions(-) > Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA