From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E7BAC4332F for ; Mon, 19 Dec 2022 19:36:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DB398E0003; Mon, 19 Dec 2022 14:36:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83C8B8E0001; Mon, 19 Dec 2022 14:36:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B64B8E0003; Mon, 19 Dec 2022 14:36:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 569758E0001 for ; Mon, 19 Dec 2022 14:36:05 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 29D0EC02CC for ; Mon, 19 Dec 2022 19:36:05 +0000 (UTC) X-FDA: 80260061490.17.5E91518 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 9C9601C0012 for ; Mon, 19 Dec 2022 19:36:03 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=s9FHKfcD; spf=none (imf18.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671478563; a=rsa-sha256; cv=none; b=RRwo/9qbCXBZYB+cAQm95lL+CeGw7j1irx4nLB4JhbpsPA7VaqyQKenJcChcSYYKLRZvTT fu4PGLtGDWGvPi7eg+Df1COnQ4du4XQ+15D2pRg71no+CVRqh8rTJWGsnyvN0n043bwM+2 KsWUdCai2DIHnKR5V5BsZFb7+sX7dMI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=s9FHKfcD; spf=none (imf18.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671478563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e+FXZ5wpPaeHanRbasiTVnh7zMisjpFCOPnjQFMGEtY=; b=vnf1H6h2CtTHIJmuUSXoxIAy0TEBnU1M7kV3FNWCYr8VbRbjO+yiYdA0PgDEOj+sE2uuod D96XZo16TNIbBjhzenLwYWjIxUS2Uu0gar3nzy0pzxd6APLM4hCE5KxIy1vV2s16jIECTG SWRDzqSaziRjWPxKWW3LRJTe3D2+vf8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=e+FXZ5wpPaeHanRbasiTVnh7zMisjpFCOPnjQFMGEtY=; b=s9FHKfcDlHJUpRRpWkxpS8oK75 nYLRIiDEUWGUsjaVw6tEXHRyhrhevcTOQ6dbGIjrP+iQgwiLnllEg5vxCpEEfKqHCsxPA/fm67efA xAly+uib54I5jomt3A/7dBBmt6Pg+5wYSFHdqFDgn06+ZEaw/peatpmuh9qWi4SgKNfIN3OiaLdjY uX4oDNcD1dfp8LLu3NsA4/Qp4AGReGWFxNLvb3/Xc8LwSxUrgK3KmEAdZ/4j7A+jmqHlr3NawdXNL NRqCBt1tE1CPT4lRjYEuPQOCP+UMcwfqESNG9GSq3U4Oj8Py8Ejxyq19HX21H3OyyouCpV6MPB/2a R0xJeV2w==; Received: from [2601:1c2:d80:3110::a2e7] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7LvJ-00162Q-4J; Mon, 19 Dec 2022 19:35:41 +0000 Message-ID: <82feabee-0446-b913-adbb-0e96ecb10c94@infradead.org> Date: Mon, 19 Dec 2022 11:35:38 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC v3 3/4] mm, printk: introduce new format %pGt for page_type Content-Language: en-US To: Andy Shevchenko , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Joe Perches , Petr Mladek , Matthew WilCox , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20221218101901.373450-1-42.hyeyoo@gmail.com> <20221218101901.373450-4-42.hyeyoo@gmail.com> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 9C9601C0012 X-Rspamd-Server: rspam01 X-Stat-Signature: pj37o1enc5mr3ofyrc3z4qnhmr47gyjj X-HE-Tag: 1671478563-776181 X-HE-Meta: U2FsdGVkX19rwWewtxbIRbU7a2/WWdI+jI7WN/Z5oE7VFuKYvBUrP637IZeF8jrwhlHgGhR+wY3Rpq2v0RiVv7egANHpyfG6UB6eqHQPoT4kkGSBPxTtRLwBlJEdYrhmcW76LDKFBmLzQE27RzQiQZCh/f5lB8GYMy3JpOA/xA23m2rsip/1Fg9W4WdnKFfelsSB07aLXrmoEbPs/vFDm+yC3NFivWPQLU+nWXQrP7wZZXxKYiNBdAfzYmOWES3n3YZcn7YL5x19NtCwctni3IRJo+wcUmCsfeZHpvxNxbIW2jUJ2KqbI4XylL0DPFNjioAhcvqlYrbn4FSY88nFs1GA79hBnzMtsrX3MDc84e7Cd6P6Caek64sVu+aN5sWRH4FWl4QlWLnOi9vl24ulZaayThwGmkdlQw7abtIQse7KVii4qQ5eI0AJsQ43drFUp1YGXbT49njXtOTyYAbRecJEYy4+PE9rnnv4JQ6qogFJYDnub2iGfkcSfqEfK/9XrlifL/a3ExlveyKnjaw8dHpnofB3haDPGeo0gRS1Fg49wyhmySAhL8yezIoaeHRfm5cMTRStPW6b1rl7QwWvUS1sCSWD2BUvK0EdxTRyaqVXhOA0QpMHma7M5xpExrVdK0tJQ+ljlBMuh4N3gwuq7qUF7Cn4edre7T3+Yws0Tr4yvRE4EzwnMLZF2CoKqGmpwPVqg1GOICYTLanMw8jIO3zwzQQGZSnaYCrH7ccZHm5mlG2h+GZHRDFqv5bJIBotMgdehxdR6XiPljRawexlXHUyU8o394eLVuk9ZDLLvnwjhO8mjI2lEO8oJ7D3hmMyhRb0oFMO10IwnSKdkiojzDBf6gK4vdF9DY5RG3FaH9C9qq5SYkXwyW8PVUXlMrbHMH6Q2o2chQjreOea4+dhuJDTQKMA61A3SmW1HJsaloOXwCyt+XH1HL0bOtGRM8HT8kvkpCEhJ9RKWXgC3ta zyngjXcP nlPUn9Cy1kD0KIXHJlApeP2+h+PorkfxiwJE8NoMND0z6mNU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/19/22 01:44, Andy Shevchenko wrote: > On Sun, Dec 18, 2022 at 07:19:00PM +0900, Hyeonggon Yoo wrote: >> %pGp format is used to print 'flags' field of struct page. >> As some page flags (e.g. PG_buddy, see page-flags.h for more details) >> are set in page_type field, introduce %pGt format which provides >> human readable output of page_type. >> >> Note that the sense of bits are different in page_type. if page_type is >> 0xffffffff, no flags are set. if PG_slab (0x00100000) flag is set, >> page_type is 0xffefffff. Clearing a bit means we set the bit. >> >> Bits in page_type are inverted when printing page type names. > > ... > >> +#define __def_pagetype_names \ >> + {PG_slab, "slab" }, \ >> + {PG_offline, "offline" }, \ >> + {PG_guard, "guard" }, \ >> + {PG_table, "table" }, \ >> + {PG_buddy, "buddy" } > > Wondering if it will be more robust to define a helper macro > > #define DEF_PAGETYPE_NAME(_name) { PG_##_name, __stringify(_name) } > ... > #undef DEF_PAGETYPE_MASK > > In this case it decreases the chances of typo in the strings and flags. I'd say Yes. (and #undef DEF_PAGETYPE_NAME methinks; or change both to _MASK) -- ~Randy