From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2D4EC54E64 for ; Thu, 28 Mar 2024 12:32:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67AD16B0088; Thu, 28 Mar 2024 08:32:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62AE46B008A; Thu, 28 Mar 2024 08:32:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CBC06B008C; Thu, 28 Mar 2024 08:32:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 306156B0088 for ; Thu, 28 Mar 2024 08:32:07 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E99D5A03CE for ; Thu, 28 Mar 2024 12:32:06 +0000 (UTC) X-FDA: 81946385052.04.2A8BF6E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id BECE5100024 for ; Thu, 28 Mar 2024 12:32:04 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZRbOAzJ2; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711629124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3m5kSDYad1ASNQOmuqdkZZKn3i6Nx7m7/QioJsUV9fs=; b=jxWk3TETEb3qOcLfJs/pF6b2Kd9NIk726pRgCIdhxqBvmqAw52nyYGlL5NZvB3w78mNvDL oDdogzKmF325Q1ia2gJcn6gcXPSf534wEAqebPDVU9Emd/R7PzP6FqsdR6vy4+qUTDX15p mbYXNGGiWUkqJNtGJtRjZnWAHDvzrrs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711629124; a=rsa-sha256; cv=none; b=QM53HLZp7/KSW2WAC7F7EC/8dfH/qmAa63njZKA2N1YJMI+3BpEFWPvG3CIB76ronBdkg2 ENAwINNtQXpnHCh8B1jfrxoj0+angFK27BP1RQyiuIjvwZSeziY2MI8glX02N4u6fSMgs9 7lxXGS6AYaXIZ+c/l3GS4dv4jWA9dYc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZRbOAzJ2; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711629124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3m5kSDYad1ASNQOmuqdkZZKn3i6Nx7m7/QioJsUV9fs=; b=ZRbOAzJ2yIeRCp4tsvEVupLJJsSnVnHs4vjTr9f9ZVV7HhIyxVFNzilwjufxESQXaczecp 4yg06S+MnmaAhYpeBUI4ZOdCIXEbZkSDCMKImNelCsi2XmCdJQVFgcMPBfBnF3LgP6pww6 Um+UvguvEaO2tjGIu219kSe0TNa6gxs= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-auGfa_BQN1SXUm32VhC82A-1; Thu, 28 Mar 2024 08:32:02 -0400 X-MC-Unique: auGfa_BQN1SXUm32VhC82A-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d48e62e525so6829861fa.1 for ; Thu, 28 Mar 2024 05:32:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711629121; x=1712233921; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3m5kSDYad1ASNQOmuqdkZZKn3i6Nx7m7/QioJsUV9fs=; b=CE4VETlli64+S13nRCmj+7m8H8J8TetvendHvBV7e9fwb+kOTeEpRcDX2mtOYBAsNf 9uciSmr/SaDrWeL+Y53UVBUjtseNo2DCxySFWd9HBNxo6ZoX3DGxn2Q7IStAg3VT8aeX RxV96ts3G7gjuAmsVC6IwOpI9iJsVYGoiC2kfK6pZgtDKBlQxdY1bV2cDg8pEQBW/bPq afEmj2ZyycpCWFT7UF0xlgqYxCI8GTgdyl0ZdyCySpghSt4S54wGMVkQECgmbBqYW+cB ada9y3EjiGhKwwD0LF+3eFpcesy5ynxHl7cJlWXO7ySiIPLjof4cmiXuNRpKy1q9wluF 4Nvg== X-Gm-Message-State: AOJu0YyvRaLi4IvvJX/wKQW4FSLTIeCJQEHDxFnsLHvmmadz/D5wYa/U 2qHkIYQsURSsMYZkgnXSB4QzBfLLR5Jy22S2Mezd6mfTg0lhz8apKBJfMm3FP0oleGEzCnFNMzl i4XnuwUk37nCB44PzE6xttQZP5mpHz5W21Pd2qhqU5zNvrfUG X-Received: by 2002:a2e:7411:0:b0:2d6:af80:bc7c with SMTP id p17-20020a2e7411000000b002d6af80bc7cmr1887365ljc.7.1711629121072; Thu, 28 Mar 2024 05:32:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGfNEJv3XkPUJFCK9dwVWRnSchYN5FiiSVWL4nsoLPRzattPGpOIRz/voZxSJIdaz30r5VEvg== X-Received: by 2002:a2e:7411:0:b0:2d6:af80:bc7c with SMTP id p17-20020a2e7411000000b002d6af80bc7cmr1887350ljc.7.1711629120645; Thu, 28 Mar 2024 05:32:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c714:3600:8033:4189:6bd4:ea29? (p200300cbc7143600803341896bd4ea29.dip0.t-ipconnect.de. [2003:cb:c714:3600:8033:4189:6bd4:ea29]) by smtp.gmail.com with ESMTPSA id ea2-20020a0560000ec200b003432d79876esm1621953wrb.97.2024.03.28.05.31.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 05:32:00 -0700 (PDT) Message-ID: <83078db2-bc9b-4b1c-83a5-75b145173716@redhat.com> Date: Thu, 28 Mar 2024 13:31:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Increase folio batch size To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Yujie Liu , kernel test robot References: <20240315140823.2478146-1-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240315140823.2478146-1-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: wcs1t7oyzetgdedp7cee89tgy537prru X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BECE5100024 X-Rspam-User: X-HE-Tag: 1711629124-917403 X-HE-Meta: U2FsdGVkX180kBirso8A7hdOiiwbUZRK67vkjWpMM/6CywAou26XjwE1L/P7ct5RMITX1HvxFHPzpCD3+PiUQWUFtIYEpU9J/NySEBIkWb448fj+EKtKzPcbwBsXcIw3HNCkjL9UCNjKP7IzNNp7ySgbIQmp5W65BXMded4FJGU8Ujmgfae7c/u4B0gEZdRvtXIlWUO3YaBeXh3I38lF1Fmxn/wVmEifuTl9Csz2almFP1WetIQ2wbfc3rI8GkfZqbe5pFyvqAeCCD2mzsZAcy1Rr60FGviZIJuouVdRZv0Cr69DJNuoNi7qbnBr4lTBw4hlmiGIFnaSKs5Y+cfTZeB8RhqkyGMR0HSLE/RYhCX2Qygt4OtwssP+EWrKqrRYsAjFDRRQYpgQ8BAopShtE0AqyE5sCDCM2NyUVPETxgt/uWucABqoIdzr95oEhHFw7OAUqI3OJbYA7I9ZHUK03whTXxx+nBr93ZVOtXtyAQLAUGD6Em8UnQ668oVp9iYs7mdbE/GnBMlERBFZwR/000q+RXxyTFB3t7orpVDqEDfvDNJ08Njg7BhYDc3znFhqcPyTlaUrUiOWbPEaZzNIImf/uKEWhAGQBFyHAMiogDc1EgTCS7z6KH+rvqgoSMElzDdRu5bmqHnDoK8pYgz5udVK5X6NvHt8MmqkD2cPLSPDDEYxIUs+oZmhs3ARJNkcya/2BNjQeAxUjY+CamIS6U/e1WyucOWSNr19a8sHR+HkWujiKV0v6AL9C2zcLj3x4Jw1BYbhfoZTXlBAys7RRrXFVyRxvn1yC2+niKLyAJNWc+PaUlpe4Rn42Yvfq3MaXe9PjNjOkx7SwlMub/Y4UxhgoTiAQQ9l1nlQW3QTG1aqQL8EiiolMn3Bm7OuwPck4AL+wrVgkiFBw5CCRxsA6GNMjCyvv/fMnkMk4SfCxx8J9RwMtk0CQfBAFiFp1ZZY6eEs7XnS6H7P5kIqdQm m/4LGfNb aCug5oj5U6bBaDZ3qacfDuuslWxMW1UFfMa1fxWxn7FYb9RKPYKYdkAUTfHkIC3QStEcMHDYCrgghTsLJ6k/LtYVWXg3mwg29Mpk9bODdbPWdNNuidvRlsniApJu4SIfFcPeDohnsstGoi0Z55cqKKAe+wODItHjgWzJs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.03.24 15:08, Matthew Wilcox (Oracle) wrote: > On a 104 thread, 2 socket Skylake system, Intel report a 4.7% performance > reduction with will-it-scale page_fault2. This was due to reducing the > size of the batch from 32 to 15. Increasing the folio batch size from > 15 to 31 gives a performance increase of 12.5% relative to the original, > or 17.2% relative to the reduced performance commit. > > The penalty of this commit is an additional 128 bytes of stack usage. > Six folio_batches are also allocated from percpu memory in cpu_fbatches > so that will be an additional 768 bytes of percpu memory (per CPU). > Tim Chen originally submitted a patch like this in 2020: > https://lore.kernel.org/linux-mm/d1cc9f12a8ad6c2a52cb600d93b06b064f2bbc57.1593205965.git.tim.c.chen@linux.intel.com/ > > Tested-by: Yujie Liu > Fixes: 99fbb6bfc16f ("mm: make folios_put() the basis of release_pages()") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202403151058.7048f6a8-oliver.sang@intel.com > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pagevec.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/pagevec.h b/include/linux/pagevec.h > index fcc06c300a72..5d3a0cccc6bf 100644 > --- a/include/linux/pagevec.h > +++ b/include/linux/pagevec.h > @@ -11,8 +11,8 @@ > > #include > > -/* 15 pointers + header align the folio_batch structure to a power of two */ > -#define PAGEVEC_SIZE 15 > +/* 31 pointers + header align the folio_batch structure to a power of two */ > +#define PAGEVEC_SIZE 31 > > struct folio; > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb