From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3BC6E7716D for ; Thu, 5 Dec 2024 15:20:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C1396B0119; Thu, 5 Dec 2024 10:19:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D31766B00F0; Thu, 5 Dec 2024 10:19:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8671D6B00C2; Thu, 5 Dec 2024 10:19:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 664E66B00D0 for ; Fri, 27 Sep 2024 06:52:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BEFB780C0F for ; Fri, 27 Sep 2024 10:51:59 +0000 (UTC) X-FDA: 82610203158.17.C73597E Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf19.hostedemail.com (Postfix) with ESMTP id 4A5F91A000D for ; Fri, 27 Sep 2024 10:51:57 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=h7mw47rM; spf=pass (imf19.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727434195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fPuhzUy6xOp23Z1T42Ea5imkYUyKl/C4Lt0yHBenfCw=; b=oeUKh6ZOi9vZm80vOu33xS8a0NIdACpwOg7XPP7Pimx8Do00djyTjA2YD1eT5sD42GrO2i OSIG+2woUZZNucgYzZhA7iSBsONHxHHHse/1p6sXNhIJ56oEtuBPki8koTbJl/99iT/d6N duIQ+y/oQ1XAuOuxAeqnB1wbLHE9RgA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727434195; a=rsa-sha256; cv=none; b=AYD/yTJur3UXjUes/KSrMqr82ondIlqzeJlFeRz59WIsFsQly9DWyv5pGoDXMaWEbegiSR tFIahmparLAByUb4HHzMVqOc74UPqOEvQFaAx+N4LmxSV9Ri92oGkcSeB5jTLnFKwgeW1N MO47I2RJKZKlbv2DIqSn3U2fh3Iep+o= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=h7mw47rM; spf=pass (imf19.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48R28f6C011293; Fri, 27 Sep 2024 10:51:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=f PuhzUy6xOp23Z1T42Ea5imkYUyKl/C4Lt0yHBenfCw=; b=h7mw47rMYLTFe3i8N M3Mfbme28zwLIGSlO/BuCfL/1nNx2o1o7935AkCrQs0Is6viPS9JBbwT35vuAb/Q uCzdZEdAAPrRcknO3bpKmpw4SNwYvygiip6IY9+g9oF4LOm8kIPerx6sDkw48LL8 ajR3hxBbWnzCrAxxT9VAr4stPYnvWsZca8SeHmQIYyUPN41mQzOirtHkpQ7dTnZi L81npyHkpsmKdLDEjzxLPzVIcs1klDQn9ob1eo7LOppsAV824bUgnldbYVCi+YKx ewsR+rZuESnuTD9DJBQ3ZGoaRY/8QJ1T5gC/bYbPyaQ4LKiiuQChSnGZThaKMGir 9mnfQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41wkmnj1e8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 10:51:38 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 48RApbWp007059; Fri, 27 Sep 2024 10:51:37 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41wkmnj1e6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 10:51:37 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 48R7UtNB005816; Fri, 27 Sep 2024 10:51:36 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 41tapmv4rs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 10:51:36 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 48RApaha12780244 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Sep 2024 10:51:36 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E260E58064; Fri, 27 Sep 2024 10:51:35 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 622485803F; Fri, 27 Sep 2024 10:51:32 +0000 (GMT) Received: from [9.109.245.146] (unknown [9.109.245.146]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 27 Sep 2024 10:51:32 +0000 (GMT) Message-ID: <831bb979-e27f-4af0-b933-5b05895aff8f@linux.ibm.com> Date: Fri, 27 Sep 2024 16:21:30 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Fixed incorrect buffer->mirror size in hmm2 double_map test To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Kees Cook , Mark Brown , Przemek Kitszel References: <20240927050752.51066-1-donettom@linux.ibm.com> Content-Language: en-US From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: i12dFmAq3Hevtz9IABOOu966WjoIDjEs X-Proofpoint-ORIG-GUID: _u6yGHmU5kJTiODlSHDiyTLGkrpC4gGx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-27_04,2024-09-27_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=891 priorityscore=1501 suspectscore=0 malwarescore=0 mlxscore=0 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409270071 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4A5F91A000D X-Stat-Signature: ejt4oorrb9qx1xautb3urkbdozodhqdw X-HE-Tag: 1727434317-499939 X-HE-Meta: U2FsdGVkX19bnHi9VV3pTSatPniPpA+uqMTnC35lbLpFDCRylxc6KgRmAHzHayoUmffUQikob/ijxxoo9QPU0aNGqhKIDNqf6VxO8enPILZGe4cc6mQUMIaR2W8qWqgct/UM5vYlDhUCZVNOsW2iK5dtfqDmR9fIa1B0wM6xiP3DziuQ9zWvN8AP+pkTjqUE7wr5yk4tJG6JNQ4LXRIFansD8Azos551oZ3h+c6gMWFoQfdwLhK+pZ2dYlYl0WX6zT2lG7ho7sxib4HlCgZb/rJyWZhjDOlsiVju8BlJzOn4UaUvP9o/mKJlRk/Qi0/RdgUT5BxHEdkFTWIWP+PsdjfGmOxD1sDlnlSRq+HG2qa8RJUHD6MykwDCA2FCmb6Os1++W+amOCXKPiRwppEPI4gsgGYD+UCsbbnFAAcbL6zDQFo8xXiq6b0OpbMlfmse+eBqnkGbnwmrVG2YGSR3ttLHOBfuI6M8n8Uarn2+T6zYmRqHluG7LdmpVBLlaJ3ZrCIU3a5hAE4uBLhzPkSyKZGk8pdFiJciS1h8YecEsrawMgZ8hx46zEwKA+HASvonZPbhQ2qjBfVtyEwKBN2i9M6llmyS9trbwoD4oUhR9+Iphj9ocqUjQU4FLsSxYSLP/csz4cabrqW0t6NmSA5AcFj1m+O91fNkXvtWJBHp0VjPGwmftGyhNAw/nIR66oaTucFR4dHwimxudxgHq4Z87XZBwQNzWF8HBmzGXjvF/EE19ZEqQPR1r4WNwsSJw5XKZXqs4W/1apbxIrDWynlpk8TMVdcc8ts2xzQZn5rrNhLZLJ+5cY7cxGd85tYbO3XEaJZ+BzvkeMsMgDGoW8J6aB6WWDIDH/+eGHaSctE/5rZoE4UwThww+5MK873ibrASfYLyX24Vfc1NEtdv/QZck3yhUAyQPK0BT4JMx3Y7zb2gW81++Wo+H0MsMg1rgPAV2G55Jl1Y1T4NqeJP+Pa qW7s7p+6 iPUoKk28vpGeMnccGvKSxFVx96kChu2T1dnrHy8Euth1dKRUQsTEahmZwkyhAoaxWwOpHFyorZe3yXZTuT+Fo3jX10vmPUBIjX7ltLuxv73YeA35ZynHvqVO+VNACniKc84dQa6oc16tBKzzCfIGk3RWAZz9yqQ50+IaCybgvmjJIiW4QdvM8MxH/RPRalTiaWFGIyHTdlgHcVMUCvs2FpvGi70+9odpntAItSND4l6ZcqLd1n5dWB1CoZZl0qesMn52iJzsU40adC+iYA+Ne7pq+/qzk5ci469/laYfaYnZNrAsJSg3MKOF7ogK6CJz3awMnVFkR4twLphwJ6St9tUveGEpkH0IQ5aiF8Zr9uMHghN3y2ribk0RTAzrOOsAK4DtYzlOGTiWAM5fMHNvm8dd9KCQmvGZC+UrXXb8nYoFrd43EW4mg57GOElawL09lbKHO8e/OVSara4sEHRM09y0iqRDLzliv8hQOhbZUoqK4UHAeTd24ZvSpMFltMxY3YRKi1Erj/iNPOBM8gkwhBcj+ljo8KkOsZ0UdmfLSg6wjP04= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/27/24 12:48, Muhammad Usama Anjum wrote: > On 9/27/24 10:07 AM, Donet Tom wrote: >> The hmm2 double_map test was failing due to an incorrect >> buffer->mirror size. The buffer->mirror size was 6, while buffer->ptr >> size was 6 * PAGE_SIZE. The test failed because the kernel's >> copy_to_user function was attempting to copy a 6 * PAGE_SIZE buffer >> to buffer->mirror. Since the size of buffer->mirror was incorrect, >> copy_to_user failed. >> >> This patch corrects the buffer->mirror size to 6 * PAGE_SIZE. >> >> Test Result without this patch >> ============================== >> # RUN hmm2.hmm2_device_private.double_map ... >> # hmm-tests.c:1680:double_map:Expected ret (-14) == 0 (0) >> # double_map: Test terminated by assertion >> # FAIL hmm2.hmm2_device_private.double_map >> not ok 53 hmm2.hmm2_device_private.double_map >> >> Test Result with this patch >> =========================== >> # RUN hmm2.hmm2_device_private.double_map ... >> # OK hmm2.hmm2_device_private.double_map >> ok 53 hmm2.hmm2_device_private.double_map >> >> Signed-off-by: Donet Tom > Please add Fixes-by tag. Other than this, LGTM Fixes-by : Donet Tom I have added the Fixes-by tag here. Please let me know if you would prefer that I send a V2 with this tag. > > Reviewed-by: Muhammad Usama Anjum Thank you Donet > >> --- >> tools/testing/selftests/mm/hmm-tests.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/mm/hmm-tests.c b/tools/testing/selftests/mm/hmm-tests.c >> index d2cfc9b494a0..141bf63cbe05 100644 >> --- a/tools/testing/selftests/mm/hmm-tests.c >> +++ b/tools/testing/selftests/mm/hmm-tests.c >> @@ -1657,7 +1657,7 @@ TEST_F(hmm2, double_map) >> >> buffer->fd = -1; >> buffer->size = size; >> - buffer->mirror = malloc(npages); >> + buffer->mirror = malloc(size); >> ASSERT_NE(buffer->mirror, NULL); >> >> /* Reserve a range of addresses. */