From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>, Christoph Lameter <cl@linux.com>,
Yafang Shao <shaoyafang@didiglobal.com>
Subject: Re: [PATCH v2] mm/vmscan: shrink slab in node reclaim
Date: Wed, 7 Aug 2019 11:03:51 -0400 [thread overview]
Message-ID: <83922dc9-c556-1aae-fd5c-6199aa60c87c@oracle.com> (raw)
In-Reply-To: <CALOAHbBPSJx4ZmsEDt6LfbVSPW1CfYTrbQvGas_SDWVd_v0wEw@mail.gmail.com>
On 8/6/19 9:03 PM, Yafang Shao wrote:
> On Tue, Aug 6, 2019 at 11:59 PM Daniel Jordan
>> Do you plan to send the second patch? If not I think we should at least update
>> the documentation for the admittedly obscure vm.min_slab_ratio to reflect its
>> effect on node reclaim, which is currently none.
>
> I don't have a explicit plan when to post the second patch because I'm
> not sure when it will be ready.
> If your workload depends on vm.min_slab_ratio, you could post a fix
> for it if you would like to. I will appreciate it.
We have no workloads that depend on this, so I'll leave it to you to post.
> I don't think it is a good idea to document it, because this is not a
> limitation, while it is really a issue.
Sure, if it's going to be fixed, no point in doing this.
next prev parent reply other threads:[~2019-08-07 15:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 7:19 [PATCH v2] mm/vmscan: shrink slab in node reclaim Yafang Shao
2019-08-06 7:35 ` Michal Hocko
2019-08-06 7:41 ` Michal Hocko
2019-08-06 8:57 ` Yafang Shao
2019-08-06 9:05 ` Michal Hocko
2019-08-06 9:15 ` Yafang Shao
2019-08-06 9:25 ` Michal Hocko
2019-08-06 9:32 ` Yafang Shao
2019-08-06 11:14 ` Mel Gorman
2019-08-06 11:35 ` Yafang Shao
2019-08-06 15:59 ` Daniel Jordan
2019-08-07 1:03 ` Yafang Shao
2019-08-07 15:03 ` Daniel Jordan [this message]
2019-08-06 9:50 ` Mel Gorman
2019-08-06 9:54 ` Yafang Shao
2019-08-06 10:28 ` Michal Hocko
2019-08-06 10:59 ` Yafang Shao
2019-08-06 11:09 ` Michal Hocko
2019-08-06 11:34 ` Yafang Shao
2019-08-06 11:58 ` Michal Hocko
2019-08-06 8:23 ` Yafang Shao
2019-08-06 15:29 ` Daniel Jordan
2019-08-07 1:00 ` Yafang Shao
2019-08-07 15:03 ` Daniel Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83922dc9-c556-1aae-fd5c-6199aa60c87c@oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=shaoyafang@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).