From: Alex Shi <seakeel@gmail.com>
To: Vishal Moola <vishal.moola@gmail.com>
Cc: alexs@kernel.org, Vitaly Wool <vitaly.wool@konsulko.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
minchan@kernel.org, willy@infradead.org,
senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com,
Yosry Ahmed <yosryahmed@google.com>,
nphamcs@gmail.com
Subject: Re: [PATCH v4 06/22] mm/zsmalloc: convert create_page_chain() and its users to use zpdesc
Date: Fri, 9 Aug 2024 09:57:01 +0800 [thread overview]
Message-ID: <839f2c4b-5312-447c-a3de-6c8fc098876e@gmail.com> (raw)
In-Reply-To: <66b50d7f.170a0220.2171ed.8a4f@mx.google.com>
On 8/9/24 2:25 AM, Vishal Moola wrote:
>>> I'm not a fan of the names above. IMO, naming should follow some
>>> semblance of consistency regarding their purpose (or have comments
>>> that describe their purpose instead).
>>>
>>> At a glance zpdesc_set_zspage() and zpdesc_set_first() sound like they
>>> are doing similar things, but I don't think they serve similar purposes?
>> zpdesc_set_zspage() only used in one place, a helper maynot needed. Let me remove it.
>> Same thing for the alloc_zpdesc() and free_zpdesc(), they could be merge into using place.
> alloc_zpdesc() and free_zpdesc() are fine as is. The helper functions
> will be useful whenever memdescs can be allocated on their own, so its
> better to introduce it now.
Thanks for suggestion. will recover them in next version, maybe tomorrow if no more comments.
next prev parent reply other threads:[~2024-08-09 1:57 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 11:25 [PATCH v4 00/22] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool alexs
2024-07-29 11:25 ` [PATCH v4 01/22] " alexs
2024-08-02 18:52 ` Vishal Moola
2024-08-05 4:06 ` Alex Shi
2024-08-08 18:21 ` Vishal Moola
2024-08-09 1:57 ` Alex Shi
2024-08-02 19:30 ` Matthew Wilcox
2024-08-05 4:36 ` Alex Shi
2024-07-29 11:25 ` [PATCH v4 02/22] mm/zsmalloc: use zpdesc in trylock_zspage/lock_zspage alexs
2024-08-02 19:02 ` Vishal Moola
2024-08-05 7:55 ` Alex Shi
2024-07-29 11:25 ` [PATCH v4 03/22] mm/zsmalloc: convert __zs_map_object/__zs_unmap_object to use zpdesc alexs
2024-07-30 9:38 ` Sergey Senozhatsky
2024-07-29 11:25 ` [PATCH v4 04/22] mm/zsmalloc: add and use pfn/zpdesc seeking funcs alexs
2024-07-29 11:25 ` [PATCH v4 05/22] mm/zsmalloc: convert obj_malloc() to use zpdesc alexs
2024-07-29 11:25 ` [PATCH v4 06/22] mm/zsmalloc: convert create_page_chain() and its users " alexs
2024-08-02 19:09 ` Vishal Moola
2024-08-05 8:20 ` Alex Shi
2024-08-08 18:25 ` Vishal Moola
2024-08-09 1:57 ` Alex Shi [this message]
2024-07-29 11:25 ` [PATCH v4 07/22] mm/zsmalloc: convert obj_allocated() and related helpers " alexs
2024-07-29 11:25 ` [PATCH v4 08/22] mm/zsmalloc: convert init_zspage() " alexs
2024-07-29 11:25 ` [PATCH v4 09/22] mm/zsmalloc: convert obj_to_page() and zs_free() " alexs
2024-07-29 11:25 ` [PATCH v4 10/22] mm/zsmalloc: add zpdesc_is_isolated/zpdesc_zone helper for zs_page_migrate alexs
2024-07-29 11:25 ` [PATCH v4 11/22] mm/zsmalloc: rename reset_page to reset_zpdesc and use zpdesc in it alexs
2024-07-29 11:25 ` [PATCH v4 12/22] mm/zsmalloc: convert __free_zspage() to use zdsesc alexs
2024-07-29 11:25 ` [PATCH v4 13/22] mm/zsmalloc: convert location_to_obj() to take zpdesc alexs
2024-07-29 11:25 ` [PATCH v4 14/22] mm/zsmalloc: convert migrate_zspage() to use zpdesc alexs
2024-07-29 11:25 ` [PATCH v4 15/22] mm/zsmalloc: convert get_zspage() to take zpdesc alexs
2024-07-29 11:25 ` [PATCH v4 16/22] mm/zsmalloc: convert SetZsPageMovable and remove unused funcs alexs
2024-07-29 11:25 ` [PATCH v4 17/22] mm/zsmalloc: convert get/set_first_obj_offset() to take zpdesc alexs
2024-07-29 11:25 ` [PATCH v4 18/22] mm/zsmalloc: introduce __zpdesc_clear_movable alexs
2024-07-30 9:34 ` Sergey Senozhatsky
2024-07-30 11:38 ` Alex Shi
2024-07-29 11:25 ` [PATCH v4 19/22] mm/zsmalloc: introduce __zpdesc_clear_zsmalloc alexs
2024-07-29 11:25 ` [PATCH v4 20/22] mm/zsmalloc: introduce __zpdesc_set_zsmalloc() alexs
2024-08-02 19:11 ` Vishal Moola
2024-08-05 8:28 ` Alex Shi
2024-07-29 11:25 ` [PATCH v4 21/22] mm/zsmalloc: fix build warning from lkp testing alexs
2024-08-02 19:13 ` Vishal Moola
2024-08-05 8:38 ` Alex Shi
2024-07-29 11:25 ` [PATCH v4 22/22] mm/zsmalloc: update comments for page->zpdesc changes alexs
2024-07-30 9:37 ` Sergey Senozhatsky
2024-07-30 11:45 ` Alex Shi
2024-07-31 2:16 ` Sergey Senozhatsky
2024-07-31 4:14 ` Alex Shi
2024-08-01 3:13 ` Sergey Senozhatsky
2024-08-01 3:35 ` Matthew Wilcox
2024-08-01 8:06 ` Alex Shi
2024-07-30 12:31 ` [PATCH 23/23] mm/zsmalloc: introduce zpdesc_clear_first() helper alexs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=839f2c4b-5312-447c-a3de-6c8fc098876e@gmail.com \
--to=seakeel@gmail.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=vishal.moola@gmail.com \
--cc=vitaly.wool@konsulko.com \
--cc=willy@infradead.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).