From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 135C1C3DA4A for ; Fri, 9 Aug 2024 01:57:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BAE26B0082; Thu, 8 Aug 2024 21:57:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86BB86B008C; Thu, 8 Aug 2024 21:57:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75AC56B0092; Thu, 8 Aug 2024 21:57:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 567AB6B0082 for ; Thu, 8 Aug 2024 21:57:09 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0837F8056D for ; Fri, 9 Aug 2024 01:57:09 +0000 (UTC) X-FDA: 82431044178.20.9A7C4C8 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf03.hostedemail.com (Postfix) with ESMTP id 126642002E for ; Fri, 9 Aug 2024 01:57:06 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=i5jiabct; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723168573; a=rsa-sha256; cv=none; b=yUVYsp9eIImleuSnmyWylAhJeb6Q2kd+4fOEh42xwfOCZsCgcWpMyeRDKggCohZiWxa/+C sjJa1shwH2hjvEi4VtPI5YyEZYiYWQ1jaVLeDYUtmvdkhNCPXiuDKhKTBSEOVFOpdViH8s WQPug8epd14X66Y80b1I/REzbfwX5zA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=i5jiabct; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723168573; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r231GslQSVbZ+GOnXC04E/yfa0+FwVvQveaHgqzV384=; b=moC97F4bzgRFwvwCLu/UrtCl6hkruLIsJyw9fZTwwu98xhXQrEn2FvwDCyMdT7ykkTGjml cU4COelCWMSP8flUd/TJ6q4es0L3rjo3nw/LzEpP5X/c2jdBrxsXPb2NffiiWoA6fUrbij FK8bM6wmSpzEi+HfmkSNJUCfN61gtN8= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-70d2b921cdfso1405779b3a.0 for ; Thu, 08 Aug 2024 18:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723168626; x=1723773426; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r231GslQSVbZ+GOnXC04E/yfa0+FwVvQveaHgqzV384=; b=i5jiabcthjcICjfZy/yfEMU7N/e2Y1eRqKar3G9pOFryyrbd/fDkKOgsMu0nRcXdDr cGwWlDxYbzBT4tYFBuyfL3T7sJCO2dh9Rb8yT+g0KC4nS5/E7ZrAtYD6PaBan12W5JSW hFKdNB/gryQcYjlnkDKq6pmoqx/FEGH8ap34bEgyPW7pYAe3geYCvF2l/5OhEuaxnfMP Rs3M8/w37DXPPgQdMYgWY7xWL9ulvfgJmqh7UB2rORY8rz6C6JV8w09wruJEza89JQLa pvNowe1jQxRhzQfJduP9PhaTFjEES204IzfBzFsT2o6plZAPRI36YxYaJ+BDcT/MK2wv QI1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723168626; x=1723773426; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r231GslQSVbZ+GOnXC04E/yfa0+FwVvQveaHgqzV384=; b=YkICl4cpv8DHC1ercKfzZaKcqhVupEnGipW0+mwMVRCjaI/2i7KYbDqXJVgFccOyo7 SA42UxO2R3zilVoyKdbUqucgpcrv/PnPC8t6xtGNka3eZdC3VV3QLY6Ft9R7EnyyxBHJ 31gWrKFSwBlAqsJ2c7UM5R+/PQdUjxS1bPYM+lSi+iX82BfzfuRDt3hOQt8cA0SQvJhP 7pEi65Amoo+YgaMVkhwL+wLSLyVPZinGqMBzHQ4f8UW1ftcM4XSaQVbUooZBMv3KAIyq bKi1cjAKR197E74vP2AWB3n0Un2bvn8tfOC3RdLXxgAG9iwzpLYSF0NcTFnaTDiiujaE Z7Cg== X-Forwarded-Encrypted: i=1; AJvYcCVVn7RRhcuD6dCwGM+ajP0EW2VHV+dYsFrmasMHbufiHLed+C3y0iUWEyJWpUR6EGO2rbwbrojxVEGX1TBlHmiwQHY= X-Gm-Message-State: AOJu0Yw0F3EpRCeIMF0xyYnDdClVUlOQRmcWlU8Q/deGKPOgP279tLo8 oNKE+3AgoOjZbDiWsRsCzKZn2RBhbNwZ2+kkFFZl1o7jERVvfNN3 X-Google-Smtp-Source: AGHT+IFsXnoVru2zXzPqBvGcz6Q5PIOnYe1p2YXWbuYQS+0tZKmnsCbkidib+PZeD1jaaOhJVoh2Pg== X-Received: by 2002:a05:6a00:139f:b0:70b:cf1:8dc9 with SMTP id d2e1a72fcca58-710dcab6e5amr8210b3a.25.1723168625576; Thu, 08 Aug 2024 18:57:05 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710cb2e563csm1775535b3a.147.2024.08.08.18.57.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Aug 2024 18:57:05 -0700 (PDT) Message-ID: <839f2c4b-5312-447c-a3de-6c8fc098876e@gmail.com> Date: Fri, 9 Aug 2024 09:57:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/22] mm/zsmalloc: convert create_page_chain() and its users to use zpdesc To: Vishal Moola Cc: alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com References: <20240729112534.3416707-1-alexs@kernel.org> <20240729112534.3416707-7-alexs@kernel.org> <66ad2ef0.170a0220.8fae7.6e38@mx.google.com> <66b50d7f.170a0220.2171ed.8a4f@mx.google.com> Content-Language: en-US From: Alex Shi In-Reply-To: <66b50d7f.170a0220.2171ed.8a4f@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 126642002E X-Stat-Signature: 5tgu8ebkg8x93yeyxua9smqguykx7cis X-Rspam-User: X-HE-Tag: 1723168626-944118 X-HE-Meta: U2FsdGVkX19UpHOGZQTOf7O5KOFCy+mYTcxt+rgLXKtJHiGls1MFsWNaT+gqzPNnC9iWdfvfZjdBiDEsKtjnNg5uWy21CeS6g0zZot9GKFv1ewCea7IQhpHykdebiPGaaSS20XN5jDDWIrBsYqHnFoKaUmRTUao2zv1srndHJUDMMCzudyEVc5GW+Qufl2mlc9JxLbNP7g4LQL3MUNSG8MyLFtNdUdk7MPNmN62GK/bp8VkafqR04vrshxzoLF/ppvIzMar8afZnVsnha3CR/6SUpZKmAqnwIw87VfyKpeihNGmBjGigbeO3xMUFW2LoQjUZP6mp5Qc52Nc1Vqwcsw/t23cFgBgFI76atfyCfCMSmrwBMr6dFmI0Pjs327OaKIAHT9IB2GtAJxNH400FOySYro7Z7znprjhEaFqSGZig/wBbNaCybgr+i3rcTc+Bssnr73va2Vs/Z4LeU4l+RZrj0fNtr/SXJHhnlXU6JgJZZmJBk0EMHP/M+bT58CDjzihjg7EaZIATM8gJFciHPOT93WJlxU5j96FO1LXZQ6wcJbeSOuDCAqo3b+/43vasnKjecxy6ygHywbqOFAT8R4kFc5lkdSgswW6EX0+jHYvQ7/IHNANz5CfhdXhEtreBXXHvQFoqFvmgTObOXVFCAn+Bh443IW6X8gHSUceryD9qWDhBOqFffNWnaaqApXbQBPRJ1f9I0jVYQL4P1W4ZU806aharclNQgDBPgedIVTEcDp94EMsbD62fOyd6g+wksU3RFTT8q4YLvpvDOrR4Wg18to+Wq+3rUvbLMvdObQYjGFH4TkXoEupFkVp5TDpqWTxi91bFPXhh6QQKScDz23yU5ru/oE8XbA3HUlMiRN1s+jXQ9PcWjjZWgmdyMm13CPYbDtf7Exis34/3Gqclvo2J8+ue1ET41v2ntwWDINysX1E66Mcsk163IAxmsmiV2M6EBlA637nxBolXcJQ FfRnMUBG o+7a1d3CeORxMb1us1FFelItx4HsQcEQ2GVrdKfsXQMpFhGv0/oSuLfKHgyle3QCUmdJ63jxHuErpOAjsnZ1bBMEl9U5fvY05Hf/haVo2g3JUVvAr5NE+y4ga8S7PsmPUgEOcq9qX7YRf+52KFR+b2Hn2LZNq68+TypLtYj71eMS63dhrGcZuQ+DMjW4+KNxQ23RstRx6zUyOjFQfiOr2dtDpSR1lF4ow5EqEPbY74jn5UIvoXcaAoFtf524S8/P+8YReHEN5Re6svMj1nykobc7Iz13LTOoONatc4M2+xKKfUr61SYWLoJ5ohGxUR4sANKuaraF3V5hwaDfOoLRfPuo9Tz96Zh0TRUPdE09smxeMDFR2YBp7GYS0DO+McQJd4nuljNYZJ58iLRRO9WeICufCCcQnKwSroOPzIPLbyygnExFIduNwYJaiUsRCXHoYKSzC3UGyF72TVdn8hlZ5OJLjS6962NlgoUo4iHfqA9uwhB7cxVzNagqmaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/9/24 2:25 AM, Vishal Moola wrote: >>> I'm not a fan of the names above. IMO, naming should follow some >>> semblance of consistency regarding their purpose (or have comments >>> that describe their purpose instead). >>> >>> At a glance zpdesc_set_zspage() and zpdesc_set_first() sound like they >>> are doing similar things, but I don't think they serve similar purposes? >> zpdesc_set_zspage() only used in one place, a helper maynot needed. Let me remove it. >> Same thing for the alloc_zpdesc() and free_zpdesc(), they could be merge into using place. > alloc_zpdesc() and free_zpdesc() are fine as is. The helper functions > will be useful whenever memdescs can be allocated on their own, so its > better to introduce it now. Thanks for suggestion. will recover them in next version, maybe tomorrow if no more comments.