From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Olof Johansson <olof@lixom.net>, Andrew Morton <akpm@osdl.org>,
Christoph Lameter <clameter@sgi.com>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] Fix warning in mm/slub.c
Date: Tue, 23 Oct 2007 10:52:28 +0300 [thread overview]
Message-ID: <84144f020710230052t3dc7e402ka2d8ede6db81618a@mail.gmail.com> (raw)
In-Reply-To: <20071023143212.8D2E.Y-GOTO@jp.fujitsu.com>
Hi,
On 10/23/07, Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
> > "Make kmem_cache_node for SLUB on memory online to avoid panic" introduced
> > the following:
> >
> > mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from
> > incompatible pointer type
> >
> >
> > Signed-off-by: Olof Johansson <olof@lixom.net>
> >
> >
> > diff --git a/mm/slub.c b/mm/slub.c
> > index aac1dd3..bcdb2c8 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -2734,7 +2734,7 @@ static void slab_mem_offline_callback(void *arg)
> > * and offline_pages() function shoudn't call this
> > * callback. So, we must fail.
> > */
> > - BUG_ON(atomic_read(&n->nr_slabs));
> > + BUG_ON(atomic_long_read(&n->nr_slabs));
> >
> > s->node[offline_node] = NULL;
> > kmem_cache_free(kmalloc_caches, n);
>
>
> Oops, yes. Thanks.
>
> Acked-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-10-23 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 3:25 [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3) Yasunori Goto
2007-10-18 3:46 ` Andrew Morton
2007-10-18 6:25 ` Christoph Lameter
2007-10-18 7:00 ` Andrew Morton
2007-10-18 8:33 ` Yasunori Goto
2007-10-18 9:13 ` Christoph Lameter
2007-10-18 9:20 ` Yasunori Goto
2007-10-23 4:21 ` [PATCH] Fix warning in mm/slub.c Olof Johansson
2007-10-23 5:35 ` Yasunori Goto
2007-10-23 7:52 ` Pekka Enberg [this message]
2007-10-23 16:21 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020710230052t3dc7e402ka2d8ede6db81618a@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=olof@lixom.net \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).