From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by wr-out-0506.google.com with SMTP id c37so217639wra.26 for ; Tue, 29 Apr 2008 12:29:03 -0700 (PDT) Message-ID: <84144f020804291229t55d207afk97457f14175ebe18@mail.gmail.com> Date: Tue, 29 Apr 2008 22:29:01 +0300 From: "Pekka Enberg" Subject: Re: [2/2] vmallocinfo: Add caller information In-Reply-To: <84144f020804291223x6e40509fk8461ed4d96d443b@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080318222701.788442216@sgi.com> <20080318222827.519656153@sgi.com> <20080429084854.GA14913@elte.hu> <20080428124849.4959c419@infradead.org> <20080428140026.32aaf3bf@infradead.org> <84144f020804291223x6e40509fk8461ed4d96d443b@mail.gmail.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Arjan van de Ven , Ingo Molnar , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Linus Torvalds , Peter Zijlstra List-ID: On Tue, Apr 29, 2008 at 10:09 PM, Christoph Lameter wrote: > > Well so we display out of whack backtraces? There are also issues on > > platforms that do not have a stack in the classic sense (rotating register > > file on IA64 and Sparc64 f.e.). Determining a backtrace can be very > > expensive. On Tue, Apr 29, 2008 at 10:23 PM, Pekka Enberg wrote: > I think that's the key question here whether we need to enable this on > production systems? If yes, why? If it's just a debugging aid, then I > see Ingo's point of save_stack_trace(); otherwise the low-overhead > __builtin_return_address() makes more sense. Actually, this is vmalloc() so why do we even care? If there are callers in the tree that use vmalloc() for performance sensitive stuff, they ought to be converted to kmalloc() anyway, no? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org