linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Matt Mackall <mpm@selenic.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-crypto@vger.kernel.org, Geert.Uytterhoeven@sonycom.com
Subject: Re: [PATCH] Export symbol ksize()
Date: Tue, 17 Feb 2009 19:03:28 +0200	[thread overview]
Message-ID: <84144f020902170903g5756cf4cy57f98cd5955ff2e3@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0902171115010.29986@qirst.com>

On Tue, Feb 17, 2009 at 6:17 PM, Christoph Lameter
<cl@linux-foundation.org> wrote:
> On Sun, 15 Feb 2009, Matt Mackall wrote:
>
>> And it -is- a category error. The fact that kmalloc is implemented on
>> top of kmem_cache_alloc is an implementation detail that callers should
>> not assume. They shouldn't call kfree() on kmem_cache_alloc objects
>> (even though it might just happen to work), nor should they call
>> ksize().
>
> ksize does not take a kmem_cache pointer and it is mainly used for
> figuring out how much space kmalloc really allocated for an object. As
> such its more part of the kmalloc/kfree set of calls than the
> kmem_cache_* calls.
>
> We could add another call
>
>        kmem_cache_size()
>
> for symmetries sake.

Hmm, kmem_cache_size() seems bit pointless to me. For
kmem_cache_create()'d caches, actual allocated size should be more or
less optimal with no extra space.

                                     Pekka

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-02-17 17:03 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-10 13:21 [PATCH] Export symbol ksize() Kirill A. Shutemov
2009-02-10 13:35 ` Pekka Enberg
2009-02-10 13:46   ` Kirill A. Shutemov
2009-02-10 14:06     ` Pekka J Enberg
2009-02-12 10:43       ` Herbert Xu
2009-02-12 10:45         ` Pekka Enberg
2009-02-12 10:50           ` Herbert Xu
2009-02-12 13:10             ` Nick Piggin
2009-02-12 23:09               ` Herbert Xu
2009-02-12 23:37                 ` Matt Mackall
2009-02-13 13:20                   ` Nick Piggin
2009-02-13 16:57                     ` Kyle Moffett
2009-02-12 15:55             ` Pekka Enberg
2009-02-12 23:09               ` Herbert Xu
2009-02-15 21:36               ` Andrew Morton
2009-02-15 21:43                 ` Matt Mackall
2009-02-15 21:55                   ` Andrew Morton
2009-02-15 23:49                     ` Matt Mackall
2009-02-16  1:00                       ` Andrew Morton
2009-02-16  1:21                         ` Herbert Xu
2009-02-16  1:28                           ` Matt Mackall
2009-02-16  1:52                             ` Herbert Xu
2009-02-16  1:54                               ` Matt Mackall
2009-02-16  1:57                                 ` Herbert Xu
2009-02-16  1:38                         ` Matt Mackall
2009-02-17  8:43                           ` Geert Uytterhoeven
2009-02-17 16:17                       ` Christoph Lameter
2009-02-17 17:03                         ` Pekka Enberg [this message]
2009-02-17 17:06                           ` Christoph Lameter
2009-02-16 13:56       ` Johannes Weiner
2009-02-16 14:09         ` Pekka Enberg
2009-02-16 16:32         ` Joe Perches
2009-02-16 17:29           ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f020902170903g5756cf4cy57f98cd5955ff2e3@mail.gmail.com \
    --to=penberg@cs.helsinki.fi \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kirill@shutemov.name \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).