From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 726C26B014A for ; Mon, 21 Sep 2009 08:01:04 -0400 (EDT) Received: by fxm2 with SMTP id 2so2081955fxm.4 for ; Mon, 21 Sep 2009 05:01:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1253227412-24342-1-git-send-email-ngupta@vflare.org> <1253260528.4959.13.camel@penberg-laptop> <1253266391.4959.15.camel@penberg-laptop> <4AB3A16B.90009@vflare.org> <4AB487FD.5060207@cs.helsinki.fi> <1253531550.5216.32.camel@penberg-laptop> Date: Mon, 21 Sep 2009 15:01:02 +0300 Message-ID: <84144f020909210501l4a216205q85523a06f4589f2a@mail.gmail.com> Subject: Re: [PATCH 2/4] send callback when swap slot is freed From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: ngupta@vflare.org, Greg KH , Andrew Morton , Ed Tomlinson , linux-kernel , linux-mm , linux-mm-cc , kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp List-ID: On Mon, Sep 21, 2009 at 2:55 PM, Hugh Dickins wrote: >> The callback setup from ->read() just looks gross. However, it's your >> call Hugh so I'll just shut up now. ;-) > > Ah, no, please don't! =A0So it's _that_ end of it that's upsetting you, > and rightly so, I hadn't grasped that. Heh, right. :-) On Mon, Sep 21, 2009 at 2:55 PM, Hugh Dickins wrote: > (Nitin, your patch division is quite wrong: you should present a patch > in which your driver works, albeit poorly, without the notifier; then > a patch in which the notifier is added at the swapfile.c end and your > driver end, so we can see how they fit together.) Yes, please. Such standalone driver could go into drivers/staging for 2.6.32 probably. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org