From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F84C71136 for ; Wed, 11 Jun 2025 17:34:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D48826B009B; Wed, 11 Jun 2025 13:34:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF93E6B009C; Wed, 11 Jun 2025 13:34:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B996A6B009D; Wed, 11 Jun 2025 13:34:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9F4EA6B009B for ; Wed, 11 Jun 2025 13:34:32 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4B5AB161214 for ; Wed, 11 Jun 2025 17:34:32 +0000 (UTC) X-FDA: 83543819184.16.8957EA9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 9C91AA0011 for ; Wed, 11 Jun 2025 17:34:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bSSR56xN; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749663269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R7YsxVJztmysrLyvbSWIo+skTpFG03CTqrgB8glmUP4=; b=cn2orRbv01ev5QO2ALvg+5qKobU+YkFMLW4ig3ri/4pKQm18S80NTySJbrr1SqDZz5FUUX 5bn2xN5pdxi0x708INvj1HWQuNFQh0VsXrPs8SmQ7Xn+ZxtyXLMpO7obmHeywiwOsSkgLh Ve2PZI+D0fcBSqfu/F8StAH8jgrap4o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bSSR56xN; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749663269; a=rsa-sha256; cv=none; b=nbJ2DWP7P7l2HMfbUZEzbmuqlM/Hvsd7KRpe64v0BYIouhdM5UCvx20I53lOtXN8pbblMi aPhZRuHxXsyITN9SQBA0qQgQKkXLB9dtVBri+lOVlrcidzzusN0pfRdDSCAJh3acjl+NMM iWtierJPCKUo+nAZZv+oCL//kK++utc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749663269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=R7YsxVJztmysrLyvbSWIo+skTpFG03CTqrgB8glmUP4=; b=bSSR56xNx7sTtn+zghEZKwc0ZKSep6wWlzNOaA0l9kNVoO7Ayuywfku3mSfe2eedMotZt7 3htTcogUd+PO77GjWPoxlyEnT0pGFKUpR4EmIGZ44xErn9MwSbR7ReEq25PUpeUMK2IfPR 67pjzYQTXi/IpCi/KeBj5Z9v6n3PKO4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-372-7e_QHldpOtOYticp8rpX3w-1; Wed, 11 Jun 2025 13:34:25 -0400 X-MC-Unique: 7e_QHldpOtOYticp8rpX3w-1 X-Mimecast-MFC-AGG-ID: 7e_QHldpOtOYticp8rpX3w_1749663264 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-453080e4741so295955e9.0 for ; Wed, 11 Jun 2025 10:34:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749663264; x=1750268064; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=R7YsxVJztmysrLyvbSWIo+skTpFG03CTqrgB8glmUP4=; b=ILfzbvwaUFjQUd5+OjuOLuFEHk9MnSH+eXlbZqm6wptvrJ1kGjqFY2wa/WYjSOC/YR YvWdFzPXmCRoEDra/i+Qx9dukBzI82CGzyMTBtmNOepp34MrrwlkPYr72kJZjPjox298 gT3LA00gXMPDmVi5GsRIptbzFZMoJw/zSHy9yIgJQSm2w1qjR5YLFkom/ZJIJpeWhvHg F4kbNJ/I0miXZiJV2xEf2xkeC5Ri3K40j04fCNdTC0ZJ1VhlsJiGttT4QYntb4TucBg6 3hM2heHC5b7orhW5L7UoBFAJA4+2SUwgGv7ZuloSQUja66HQ/yuCWMVrpHpo9r3d4J4C VQ6g== X-Forwarded-Encrypted: i=1; AJvYcCU7D3nMPBbTuAdVjIbGzRvC7PKlff4Y3o/6+8OIoiHX/wHlFh+9QkZ6mx7v7TwvawhMKgJRvXN5AA==@kvack.org X-Gm-Message-State: AOJu0YzOPkomEd+3mO5D4j7Xv35jTDLRMCuyxPKb4pLO19pJhIPir8t1 JVxhLB0xBgcQQ0CezZiV7k0tt11/zwOy0rYlDckO7fF6wkGcUWyOhlw9uuoPr+a+HyY8Ezv9XOb VYN9NpPTbJOibzJcia5RfitbJxz2F3xIK4KRBrlAwzOannflljUHE X-Gm-Gg: ASbGnctAFGTJBLaSK8uYuE5jMIowO1iF4eZ0vvQSWkohoIg0oEwrVJ5fU83I1ZSbrU/ ZOvZs6gqLjuRv6g7RyAAxk3gAmcZM2vfwj8081segqLGDMEZcfg0vjN8xwFX6XsZ2rYAQ2WzyiA GtXldh2NGgv6i/RUTARiDQ7aVRUabOTGMPER8UHQdQh9QGe74gocDVjubX+hZMaYotNOZ1UXY8L FtxfJEC7Q587xeYzq1klwYgIxY4tly1W/dlmtKdCH2idijBv5MkYnFoh9dIRdR9Sb31cPP3Ust5 oBMxKqyW0R+yNgE03YyYxig52mqOV0o9CUJSs31Jzu/QTacNmaGFHuXYpLm9Z+WxHuaM36U9Kv8 sdK1vK4rE+0zC0TgiAaf+M0h3ZgfXcdxHU8AtZVFtax/dDvQ= X-Received: by 2002:a05:600c:3511:b0:441:b19c:96fe with SMTP id 5b1f17b1804b1-45324882d3amr46055575e9.10.1749663264147; Wed, 11 Jun 2025 10:34:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7tqD61dd901nwJLEz9eo6DPDhTHrqb4nV4OysGWxHjg3+HOq61D8B7pk7HD8l7XMfcotCaQ== X-Received: by 2002:a05:600c:3511:b0:441:b19c:96fe with SMTP id 5b1f17b1804b1-45324882d3amr46055275e9.10.1749663263671; Wed, 11 Jun 2025 10:34:23 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:a00:cfc6:8099:68d0:10b7? (p200300d82f380a00cfc6809968d010b7.dip0.t-ipconnect.de. [2003:d8:2f38:a00:cfc6:8099:68d0:10b7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532c0d919bsm2894555e9.3.2025.06.11.10.34.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jun 2025 10:34:23 -0700 (PDT) Message-ID: <849e1901-82d3-4ba3-81ac-060fa16ed91e@redhat.com> Date: Wed, 11 Jun 2025 19:34:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmscan: fix hwpoisoned large folio handling in shrink_folio_list To: Zi Yan Cc: Jinjiang Tu , akpm@linux-foundation.org, linmiaohe@huawei.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <20250611074643.250837-1-tujinjiang@huawei.com> <1f0c7d73-b7e2-4ee9-8050-f23c05e75e8b@redhat.com> <62e1f100-0e0e-40bc-9dc3-fcaf8f8d343f@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IDM1Absu9kxmbFan7he1YrWbK_Csm1Lyd-C23EZFdy8_1749663264 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9C91AA0011 X-Stat-Signature: 4hd6gfz16tgcxd4bt59ajyhntzjg86hh X-Rspam-User: X-HE-Tag: 1749663269-205701 X-HE-Meta: U2FsdGVkX18Q1iWO+yttVCCV1+S7FWDldLJZSoV8YbIZ+kJLnDgi2G16/m2GapaAsELVZYzGxtj/F4I2nsXf1orQmaPYQViBjayoWT7nZqw9S9FKIaNMV1Nlcco48owEmZJtTqfFph224rKzWR4jplkhww6pQ7t8ncelmGV8Vz8EA5NNXdzidP0FRG92AuigZ4Lcb/rGNaCiHzGur8d7jW204Y4Pb3fLrH4Lv7WcllsXO1qWaREycBEsO2dz/0e0D20DrriNn9DmMP91Az+ZGCY0kA9XOGSb61cti1p2TAGafqVPR8rmC6FYV+cTIpu30bD1KOOymThroZkJtgIdbaBnarRGtZS43KqSkmy6xmE3JfRWWvo+Am4ECLjU96mCFKe70yFgWXpRX16aKih3tQDlVztxOtsePa5R6hRz1gWm90BIt/TmUQ63+dvDGd6YWNcLc39qwBmUa0dRuRrF+efB6M6eHHIEfQh57mlQx33DKVccomfoKzPdzX7aPgX96KsmccszsfJ9dvQO7DTMwtXJRULCMx5wm/61G8372TOnOrwWjfKLK2z7amBlzr+2rYwQAvIJD2XWVAnBfdScg/WKZu33IFi3MTitIqWmYaHx2IsDXhGwsD5yatxTme+P/V79CcjrbAAL2podYPlZVpk5lUApoi9EvXfQ47cZlXvYzDt6AV7K8g4/t45TH3zlIMuNVlEoT75JfqHYWX5gwZYfoDaGKX1TT9DHDStQYe5XbaRUQP0JIAFcpskaUVnC6dQENZ9OBecL/3DBqafuAeCmuwpY4lhMF1r8+ZvCEn56BBJVi3G2jsLa3AeM3aYFl94gK5ydcn11ektGHeU/7GI67afZiQsSfidHZmcKpuiQVsBZ6v7/mX6hj6m+p4DjrCWPZvtxlGijOWvs+N5V1jYanzrSNge+4hzo8aP3CBEScLzJouI4cljy9XqKmGePo2R7imBooWAcmrUUTwI Qdm3qvJq TaE6OC2UhU4RuWU6y6Ok0yQ1PYNONZo0Nm0tMk79whKpSmvDCrs9teRJ9CZL/4r/jkru2pxE9jqX0xEg35zrehtT2rnWh0l+WjGQnGhvbFwL5KAhE6aDZQJyBK1G7dRgNxWHNvBawk3RX2VchjfBnOm+p9hotOgWzg511BmjvwOKcy1f/cTHcVxQ1qiSK7e9mG3+RYUjxWFv1IdDuwpeqO0WL+Qsot+eE2PP2aCYlgIXrzf38Zxl7zmACGtWg8RYKl+Wpmxyvb68gv28BWwYE+K5S1jOeRDJPNVKZ5rZmZC5KhVtqVVNlu7CXTQvNJH/EZurL0+NFPX77kCX9sApAtR68CN6vcJTczRJ+ecXEJZ0DI70nhPeTfI9JPR7ZGD/zF2tK8GPpHvdK6+yLVnzhYC4GklC0VqolbNtGPjpG/eGeOxQCXW0Srqnek61u0oWrvntn4hui4HM84sEJzW7pH2GTRB9PuJzwZeQsR8eIWgzsQqdWpOd4w8aF+gjItYOJbOT/y8mV0oFKGeCSu1v4WWVTpc/9pYJDx4PdTM958+kADovyqF0iK8wtK9Oh7xdOO6Uq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > So __folio_split() has an implicit rule that: > 1. if the given list is not NULL, the folio cannot be on LRU; > 2. if the given list is NULL, the folio is on LRU. > > And the rule is buried deeply in lru_add_split_folio(). > > Should we add some checks in __folio_split()? > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d3e66136e41a..8ce2734c9ca0 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3732,6 +3732,11 @@ static int __folio_split(struct folio *folio, unsigned int new_order, > VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); > VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); > > + if (list && folio_test_lru(folio)) > + return -EINVAL; > + if (!list && !folio_test_lru(folio)) > + return -EINVAL; > + I guess we currently don't run into that, because whenever a folio is otherwise isolated, there is an additional reference or a page table mapping, so it cannot get split either way (e.g., freezing the refcount fails). So maybe these checks would be too early and they should happen after we froze the refcount? -- Cheers, David / dhildenb