From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74340EB64DC for ; Fri, 21 Jul 2023 15:08:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEFB06B0072; Fri, 21 Jul 2023 11:08:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9FE26B0074; Fri, 21 Jul 2023 11:08:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A419D6B0075; Fri, 21 Jul 2023 11:08:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 92FF06B0072 for ; Fri, 21 Jul 2023 11:08:03 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3342DB12D5 for ; Fri, 21 Jul 2023 15:08:03 +0000 (UTC) X-FDA: 81035949246.13.1DE4FAA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 675D7800A0 for ; Fri, 21 Jul 2023 15:07:34 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NeF2q5Dk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689952054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2LT31EnQdwzSm3B5EwQJfjJehEaFosn84rDtB5FWxnI=; b=5eH8Ign0Rwm8BF4iqMAXvudYuMCpeCE1uN3DlBIDFFMj0T/faopQUKyU6cONaHg1Tau+M3 VzqzbNGqSsfFK0/IOXrgAEZE2iVHYzkuyF5qw0LDWh/Qc1MD/PcO7ZdJTXFlDHvMcuz2Tf oryFb98XTCOPjBiK3a9/A6HhZoatgEs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NeF2q5Dk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689952054; a=rsa-sha256; cv=none; b=ksA81nBnwkzFOWY0NMMgKTjO7SSl3iaKKfYNrIX6pNJuvWXkzUtSHpa0lR65mX0dbJd3AE E54Dg8vQrfyyttPxgfrRums57fsZZeR42BRYvJMn9w5YRxxocZxQPPKHIjt4rq1H3/nvur QCXcIm6hGCYrwm0H/HwDYMp98cOU8wE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689952053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2LT31EnQdwzSm3B5EwQJfjJehEaFosn84rDtB5FWxnI=; b=NeF2q5Dk8i5rFoVQkLEDStgFiYvgJ82I4vyKQGQcI8bWDj8UIr6piO4e1oAPj8RbVpeQ8j uEXRDEVpF2vchUqR2OXhD1+1gv2NNwhJVM/KOui09wDGAimv4lupVwcZpczunwmrKcGeFd Vo2h2c34AnjoG1MHu5+MZB49zbmzbZo= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-326-1dFCq7kgMAWHa7PLNV-7pg-1; Fri, 21 Jul 2023 11:07:32 -0400 X-MC-Unique: 1dFCq7kgMAWHa7PLNV-7pg-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-51bef8bb689so3788873a12.1 for ; Fri, 21 Jul 2023 08:07:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689952051; x=1690556851; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2LT31EnQdwzSm3B5EwQJfjJehEaFosn84rDtB5FWxnI=; b=KnKQkBvmc/x34HEt0/ZMTjxqkI4csELh6xq9x20bso04SPlquBwBGZ3JVDEEy0566V HyYrLb8BL4dNv/5pWN4F7wMLHQrp+GGzRM+0BUrGpybPwRS9JOtQuBhT7YiAETaVs5BM X8VVuN3frn/xYttSRC+sgb+ZcVEkIwtvsWcV8rTdHNjW52nMFmauyJuctLnFCauVmy79 9c40dlJp90QaJsb10VIeB9ibRt3vMHZkMaweUUY/tHKhhhq7OyjiORm3h9adPD8adiLd rjy8T6MbUzS8dLlMzqOMdgPym5QQFEXjMpsZCE6wB3RPTPHL99NCoyp7iQEuvmztgnGp 4ApA== X-Gm-Message-State: ABy/qLbZITQaLUmoFje0e4/5X3MI7rC6kjq1qIvGGgfcBY20RgtMjSo6 PfGmg1yMlCjQ9OEhoz9I+mrH2LL15Qlzf0XyOW6EqWaWvU/+7NZfm0Q/csmjMviwn+pGU86HWde v7Cw62Uw6q3I= X-Received: by 2002:a05:6402:3596:b0:521:ae30:787d with SMTP id y22-20020a056402359600b00521ae30787dmr8297780edc.21.1689952051249; Fri, 21 Jul 2023 08:07:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlEmyaXBPPcDeACqrampuhZk7coBp7sKkHctpw4dd03JKW9PMu58s3JgUnfUUPbC+bjZ7T2rgQ== X-Received: by 2002:a05:6402:3596:b0:521:ae30:787d with SMTP id y22-20020a056402359600b00521ae30787dmr8297753edc.21.1689952050947; Fri, 21 Jul 2023 08:07:30 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id w10-20020aa7d28a000000b00521f4ee396fsm127596edq.12.2023.07.21.08.07.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 08:07:30 -0700 (PDT) Message-ID: <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Date: Fri, 21 Jul 2023 17:07:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 13/29] KVM: Add transparent hugepage support for dedicated guest memory To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-14-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20230718234512.1690985-14-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: d3thsjqgw863nqzhmz14yk1x94acwoud X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 675D7800A0 X-HE-Tag: 1689952054-259037 X-HE-Meta: U2FsdGVkX1/Z+DA8T3s3vd0LQ4D9Q1J+rrtAr2TvrYh6OJ9zkWPOMDzwx7G+51sSVHl2hBDiut/KZN1vrszdt9V1ixEuf48YL5lhI1qhfJWx99uF1RU+n+9/z/tDyWyx5HD6Io/P8xPHDgpFAbQLmQAu2PJZhqsI7Aj+Qi8yUlyThXgQQZOMjDkBv6giyD8NHzBIvPJTCtXX+CRy+ICHIZZxx1DBNa8wXhdb2KdT0MoNgChQLnKyKJsbgDtHBgxeE3zW3oHHRybtEYk4J+MDw/xyA3zGcR0vNuLigrMc7vH7QdSxv3VdA7UEY9cFI2RjK4MGWgmIto3SuOCXiP3BFtCLWbv2MkqUMuP1I2kXFwMiZZ8mU2Nuob/DLiEVoNzA1rJ2D4eIeupTKNWhIcUVS2aPq1bM6l8hb7JM2IDiOkMTP/OZBLRBJYtXZFsKt80kcbx3GwYWAd38JJnC5RNU57jd5CNY0NSfHn5eJuScvZvPSbcu/QoY3OKMDn6wp21cgpaXQ72MmqiQhs/4gz9Lk4D1gE2bLhg6vRON/XU4GnS/5VAxF0cvNogeUUsGgXyIW6AIumwNyMCHi3JVVshjm3yZcCHqdhj7wa/nwahe9sNyjb89z0Uy96+wo/aB7tY4TjSDQghc40x1JpHKF+idMrdv/Zse9nJ+0tEERzKnkfbtsIr1jJumUgm9mvJpKABO76pvOUQWRdwlxbykOlfuO4wlxqdlJ+Ek9xfDILxUgb3lAwvhvWMhhbvBC7FT+jYlMAP2GgyRPlbZa/p1H9WVzoUH5q6YS1DJfn5T/Fi8JYkUdjmlo1Vd4dsoXlY3MKkVpmGQp5SAvzhmO+Aobn6T0L8e6ig7rPZtfUkDKV8ppczZ8AVhRTX8fZYluRArqoZ5GE5UPbIgoPjUG4rDXSI8IzCH1DDrfFx/kbaDkIG1UkR7GqmY3Jz/tc5CAUVjHHV558qFa9aXFeX5o0qKXYv be7QE1W/ szO1JBu26IYmLCq+9Wyp+e3j5oF+zQlTrm795sDLTa98L8hG1NSmtIBvn2s3hDbQWaioF135xzeKcg6p8vLd/AgZfqwMO0xHvPcjder+TZ9dJtDUITdbsJkNl+ZFMpS9gFg4reNFVu5OwH4HcD5Ve1cwgI3GnlFZsju98uMZyFmqOz6vF5WlbW1mh4L4ei68+I0tti906GL84EQaOeGhgL9cPJA/0FBRcB6Ot11BJ9eH7mI8pq/2Gk66JJBqs+IGs3LJEAeoRkiDNppD7rqnW/vclQ/h4sH07Avx1kXq0g0Xk8loSbkM4IuIAMJ8nw8ArAxbZCDBbPctE7Yk+sFI7YMtO9SU9tl80c6sueREt105sTQdS1JNnxfxGAmjOkNDLt1pIzFT+EOmhPTqS5SqH/pnKrnrafgTmRGJJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/19/23 01:44, Sean Christopherson wrote: > > @@ -413,6 +454,9 @@ int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) > u64 flags = args->flags; > u64 valid_flags = 0; > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > + valid_flags |= KVM_GUEST_MEMFD_ALLOW_HUGEPAGE; > + I think it should be always allowed. The outcome would just be "never have a hugepage" if thp is not enabled in the kernel. Paolo