From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D49C001DF for ; Thu, 3 Aug 2023 11:47:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF89C280239; Thu, 3 Aug 2023 07:47:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA90128022C; Thu, 3 Aug 2023 07:47:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4A21280239; Thu, 3 Aug 2023 07:47:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9185B28022C for ; Thu, 3 Aug 2023 07:47:43 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5F2A212111C for ; Thu, 3 Aug 2023 11:47:43 +0000 (UTC) X-FDA: 81082618806.10.91C2CE9 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf01.hostedemail.com (Postfix) with ESMTP id 442E84001A for ; Thu, 3 Aug 2023 11:47:40 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=csXKjk2u; spf=pass (imf01.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691063261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uCIhJJ2hQzGyb6KTmj3+r2054kWgm3yg50ej7a2QDQc=; b=t+NwrhedwUTMxxtrXBW7kptvuCTt0FPfo11Z7culjg/a7Gd5ntWbk3X8n6fZCKcWTMyanZ tEvvExlgCfPVYjMRrYejE/ybrQNKM8uMY1xi9IAhZ9y1DhtyyLEn2CLWw1j6ynUd9Y234k VmbDxbRaHELRmaQOIDYlRh+IFFuXu2M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691063261; a=rsa-sha256; cv=none; b=CImbK+Shr5qmvaixRkZr2Cn2AziSn3/c54MGOU9tKhWtLDfpZA6QkOjd3xRnGnwGOT93EC nnHRdRfjdjRmxnwfoVPAHbug03bMZwnLAzYDPyEkYkesXedD1b4op5so6IDne8rJlYDZvL 9GXqDC8PToYwuWogquOBRCxblm3clYE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=csXKjk2u; spf=pass (imf01.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-99c1c66876aso122644466b.2 for ; Thu, 03 Aug 2023 04:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691063259; x=1691668059; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uCIhJJ2hQzGyb6KTmj3+r2054kWgm3yg50ej7a2QDQc=; b=csXKjk2uhcfAg18dyTPk/RSzhNTWvubZIkepX1Mj3atVktKxOrnvv2YG36KoACoDNC cny9ht4allynSHcLQQ6ciTN8i8LPccQRSd11vfi8IHmkUB6to8/GFYqbVUp4B8Ak6kk6 twCtl4BfxAgLsPpRxML7vLOq0u7wGQzuMesOoc7Kx+VlkPtdnNMdWEewM9LKFaejDUVB 4qZbE64kk18Jcyh8H5Knp5wcFoOR8GkbVyVk2qu3wHkCP+ZE3A+CjAlP6einWWRpoDF+ k86qVzOyoRWv48h49pVjr+5EKlk4xNSxVuEAaYeNtq2jaV70WfIi8IZn2tQ9qZJH+M+H cQ9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691063259; x=1691668059; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uCIhJJ2hQzGyb6KTmj3+r2054kWgm3yg50ej7a2QDQc=; b=dkNiovM57mDkq1ZlGRZcW8gqHE/hUAePlZCR7hoYeyJQzAk9dT3d9ozfBpNxVlhcPz jfiYN0+bef4IVGL9zGyPJAJl6nwA61S7pg1oViFskd5NlLRKnYzRaMy/U4LFD/yISskL Na9QtdHgdoeDpwDp2dLWd4nME+W2RpXVj9TYYBFFpnopH3Oj2RkbWTTd1qId8Hk/FhQT OiSS7z8g1KQut0NUvlRMbrxLR6uMdB4OboQbqen7zBitAVxuI4cbqFtPGSwwHRBangDL ui5XrokuBWZqH8/K96hXlNK0cfTpA702iRovRCcJGb0v4MafYkQikvHwW/03iUgPwCiW C82w== X-Gm-Message-State: ABy/qLbYzG3GE/DjWf+FT9mnsLspxTs7Egwt39XR/nPsU6lTPAkzNbek VN0p1HlBKYWJrNvXnq+Pfws= X-Google-Smtp-Source: APBJJlEuLtlzLF7ZRSWqZTPsnYH5PMw8werL0IhJsaRD6sunTyQymk/YX8Sx+fiBHSP3tF/19IR7Yw== X-Received: by 2002:a17:906:8a58:b0:991:d5ad:f1b1 with SMTP id gx24-20020a1709068a5800b00991d5adf1b1mr7306166ejc.47.1691063259192; Thu, 03 Aug 2023 04:47:39 -0700 (PDT) Received: from [192.168.0.103] ([77.126.7.132]) by smtp.gmail.com with ESMTPSA id sb9-20020a170906edc900b00992ae4cf3c1sm10325742ejb.186.2023.08.03.04.47.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 04:47:38 -0700 (PDT) Message-ID: <852cef0c-2c1a-fdcd-4ee9-4a0bca3f54c5@gmail.com> Date: Thu, 3 Aug 2023 14:47:35 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() To: Jakub Kicinski Cc: David Howells , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> <2267272.1686150217@warthog.procyon.org.uk> <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> <776549.1687167344@warthog.procyon.org.uk> <7337a904-231d-201d-397a-7bbe7cae929f@gmail.com> <20230630102143.7deffc30@kernel.org> <20230705091914.5bee12f8@kernel.org> <20230725173036.442ba8ba@kernel.org> Content-Language: en-US From: Tariq Toukan In-Reply-To: <20230725173036.442ba8ba@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 442E84001A X-Rspam-User: X-Stat-Signature: ts688fhta9daiomn4i14in4mk7oey1du X-Rspamd-Server: rspam03 X-HE-Tag: 1691063260-612244 X-HE-Meta: U2FsdGVkX18Uqmgvl8fN4iCAPEqhmHp8kVNPRtAfa4PGTdKsPjbkYNJKo45OKE7xh/jTGaSar/fBcHT4G0ES62SBri3o2KfvZ7RXVpRObrJFV4NOWwc7thHNqwJxnFHbBU4X6I5zl+bV5XMWx6LMVVRbBXBZAXeF9nv9S28nMRas8YvJzS1umONR6eMsj6oM6drPIrDORY/+EKY7qo7IFMNqrGZhmSVg9zZ1a++CBibnUVT3qwcuOn/jESgJgSEph1lPA2Odvi9hNYFuK/Q9BitNWdUczkWnX4/Jt/HTFZVf/eb4i/cq760NdKZVuX6TjKrPeIDwIAEmJzGj2+Ud2OM4zTHQ/mu3Q4YldmqfoNMlESoz1juKhBg39R93C54BDOm9lXjYKBkF3/4usuXFuNdtD4TOCjkDfiOL+BjyxLhRUmWl8TJYzQht23i+1ZUVh16H6b8WPTEsq0RTMTVIIhiXkzEu6qBvZWsz1liytB1UhM0DT9b3UC1xESkDpIXVlDOxD85aEJ9o+AIzzO+mduQp0zGhQkZjS9cydrNxP+NqyFgWLPEgsVBc4yKFElCcRwEuOs4tFH7VPHVcFP48+1sqbz3m3ASGIZUPLSx1A9ruS2QkjFC1LNw18blvNoOZLXBdyLVFw4No4FFWJyXlcTgF/lXKb3gwZkhjX59bwSOaueQSJY4e02IBBi5m13NS42tGteHGS+RnZbI+Dmzd4qpVGGuo/9h7xdaoSCYsB1jLQDgKgQK5+ksDt3/bUOmkTRm8OscBQAVvINOZby7NBFzbPRsGP2YxIC6bKUu2lsc5ktbF4VVe8zGV8sWxuYQ+SGWeaGtovzR31dqZIUU4OrPIim2zDy+IzO0GeYLesGArhxBGGlTnhKos0ptUngR41cHJUUyGeE/W7qypVXVsUXlAMLQuRre2roDRb+m5Y2Z3rOWLifq3tIY63E8gfZPx9fY3TmrDwUemE/Zx8MZ dKSSJ0oX barQLIzsAqi6ltgwjd7EjFE4HdAJESntdZoKIDQIztesXP/x2OePPlXV03YRM5qJp88gPKCw4apA1u/xKp6lgooXeUxYyfticYg28Igx4o3eRjiSDDgTtuQ3Vg0Rh6GHAu8GwTXPq+zv3y1udci7nT1K55BGm5UnGnEsea3Na6UaBEArxScB3k7zPXLMkh68Arfzv8+7nCn+pAyUUCw9N4lhh/mHD3JQKW3stSenfVYjWAyE6ltWNGMGFQR+aaPny6yLq6GhpA+WCkE54u8hR5PpvcGcDz/NcXty747h4v2Jd7zNCuzjCywmnqtyxH4VsJrpHumVDnr/ZW+TFbycESVxRAr4X+JTPQMNNQpVN5gjiSKF/+kZ6sZiMzwP7lLwuXk0dP6MnpQiadcBH0gwLbfGPyTPRV6cxCZgk1yykyiH2wctN9zxeC0VdDGGab6HxcaYIJC+f2IUcnZfnVtM5plxf7K6E09PFyggmL5rFeQt5PcFsP1bduXpa4sB/OGkMc2J8VujlxztG+KeJfIXHGX9ljPVKl3QJE05BKfdJwr+15EDEEYpNcPj+wmDV2GzI6/r0xyHx8nDn1JheJMjudmDJxT+puHKOAIduNiYljhDaI/46DdAYjHS8Ms7NpzGGcsD+1XkoaNwvgNPRg6gMzHv38qy7TMA8SqclEOTW631sB4cSy1A1hKyUl1FGw+dLRbcYPUefQUGmsrVgYv34kavA52TKhAisi4komlIuU7N00ztilmIPOzcp9xrxAmbDdCj0W16dWI1DwwpdMGxv4Ru2dh/lD8d+pYHU2zCTs4U+myRSl6wRD7lEpLQTW1MHcdZ9rgFdTQcacUQOFodp00KY2it2rF1s1DtyUzjjYL+Ya0M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26/07/2023 3:30, Jakub Kicinski wrote: > On Sun, 23 Jul 2023 09:35:56 +0300 Tariq Toukan wrote: >> Hi Jakub, David, >> >> We repro the issue on the server side using this client command: >> $ wrk -b2.2.2.2 -t4 -c1000 -d5 --timeout 5s >> https://2.2.2.3:20443/256000b.img >> >> Port 20443 is configured with: >> ssl_ciphers ECDHE-RSA-AES128-GCM-SHA256; >> sendfile off; >> >> >> Important: >> 1. Couldn't repro with files smaller than 40KB. >> 2. Couldn't repro with "sendfile on;" >> >> In addition, we collected the vmcore (forced by panic_on_warn), it can >> be downloaded from here: >> https://drive.google.com/file/d/1Fi2dzgq6k2hb2L_kwyntRjfLF6_RmbxB/view?usp=sharing > > This has no symbols :( > > There is a small bug in this commit, we should always set SPLICE. > But I don't see how that'd cause the warning you're seeing. > Does your build have CONFIG_DEBUG_VM enabled? > > -->8------------------------- > > From: Jakub Kicinski > Date: Tue, 25 Jul 2023 17:03:25 -0700 > Subject: net: tls: set MSG_SPLICE_PAGES consistently > > We used to change the flags for the last segment, because > non-last segments had the MSG_SENDPAGE_NOTLAST flag set. > That flag is no longer a thing so remove the setting. > > Since flags most likely don't have MSG_SPLICE_PAGES set > this avoids passing parts of the sg as splice and parts > as non-splice. > > ... tags ... > Signed-off-by: Jakub Kicinski > --- > net/tls/tls_main.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c > index b6896126bb92..4a8ee2f6badb 100644 > --- a/net/tls/tls_main.c > +++ b/net/tls/tls_main.c > @@ -139,9 +139,6 @@ int tls_push_sg(struct sock *sk, > > ctx->splicing_pages = true; > while (1) { > - if (sg_is_last(sg)) > - msg.msg_flags = flags; > - > /* is sending application-limited? */ > tcp_rate_check_app_limited(sk); > p = sg_page(sg); Hi Jakub, When applying this patch, repro disappears! :) Apparently it is related to the warning. Please go on and submit it. Tested-by: Tariq Toukan We are going to run more comprehensive tests, I'll let you know if we find anything unusual. Regards, Tariq