From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF8CECAAA1 for ; Thu, 27 Oct 2022 12:40:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 036618E0002; Thu, 27 Oct 2022 08:40:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F01668E0001; Thu, 27 Oct 2022 08:40:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC8828E0002; Thu, 27 Oct 2022 08:40:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C92678E0001 for ; Thu, 27 Oct 2022 08:40:16 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9144C804FF for ; Thu, 27 Oct 2022 12:40:16 +0000 (UTC) X-FDA: 80066687232.05.3CA15D4 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf08.hostedemail.com (Postfix) with ESMTP id 0E7BA16000F for ; Thu, 27 Oct 2022 12:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666874416; x=1698410416; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=gCO0Gi7jBp04JaT6Hozi8Zx3cpn252rR5ReZxqs5hCY=; b=d1tlF0HHQRdbrqtHB/cDlG/MbShzneOB/jvWJ9bWp16w9RQ4sur4HrHk BWSq/SlosZUbZ1KyLhYGg9xoM/bzzCbzmAELU7vvlwHqMVagfR6Hy6fpG SOT/EgqFam8fjG5TtF2KqILSZ7AhQu6q7N6cJ1KhHt3fkFDUngAzUbi2A dxRnjk8vhN7VmOZ8nnOzxapDq/AJUeq8xflMpHbyedHVshQvclzxRYlEf 0yHPmjBiJQxCKUKVjHKy9Od+VWBQMkldkhWF3EJ9M2bt/2VPkL4m5z053 JoO4iVtWWOWMYeQrBhj70FEsxfWVcLmJi1VLvBT145T1BPgSsknQr0UdJ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="295619994" X-IronPort-AV: E=Sophos;i="5.95,217,1661842800"; d="scan'208";a="295619994" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 05:40:14 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="632392902" X-IronPort-AV: E=Sophos;i="5.95,217,1661842800"; d="scan'208";a="632392902" Received: from akleen-mobl1.amr.corp.intel.com (HELO [10.251.5.115]) ([10.251.5.115]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 05:40:14 -0700 Message-ID: <85531c8e-e708-c76a-2d66-30ad7a3f8471@linux.intel.com> Date: Thu, 27 Oct 2022 05:40:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v6 16/21] x86/virt/tdx: Reserve TDX module global KeyID Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, dave.hansen@intel.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, peterz@infradead.org, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <7558961d3dff6311c7872f57ac5bd6727f21e140.1666824663.git.kai.huang@intel.com> From: Andi Kleen In-Reply-To: <7558961d3dff6311c7872f57ac5bd6727f21e140.1666824663.git.kai.huang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666874416; a=rsa-sha256; cv=none; b=2EPLQrgEyliLwpA9/z4cweNvoW3NSdwr4PBnG7ObZrK8mA+8CjdgREZyEq6IqbRrkdAC+X G/rD6f5+Jgk9Gnsfy09O7o5cJ65ou8l6ShfM6WZu/HGdW7CyKNcUYz/TyTi74RKlVNKa2g yLesSGzwuZn/AqcADNOmWo5ICUpH6Wc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=d1tlF0HH; spf=none (imf08.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=ak@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666874416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0A4q2+JdNF/VknFCXI3cKZz0aol5T2d82ZJ18HJKyno=; b=69CMFpgsGjpW8BFj9uVWQX1i/eirGoOlMJ5F/5FWpc0X4TajVDSOIfYTsTgEPhcdt9W2pu mVcqD8r+dAeTaUMiJDhkss6auTkmYfZ/sr5B6BqF8Bt2OemqTvf+RhJzBVz0bYfmUTSOOH A5i99Tmy7Rh71LPkMUEDoKLB7vQPiDU= X-Rspam-User: X-Rspamd-Queue-Id: 0E7BA16000F Authentication-Results: imf08.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=d1tlF0HH; spf=none (imf08.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=ak@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) X-Stat-Signature: d1tmikejfwh6w6ueznhnecsrhpzfiftg X-Rspamd-Server: rspam03 X-HE-Tag: 1666874415-603446 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/26/2022 4:16 PM, Kai Huang wrote: > TDX module initialization requires to use one TDX private KeyID as the > global KeyID to protect the TDX module metadata. The global KeyID is > configured to the TDX module along with TDMRs. > > Just reserve the first TDX private KeyID as the global KeyID. Keep the > global KeyID as a static variable as KVM will need to use it too. > > Reviewed-by: Isaku Yamahata > Signed-off-by: Kai Huang > --- > arch/x86/virt/vmx/tdx/tdx.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c > index 5d74ada072ca..0820ba781f97 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.c > +++ b/arch/x86/virt/vmx/tdx/tdx.c > @@ -62,6 +62,9 @@ static struct tdsysinfo_struct tdx_sysinfo; > static struct cmr_info tdx_cmr_array[MAX_CMRS] __aligned(CMR_INFO_ARRAY_ALIGNMENT); > static int tdx_cmr_num; > > +/* TDX module global KeyID. Used in TDH.SYS.CONFIG ABI. */ > +static u32 tdx_global_keyid; Comment how this is serialized (or doesn't need it)