From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C1AC43331 for ; Mon, 30 Mar 2020 12:28:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D5ABA20716 for ; Mon, 30 Mar 2020 12:28:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5ABA20716 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2C5FC8E0001; Mon, 30 Mar 2020 08:28:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 276156B0037; Mon, 30 Mar 2020 08:28:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18DB78E0001; Mon, 30 Mar 2020 08:28:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F1FD86B0032 for ; Mon, 30 Mar 2020 08:28:50 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C027A181AD0A3 for ; Mon, 30 Mar 2020 12:28:50 +0000 (UTC) X-FDA: 76651957620.19.slip24_3013f52edcd62 X-HE-Tag: slip24_3013f52edcd62 X-Filterd-Recvd-Size: 2237 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Mar 2020 12:28:50 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7515C30E; Mon, 30 Mar 2020 05:28:49 -0700 (PDT) Received: from [10.163.1.70] (unknown [10.163.1.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 914AA3F68F; Mon, 30 Mar 2020 05:28:46 -0700 (PDT) Subject: Re: [RFC] mm/page_alloc: Enumerate bad page reasons To: David Hildenbrand , linux-mm@kvack.org Cc: Andrew Morton , Michal Hocko , Dan Williams , Pavel Tatashin , linux-kernel@vger.kernel.org References: <1585551097-27283-1-git-send-email-anshuman.khandual@arm.com> From: Anshuman Khandual Message-ID: <8601ad7b-30dc-14db-48e3-2ceb1f52400f@arm.com> Date: Mon, 30 Mar 2020 17:58:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/30/2020 02:15 PM, David Hildenbrand wrote: > On 30.03.20 08:51, Anshuman Khandual wrote: >> Enumerate all existing bad page reasons which can be used in bad_page() for >> reporting via __dump_page(). Unfortunately __dump_page() cannot be changed. >> __dump_page() is called from dump_page() that accepts a raw string and is >> also an exported symbol that is currently being used from various generic >> memory functions and other drivers. This reduces code duplication while >> reporting bad pages. > > Yeah sounds nice, but "56 insertions(+), 20 deletions(-)" does not sound > so nice ... and the "code duplication" is actually "repeating strings". But repeating strings in very similar functions dealing with bad page state is not bit suboptimal ? > > ... I don't think we want/need this. >