From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19D46C25B7E for ; Wed, 29 May 2024 15:50:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8780C6B009F; Wed, 29 May 2024 11:50:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8273D6B00A0; Wed, 29 May 2024 11:50:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C8576B00A1; Wed, 29 May 2024 11:50:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4E58F6B009F for ; Wed, 29 May 2024 11:50:52 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 08A60402D0 for ; Wed, 29 May 2024 15:50:52 +0000 (UTC) X-FDA: 82171871544.06.E645923 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 1F3F51C0026 for ; Wed, 29 May 2024 15:50:49 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qWw6eJ+Y; spf=pass (imf20.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716997850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JfMMA2dXJI3fMUMXzNQfiu6b8KQ0HlqNxCZYyq7d1nI=; b=tk+v8H9BnDtnFJ5jEfnTv95W9ckgU5vg1JORRP04W2/5u1qTMncrmW9jnl7kOSlYT8ZxeY gzV2dbqYWDS/yVF4vrbgdY3lhOmQeRm98aOycgRXO/wTW31cFYOR4hkyWpzuVHRUY+xt7m S8Ooiz8ILBDD66vaxOD3GUKYGKPTHzo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qWw6eJ+Y; spf=pass (imf20.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716997850; a=rsa-sha256; cv=none; b=XCPYOXFT2k/rga7SOyNDQb2x4EKZA5/TNZQ/lz9YtZv8NVTDELHW6m0oG4x1rXTAxKJle/ UjTWlKcn+EPOA1UwuhMyj7PWgNYlUhIn8Qw5X2d9ol9X/zVUqP88oTBtdW86PEmQTR42fK 1IyPas8MMdgtuI/pI20qP01y+UtC1KI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4DD51608CC; Wed, 29 May 2024 15:50:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEF38C113CC; Wed, 29 May 2024 15:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716997849; bh=M6v4So8qJJ9yRxrCHyNBpJWbsn6zaiePqJdDikIffcg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qWw6eJ+YExFmA+CUVsPa5hU36SjXwo7pr3BiEUL9LJ+67Mqr4Hrd8Lb5wuOzXl0Fm nI3vNanpRAlmhPs6BppfD9kAAZhjDwpCigABTY5SaKmAqOylHLpQzBfCguH/o4b8S8 YPV9miKGauAOMN9X1G4xOo46q/Yzw93gtZT+WAmAezRXD1RlgfpLkSSoyDFSnU61ty 6aPxG74jhZyUFRj1HhBkmlehlAaxUnrTlDpxqIF4h0eKjAxsv6z1r7TvK+b5uIX2fS dedMJ7ZJ0jZ4xFgolUqJUwJkCxgxaJwwNZMeATlivPYwbanZDUFYha2eT0G73m5Tr0 nRv3RlWSK8qhg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCLZe-00GfsI-V4; Wed, 29 May 2024 16:50:47 +0100 Date: Wed, 29 May 2024 16:50:46 +0100 Message-ID: <861q5kmxbd.wl-maz@kernel.org> From: Marc Zyngier To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 09/29] KVM: arm64: use `at s1e1a` for POE In-Reply-To: <20240503130147.1154804-10-joey.gouly@arm.com> References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-10-joey.gouly@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: joey.gouly@arm.com, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Stat-Signature: hizijp46x4qx95rs57u41u5s53rhwx8b X-Rspamd-Queue-Id: 1F3F51C0026 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1716997849-293330 X-HE-Meta: U2FsdGVkX19RWuANXsqxcJLaWx5t8PQctClw9uXzOudi2B86YZ0mQKmyoZ/8I5f6k6gadiIRu2qyhbZeMxgUfnP07yaR+rjuItG5azNe50UCd5pdTSM+U+GdeDQ8/z8iW9GuyU64+4Sbk3/sr6PZrVm4+nqQR2TD2LKJHRPjlF9QiPUSWsj9kEbo636jpxMXUxm1pAxKrCaVU4QAljh01Vf/j1Jv4BcCe1Qp7qXeRrC1kli3ZkZv+i0n6qDwRTjW7sBVuGuGxn5p/92Q+A1i3KsAvS1FC6Gnfie85wrvY7DhOBb13t633jCh4FjMXofu4Vopw4P1RIQ8IDLuH7NuWtl11xmn1EX3SdCEnotih6OUFqzLdPIPpKaFwyEnYHEV7UnJ7xmAMXrmnrXYzbbziBuK14M2vj4v5x6dRzumm3liFCU50vAI+WulLRj+sVP5VdGcZBcuHbgM/EZa9jZI7iaH7HxJCn4NrupNLxjiur0AT1psyMYqzrhqKvyY7whwMWorabKM+BTMdu0gU+nYW4ayHvn2UIIj6Clku4xtXFrjnEsSsBVFkxxjRMsP68Y9TCk435KwDfOnrF/JBC6EvBqmpK8v7q5A1WQkh1OV5eywMcuVHxCPhoXSVyraV3IM0bIRmKCiaSvNZXAjcDwBpMy3dbATHZoWWoLyH6vpEYifvYhYtxUA1sKYedyG0uVKTkGjgtZcGvukVnvu45JQUT7LFhMkWdbvi9KH+DR+cguIN0VkWDpP/jYGfC9K85UWL+FTAZ4HnVO7oBNbbhCYvPJ8CtUko2BDGqXfl0L+s+OMcYpfbs19jLF+aG5x5Bqdn6q5jaoduGczE7t2HVHKZ1q469YJeeUkyCQK3i+ltSm1m+Ab8DphqOManaXvYBOIN7NtKK8g1GrxRmMm95S7FhovjLjG9NjiX+6K6lFGcAlDdwSGHeqZbSX9/y2UNc6gDXRjORRn4c6P1lM7pWE lktw3i2a nMg7mNAWf04fBjuSwYxTZKVj9Acf+26nKClabnnF1aIbH2wQMht+3n6ygbgswLNEbIb8YytqyygP86s8YCy6acueESHcBnIQKnQHUzVOUvcE4KlVaeGzMGMuFGFOeejKlrBDw0g8eXsNhBQgqhuAj9ucvQmzCErarZwBx5dffInixeBxbHtW+U0R14TqJ6L85EU6JjJzgtTDlhdG04ie/ngN0FsJ5+1ZGq7WRd4VDvYkpsosxN1TiWHYprz/5M6uNsJ/H92+CL9ijSYvbzsoAty50NXgiqxRwP+3vWHRN6ttMVS410fczpwthfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 03 May 2024 14:01:27 +0100, Joey Gouly wrote: > > FEAT_ATS1E1A introduces a new instruction: `at s1e1a`. > This is an address translation, without permission checks. > > POE allows read permissions to be removed from S1 by the guest. This means > that an `at` instruction could fail, and not get the IPA. > > Switch to using `at s1e1a` so that KVM can get the IPA regardless of S1 > permissions. > > Signed-off-by: Joey Gouly > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/kvm/hyp/include/hyp/fault.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/include/hyp/fault.h b/arch/arm64/kvm/hyp/include/hyp/fault.h > index 487c06099d6f..17df94570f03 100644 > --- a/arch/arm64/kvm/hyp/include/hyp/fault.h > +++ b/arch/arm64/kvm/hyp/include/hyp/fault.h > @@ -14,6 +14,7 @@ > > static inline bool __translate_far_to_hpfar(u64 far, u64 *hpfar) > { > + int ret; > u64 par, tmp; > > /* > @@ -27,7 +28,9 @@ static inline bool __translate_far_to_hpfar(u64 far, u64 *hpfar) > * saved the guest context yet, and we may return early... > */ > par = read_sysreg_par(); > - if (!__kvm_at(OP_AT_S1E1R, far)) > + ret = system_supports_poe() ? __kvm_at(OP_AT_S1E1A, far) : > + __kvm_at(OP_AT_S1E1R, far); > + if (!ret) > tmp = read_sysreg_par(); > else > tmp = SYS_PAR_EL1_F; /* back to the guest */ Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.