From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 341ACC25B7E for ; Wed, 29 May 2024 15:46:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F9446B0085; Wed, 29 May 2024 11:46:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AA106B0098; Wed, 29 May 2024 11:46:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 849D46B009C; Wed, 29 May 2024 11:46:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 664A56B0085 for ; Wed, 29 May 2024 11:46:29 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E7652409A6 for ; Wed, 29 May 2024 15:46:28 +0000 (UTC) X-FDA: 82171860456.03.3A2E9D6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id F247C1C0014 for ; Wed, 29 May 2024 15:46:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b1HcRd4F; spf=pass (imf18.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716997587; a=rsa-sha256; cv=none; b=qhUHVahqYlIQGn7oefzBwfT3IX4jQ5iMPKfqtx6bHIax5PSl7Z/k8vQbW1BSrCIkmAXThZ +Z/MxoYyShfhCkWk0DcteC9LVhz/wNJHUuNBDxe/F6byd37ZXmJviFB/uvK85wHIKEUeo+ rUKYo9qcPuE/9/yYo/Q8pwRO4HhxjYs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b1HcRd4F; spf=pass (imf18.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716997587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8/Z0JA7K2c25gAmDuXGr3cnRz6SMpCle6/5IzGIyWaw=; b=DfaoseL43CpKaZxTsrbM/afC2KWHLNQYn2Xqt/hlpo2ZGrY0NwIVY3f7plQJMa5z2rbD6Y V5y4DkB7rC/YOpWHchlyLgX0lz3um6eqPOt2JfCwE5ZFI+X7FpANwtbHAqoSaTSxyl9TsV InQm30ZxWs3TO1t+aNUmUOnIdw2ynPg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1B54861276; Wed, 29 May 2024 15:46:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBC9CC116B1; Wed, 29 May 2024 15:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716997585; bh=5H/9tAGxhCnQIdq/gPNT2uQTCgvD6jAZwCxyBBdjciY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b1HcRd4FyRr1Fgr8KI7GaMOYM54DLB/kJz++0sBj9koRiH1ImimLxCkncD3DWiJb4 NDH8P+IaKPe1VLQGZJP5nf9t3/ZSchz0OAJ4mpGWs1V3Apgz6CUNpTj4p22M34KEtD loH1/x5pPy2LnldfHajuPt15CKIwbllYL7rKylFdmMpIBBgYHlG/x0E6Prqo4VLR5F BXQc7DRs+e2H+ZvsNZNJqBI82iorAnwgpyaXrvj8xDcNrsvMLpbDse62m0cMekjJFE qRxhbulfJVSoPdv1Pix0R7Pb3LaMDPnYzIDyrfMx4qLrotZZidXBLndgigIRuAscB0 vdOTG32dAyCcw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCLVP-00Gfog-PN; Wed, 29 May 2024 16:46:23 +0100 Date: Wed, 29 May 2024 16:46:23 +0100 Message-ID: <8634q0mxio.wl-maz@kernel.org> From: Marc Zyngier To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 08/29] KVM: arm64: make kvm_at() take an OP_AT_* In-Reply-To: <20240503130147.1154804-9-joey.gouly@arm.com> References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-9-joey.gouly@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: joey.gouly@arm.com, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F247C1C0014 X-Stat-Signature: byoxwf7iqyj4yke1ryhutoz7bdpqfkza X-HE-Tag: 1716997586-979571 X-HE-Meta: U2FsdGVkX19oGKO7vK2BqDH5RCP5GwZLIYtns2gZcxecSF8GHMdLk29YOdfByZiLwcGuASwfsjy7IrnGMpnQVNFyawu6tuuWIUQQmR555DJfC7rlLwmYkOx1FYd3OuZ5yz/3uj+5r+XmxSU9owZEm4/iwGerp7bzYrgdv26rtktrgt5ZKGhTldKmXgZTRn9JrBsFsfteQvot+20ZOR12kXkryRNns/ORUjhcNeWL3x/PEk9iIYVmZbKekiIcsWQNAOvoszjiujjSplAMSzx6bOn5wGxbfZggV/m/qRIIkfnoV8Jk/8KJ1Gi7WEW3fsWp+IkQ6uYENHIA9KguXeTXu0CS5QR71Me3CBntqaOrG6sM9zQSMOA4xljxdrOFNmCkFja05/CJzB5FwvHkOnHDI5/bWqO5860vtoHSosR2US1XDlLOHfoTaqaw1Iy+W5QWrjVYrO9HyfFGvKb0j//kaQlRPIk2Fy16ObYl5Y0jY5B91T/oXWtOu+b08/3eX9Rpia/bratBi/gYbh3fUXWgczENQjhm3TfCsYFfJBfJLFJi8kdapWJX6VE49KpADgfFuO1ZxgthG+rib8bP+xZMeN3iWWUm9oXI5BCZ1Ks4IuTxMtNFy+6RaSxKvsh5+xqLcGdjJr/f+kbkQlcynYTtzbpELMGmLiIP6vmVTPITHHbTet6epRQR7WI6YKCj3laqmmWCS1doig/Vpx1T0nrwGyliIr7X8BLr9SWU+DHjnB24TtjewmfE3b7ul0gxuYiIv+xd2/VOH+qNxkedCGXebjdZWBPpi2+bpLWKdPS0sumJqOyWybiZNAlx8+SUMANwe2GYRgvEKC4qwUB47x9N0sdQfwqD9DpkrA8iwBIa2gjmTRd2DibzmdphFnKRNht2W95mw2Auqj1cbXJSDUkRU77SkebYW7bW5rzJMJVFe98t64/tSJHIZGa9+JTUXnvL+LfE7rkR3akz6KZ8AxO 3EJAtvPw iOv6Q1cbCkNZl3Qo0AdmLVAZxw07K6zcqr+zztZOPOr99LdufkDKyfMAe4rkXsTFVm9b3HU2s9KDCschka+JXyr6BvW3/rZ+6t5dL7zvZJTxJ2OW7vFeurENekqQ1PVfck6hdw51Vy+Jj0U7xTZfyMd6WLAbdguemRGH1ZR8mJAJ7QeV3uBswv5vQinQ6qJVWNQO+ouaIGcL25FwLXaHsJzzngdEhxTw4kYicUG0Kj9xrdp2EnTaFjtwtNtf+m6ZugSPmO2WstsPDxMR8ACO/9gMoUYLhDM7JzGOHhE05cuO5Yodd9irbdHI1Aqi+v+g7+OZ+gcmDaNog1XkcZJJYN4CxLD6TGLtZn9CDguOiFsJef/c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 03 May 2024 14:01:26 +0100, Joey Gouly wrote: > > To allow using newer instructions that current assemblers don't know about, > replace the `at` instruction with the underlying SYS instruction. > > Signed-off-by: Joey Gouly > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/include/asm/kvm_asm.h | 3 ++- > arch/arm64/kvm/hyp/include/hyp/fault.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h > index 24b5e6b23417..ce65fd0f01b0 100644 > --- a/arch/arm64/include/asm/kvm_asm.h > +++ b/arch/arm64/include/asm/kvm_asm.h > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include nit: include order. > > #define ARM_EXIT_WITH_SERROR_BIT 31 > #define ARM_EXCEPTION_CODE(x) ((x) & ~(1U << ARM_EXIT_WITH_SERROR_BIT)) > @@ -261,7 +262,7 @@ extern u64 __kvm_get_mdcr_el2(void); > asm volatile( \ > " mrs %1, spsr_el2\n" \ > " mrs %2, elr_el2\n" \ > - "1: at "at_op", %3\n" \ > + "1: " __msr_s(at_op, "%3") "\n" \ > " isb\n" \ > " b 9f\n" \ > "2: msr spsr_el2, %1\n" \ > diff --git a/arch/arm64/kvm/hyp/include/hyp/fault.h b/arch/arm64/kvm/hyp/include/hyp/fault.h > index 9e13c1bc2ad5..487c06099d6f 100644 > --- a/arch/arm64/kvm/hyp/include/hyp/fault.h > +++ b/arch/arm64/kvm/hyp/include/hyp/fault.h > @@ -27,7 +27,7 @@ static inline bool __translate_far_to_hpfar(u64 far, u64 *hpfar) > * saved the guest context yet, and we may return early... > */ > par = read_sysreg_par(); > - if (!__kvm_at("s1e1r", far)) > + if (!__kvm_at(OP_AT_S1E1R, far)) > tmp = read_sysreg_par(); > else > tmp = SYS_PAR_EL1_F; /* back to the guest */ Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.