public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Lorenzo Stoakes (Oracle)" <ljs@kernel.org>,
	Jinjiang Tu <tujinjiang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
	vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, baohua@kernel.org, ryan.roberts@arm.com,
	linux-mm@kvack.org, wangkefeng.wang@huawei.com,
	sunnanyong@huawei.com
Subject: Re: [PATCH v3] mm/huge_memory: fix folio isn't locked in softleaf_to_folio()
Date: Fri, 20 Mar 2026 11:22:40 +0100	[thread overview]
Message-ID: <86390177-3c84-4bc2-ae19-8a7ec82fd910@kernel.org> (raw)
In-Reply-To: <b5e99cd2-d49c-4653-8d0e-4ccf35b4a288@lucifer.local>

On 3/20/26 10:57, Lorenzo Stoakes (Oracle) wrote:
> On Fri, Mar 20, 2026 at 04:56:57PM +0800, Jinjiang Tu wrote:
>>
>> 在 2026/3/20 16:10, David Hildenbrand (Arm) 写道:
>>> But the impact is bigger, right, when callers rely on folio_test_anon() etc?
>>
>> Yes, the impact is unpredictable if CONFIG_DEBUG_VM isn't enabled.
>>
>> But for stable kernel before v6.19.9, this is a BUG_ON
>>
>>
>>
> 
> I think important to note that the asserts are asserting consistency, and not
> having consistency is a lot worse than a failed assert :)

Exactly.

-- 
Cheers,

David


  reply	other threads:[~2026-03-20 10:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  1:25 [PATCH v3] mm/huge_memory: fix folio isn't locked in softleaf_to_folio() Jinjiang Tu
2026-03-19  8:49 ` David Hildenbrand (Arm)
2026-03-19 22:51 ` Andrew Morton
2026-03-20  1:52   ` Jinjiang Tu
2026-03-20  2:31     ` Andrew Morton
2026-03-20  8:10     ` David Hildenbrand (Arm)
2026-03-20  8:56       ` Jinjiang Tu
2026-03-20  9:57         ` Lorenzo Stoakes (Oracle)
2026-03-20 10:22           ` David Hildenbrand (Arm) [this message]
2026-03-20 10:13 ` Lorenzo Stoakes (Oracle)
2026-03-21  2:40   ` Jinjiang Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86390177-3c84-4bc2-ae19-8a7ec82fd910@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=sunnanyong@huawei.com \
    --cc=surenb@google.com \
    --cc=tujinjiang@huawei.com \
    --cc=vbabka@kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox