From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "travis@sgi.com" <travis@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Suresh B Siddha <suresh.b.siddha@intel.com>,
Christoph Lameter <clameter@sgi.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array fix
Date: Mon, 22 Oct 2007 22:36:22 -0700 [thread overview]
Message-ID: <86802c440710222236j481d09a7odfa3ce279644f5bd@mail.gmail.com> (raw)
In-Reply-To: <20071012225434.102879000@sgi.com>
On 10/12/07, travis@sgi.com <travis@sgi.com> wrote:
> This fix corrects the problem that early_identify_cpu() sets
> cpu_index to '0' (needed when called by setup_arch) after
> smp_store_cpu_info() had set it to the correct value.
>
> Signed-off-by: Mike Travis <travis@sgi.com>
> ---
> arch/x86_64/kernel/smpboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux.orig/arch/x86_64/kernel/smpboot.c 2007-10-12 14:28:45.000000000 -0700
> +++ linux/arch/x86_64/kernel/smpboot.c 2007-10-12 14:53:42.753508152 -0700
> @@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info
> struct cpuinfo_x86 *c = &cpu_data(id);
>
> *c = boot_cpu_data;
> - c->cpu_index = id;
> identify_cpu(c);
> + c->cpu_index = id;
> print_cpu_info(c);
> }
>
why not removing assignment in early_identify_cpu?
YH
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-10-23 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 22:54 [PATCH 0/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array fix travis
2007-10-12 22:54 ` [PATCH 1/1] " travis
2007-10-23 5:36 ` Yinghai Lu [this message]
2007-11-14 18:45 ` Mike Travis
2007-11-20 7:55 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440710222236j481d09a7odfa3ce279644f5bd@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=suresh.b.siddha@intel.com \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).