From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D12CF6D3B for ; Wed, 2 Oct 2024 15:55:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F82B4401BA; Wed, 2 Oct 2024 11:55:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A7B94401B5; Wed, 2 Oct 2024 11:55:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 021274401BA; Wed, 2 Oct 2024 11:55:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CB3CD4401B5 for ; Wed, 2 Oct 2024 11:55:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 64AA5809FC for ; Wed, 2 Oct 2024 15:55:34 +0000 (UTC) X-FDA: 82629112188.01.0B0B1B6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 72DE720003 for ; Wed, 2 Oct 2024 15:55:32 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k9RkyEgh; spf=pass (imf13.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727884405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y7Y065ncgEQkeROLY24Zjrin44Qypn3x4BPgUrreoPU=; b=l43dBRViVxjUXw7AB7aVaGtdSuT2raXDZWgLrqffpij+W5JAqKhoJx2c1iC7prUb1zXVFJ flfBRonJH/CgttxDFP4EXSiox1syClcMLt5H3lgBGRs3RcfVoEZOYXjXqmtNaLYwZHCByx E0AIqkW9ovcefYhvLspUyHT9RLUJ8X8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727884405; a=rsa-sha256; cv=none; b=PrIUlWCuwhIoTmDlkvaheMzdFiOdr3R3kjPV2UmxlUatBGm8v1FQSuoheqXL89lHy/rars C2s+fl4RojKCCDxVn8ZXF03XURmimlPnUhblpGygtkOgIj0WRn54MZD88uV3mxGe/Vjj/5 kWJaA7lPBCuAwmt7GPuLl6v5mk8G8TY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k9RkyEgh; spf=pass (imf13.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B23545C2783; Wed, 2 Oct 2024 15:55:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79667C4CEC2; Wed, 2 Oct 2024 15:55:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727884529; bh=27HUeDVHXOs+OLA9bA8uKhz/MQrgdafn0/iAATWL0mM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=k9RkyEgh+Y/YS87nAPF1Ao6uiCfC2Ka09hloc087gdGHJXHVDYXjBmR2ceETg9ni6 deks86zaFNOb6z1/RiWcTXvOF0U/JLOW08+SpteRcOBc5nPa3btIZx+FKc8OiNN7e+ FEG/zba/f2YQ1sA2bH3Qf0Z5Uaro4RI1sXzvYN+fyrehRew3uav87f7UIuG26TbRhf SHQvJ+naVNRRTRSJjCOOekaQRb5r/ZRFkTQWCmGQOBDzHBWS9b9AJAbC35w5zYjD/x A1nX477cbgft4pfSE+Rw4NrdL8NdIF2MVohLnxdgNDdBRy1nbrrn5eOA9cIL3jvekY d3ZSOc2PuCwsA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sw1hG-00H6P0-9r; Wed, 02 Oct 2024 16:55:26 +0100 Date: Wed, 02 Oct 2024 16:55:25 +0100 Message-ID: <86a5fm7b4i.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , David Spickett , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v13 16/40] KVM: arm64: Manage GCS access and registers for guests In-Reply-To: <86bk0373nq.wl-maz@kernel.org> References: <20241001-arm64-gcs-v13-0-222b78d87eee@kernel.org> <20241001-arm64-gcs-v13-16-222b78d87eee@kernel.org> <86bk0373nq.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net, akpm@linux-foundation.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, arnd@arndb.de, oleg@redhat.com, ebiederm@xmission.com, shuah@kernel.org, rick.p.edgecombe@intel.com, debug@rivosinc.com, ardb@kernel.org, Szabolcs.Nagy@arm.com, kees@kernel.org, hjl.tools@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, fweimer@redhat.com, brauner@kernel.org, thiago.bauermann@linaro.org, ross.burton@arm.com, david.spickett@arm.com, yury.khrustalev@arm.com, wilco.dijkstra@arm.com, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Rspamd-Queue-Id: 72DE720003 X-Stat-Signature: 9n8hzjijtdeke6tdr5pnyzsh49gumikx X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727884532-879489 X-HE-Meta: U2FsdGVkX1+R/L887oYvsDeWukU/Y2cC/vCrFguEVnRl/u2PmBWlajp5j9BclHsmbEeOWaf+Yfp2HY8R6DESupWaDHIvUFyNj4owFEJ31r0EVJdMkH6TjtadQBvpubss0bD/L5VlZmsKXYJ05eOpa14gK6OGRXZR9jTVmPu13DkGSGFRuLYq34h7x4GUpIcfNvCfmcVeI+MT5sxrG9OwZHRpvFsD2jqqf071xLHOseGvh3uumNN0V2Bh9MB+SKlHaEXPMEyFym/jEml5soMJPXRdzC+oXsPsRv+CBmOCpojCW9SMjGp7fVbb4zD4bacN/SZJ/Q97iPHXcMN5xxEhky+BDlnN9TqhOrC+kzbz0MwjXcWQL5Dol2BUNsQXOZvwAP/pqcKhNhN8wB+mth6SR3z+7swch3MTO1s/WZfGDc9PVwuVy2Hhq+Dbx01RCpc/+76r+SoVyT6HLCOzPILnVxaWyViWgTdRma5ZE4hvEz9kzI6rVODeC0K3CB2wOjR05gmmq1AKZc+nIhEFFL7LogWntKVw3k5SNYzS47QGcTYga6NvO0ixTofKIAhIP7JVfsTnpXbDiRVHfyKm1xUx1oG4vlLL9dZCLujrdBgs4r4097KdKcHxwwoH10eP3LKoPtlx9IKGsHS5PgjvdQ0stSlxL5Mq+60UA0GtP4bfLGMkopUP00N2TkyDewmgTnzVn1EnxK28OzyWJKGeEVMaRdwndsfVpU4u3LFBQYgmDxG6g+Q9YctoYz67TewpT30sUua3/oUwkUF9dnTCCPWjc83niGzx1aUecVo8CZD49UkoaaeVod9b9Btc9qwC7mTnucjDXDPxNt73fz/QIJMiVS83oO65qT2AqqzPidzupls+Q/QbmXU0CKfhvdXsw27dYHP52CdV4M8Sc9d5eGeQGGAZ5fSQ1dzHh17kkfGnTHFvztH75GP68JvV9nAOLUBb7NZDRxk9vD7h9K1UmLZ ggoHh9Ww pSnb8c5lTxDdmPPZ05sVGkU0eqIp9zlBJ8aBvmLTDKKEwFx/1DhJdhlwg5ger08uRj72LUJwcwtcyYm91SoEBz1frIZFISaEyVeVjoT2/vBV8V4ok/MfSrcBDacjrgj/iZ5nYtk0wl8G2oiMyT+MKUwHyUFyptoyDpg7OaaCXyPkJnbAkOOmwNn+vibZKWIjy3xR1AuY3kspShuIdlWVP3QyrvemmwGeTLMV94SW8g6de3d6R8bQwAt8qy99V1VufvOG2dGwK33oQKAmHJLytGC7hfhIA+iSIxNc+neW4kJgkcNiz/TpHAyZZs2LyLa6qwQMc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 02 Oct 2024 01:24:25 +0100, Marc Zyngier wrote: > > On Tue, 01 Oct 2024 23:58:55 +0100, > Mark Brown wrote: > > > @@ -4714,6 +4735,10 @@ void kvm_calculate_traps(struct kvm_vcpu *vcpu) > > kvm->arch.fgu[HFGxTR_GROUP] |= (HFGxTR_EL2_nPOR_EL1 | > > HFGxTR_EL2_nPOR_EL0); > > > > + if (!kvm_has_gcs(kvm)) > > + kvm->arch.fgu[HFGxTR_GROUP] |= (HFGxTR_EL2_nGCS_EL0 | > > + HFGxTR_EL2_nGCS_EL1); > > + > > Why are you still allowing the GCS instructions when GCS isn't > enabled? Scratch that, they are NOPs when GCS isn't enabled, so there shouldn't be any need for extra traps. M. -- Without deviation from the norm, progress is not possible.