From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B73C83F1B for ; Fri, 11 Jul 2025 13:25:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 693566B0099; Fri, 11 Jul 2025 09:25:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 644306B00A1; Fri, 11 Jul 2025 09:25:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E4056B00A3; Fri, 11 Jul 2025 09:25:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3A0A36B0099 for ; Fri, 11 Jul 2025 09:25:57 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F1751BD8C6 for ; Fri, 11 Jul 2025 13:25:56 +0000 (UTC) X-FDA: 83652056712.30.756609F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf05.hostedemail.com (Postfix) with ESMTP id EDE12100009 for ; Fri, 11 Jul 2025 13:25:54 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ZFMgq/Nu"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of maz@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=maz@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752240355; a=rsa-sha256; cv=none; b=LDV2Nlo3RvwtkgeZ1ykvXi6KL3DhZkcB/SOeWnJcZL9JLwcyIm0K6laYluzpKBI+27L6tA V58HkPXkYJD4L8FIbkuNUx5Q7a8EhWfwsxMmyp2BRg+KtJ65QKRC6r0UPfsVR8k16bYaI4 fZ/nMCTRJQdcwk7XsNZ+PZ+IErnCp70= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ZFMgq/Nu"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of maz@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=maz@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752240355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1873WHRe1fBfPsa7A0H5hUauRH44HnGxCmWxtoFhqlY=; b=SnVj3RD/HqSOQ+V/WR6wZA/Oo1SOv/ruMfRUOuOs6nvz+fyXmevknvaTAhH+KbaG9uUIH/ miP+EcEu4kr2CN/8nLImvIZQh4QVFxs1b5at/xkh4IojFhkYe57qLWOuNqxdcmUcH8hoyF Lwj0UxQTJkm4ROfhphPI/R4f+NpsAeI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 990F24574D; Fri, 11 Jul 2025 13:25:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CFB8C4CEED; Fri, 11 Jul 2025 13:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752240353; bh=ElLDnp76WNWwDKvqu1oD1zoyAlrNJ4iqci+1Wx68bzk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZFMgq/Nud9mlT2A/Ke4bhx0atcdEPWwejkPk1r1Jqekr8HUbwj0QBghb3auZMrwse fRSDnBrMddjw1ds1n/Oe4GnRfhmYF1RaYI64/NJ4LqEwvWBEu/JGinDi5w3onmcoK0 jU/Rfjt0y4kFsOpOfLwPP6SRHY9kkpcegtCeY9IX9Uya59Abzr/nLn4luB6NrisESD oOiQ+6/02wIn4YcyhVc0AQ7MhfgxDvm+4KKH/fmhX8u+R/02boN6O33FluZ09k/uMB mFQzRONSNfN14uQ6jE7rdZhTbLtXk/Twi3t41PLnMJJeh8zNWHR5rV9NVLYN5B7MXm J+0TZOjxbhJeA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uaDl8-00EspX-Jy; Fri, 11 Jul 2025 14:25:50 +0100 Date: Fri, 11 Jul 2025 14:25:49 +0100 Message-ID: <86bjpqamg2.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Subject: Re: [PATCH v13 15/20] KVM: arm64: Refactor user_mem_abort() In-Reply-To: <20250709105946.4009897-16-tabba@google.com> References: <20250709105946.4009897-1-tabba@google.com> <20250709105946.4009897-16-tabba@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, qu ic_pderr in@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Rspamd-Server: rspam11 X-Rspam-User: X-Stat-Signature: f7nhs3hhjxpepnqd151jhmf7jwn1s1nc X-Rspamd-Queue-Id: EDE12100009 X-HE-Tag: 1752240354-295276 X-HE-Meta: U2FsdGVkX18EBV47eZXSUG1KgU87BR3APHNOpHlKSxJWUjC/BdN80Qadk5UUujiDyt7Rq5C/TNt2PKE8E5IHrN9xZudPY20FPMhUH/XpeHk1qLgtEXqwz+bma7p4kok97LrceTpJjOph8OfJb+7FYLUSOUH1el3pqjI5+k7qlDggImS9Yy61Xfj3o/qvELgs7E0Fx264qBpbzFFOK0RjZZ0Y/UUzIVth3hEWIom7bbXjFeNX7CN/fLE2DYUDRPw7EocOCMcYNDNncC8br4MOYf6ng4DRBoWaiYflGVR9NjDGSRPkDxCpBi7fLNn1r4K3l6bsmbmtWYVxPDsvTxcau+ZvCgr20iGyck03IFjQtMIJvSKd+srXohafLwyUMYH2TNrNBwH+oUKuXIAK/W1NF+k4tMHTb2jgnKDRaTxDnAnAg/fYfcu1vhG77KhOaBIS26AjuC2DA0kE+wxQFm3F0bOz0/myRXtafc2pnr3hFr4vP07ifcwt2DinuW+pzEeCahtCXl2xdeBeMS2nn9y05gQfz8hhWjmQ5R3ePQPIZ95JAxx/zg0Z564XOi1LWol9BOCdF3EiQkAp1JDjW5EqtjLZpM1JxWfIGguuv6WvMTOi77v4GVzzc10hoerj8GUhCfdi5FPYnLB/SCBintDalrmBM6wqNdXudnslx7JQF+Wqclqn31gRxbqafTm7j5EeFRI9khd1+QtsaJAt84HqvjaTRb7/lSwF9MDCtETIQuadGpdWDKhzSRHZ5h+AYNVfxwT+NW0fvrM/UPZu+6FAz02sOWbO9R8SfK0Qy8hA/XnpTmfxif8cPFB/Pdve+zVGegwliv5Wr5KnWKpsvIEsB4FCbeDbdE5sPf8uIaRvOyJT2aaqyt1XeOrVhX69NyH0gJHdRpzY3g7XBKY6ojFz75+mnRpFWf6OumO0eqUwhudt98zX7P3q0uiDgVsfzbOcLoLg/nihCzxBVm9XD69 70oacAFz 0yaWen/L0usCVpc80wda97hTNuKsT+/38kXQqFUw0qbMyxTB/9/YdQxCz2JbUMalu4GS513FIqFlbt1y+ieezZ+p120Hs+ZZ9HlrnkP9FMUmGObrwGtPx0uKRCiOs4vjR363M1O3Ju/XGL8nudUta/vXsXMOVWXWP2MUyRbqbJ60h9LtuvaKcsSi7GOTmJ5fFAXAUnKLBGH8i+/S6XuFBEDkaP7eYDbjlCuuZBnZE0vhBStuysOimdRxRlJY/VXOm/zyrFkWwx8sGROvw79UbzEclouu6wwZUNG/QF+hErXtz1LITKr5jlAZqESoo3nVgZcN+IJo1S3ea/4ZactThsyPguOpIQBENqOfAh3wZ3HwgyY98wDaP0zwDCXLI+mFwJZdSqewB5m2B3FEq6VbblWkU5KJ0FTvUqbqk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 09 Jul 2025 11:59:41 +0100, Fuad Tabba wrote: > > Refactor user_mem_abort() to improve code clarity and simplify > assumptions within the function. > > Key changes include: > > * Immediately set force_pte to true at the beginning of the function if > logging_active is true. This simplifies the flow and makes the > condition for forcing a PTE more explicit. > > * Remove the misleading comment stating that logging_active is > guaranteed to never be true for VM_PFNMAP memslots, as this assertion > is not entirely correct. > > * Extract reusable code blocks into new helper functions: > * prepare_mmu_memcache(): Encapsulates the logic for preparing and > topping up the MMU page cache. > * adjust_nested_fault_perms(): Isolates the adjustments to shadow S2 > permissions and the encoding of nested translation levels. > > * Update min(a, (long)b) to min_t(long, a, b) for better type safety and > consistency. > > * Perform other minor tidying up of the code. > > These changes primarily aim to simplify user_mem_abort() and make its > logic easier to understand and maintain, setting the stage for future > modifications. > > No functional change intended. > > Reviewed-by: Gavin Shan > Signed-off-by: Fuad Tabba Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.