From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD257C3DA4A for ; Fri, 16 Aug 2024 15:32:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E1228D0088; Fri, 16 Aug 2024 11:32:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 390B48D007E; Fri, 16 Aug 2024 11:32:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 258A58D0088; Fri, 16 Aug 2024 11:32:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 00CC88D007E for ; Fri, 16 Aug 2024 11:32:29 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A0F05C1C55 for ; Fri, 16 Aug 2024 15:32:29 +0000 (UTC) X-FDA: 82458500418.16.EF23D4E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id AFC044001A for ; Fri, 16 Aug 2024 15:32:27 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tPVlavzi; spf=pass (imf27.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723822310; a=rsa-sha256; cv=none; b=jbPZJs/OqxCUs9UywXftxwo3zeHfX4wWmawmPtUtoE76Qa5bgNiuvbzPSoM2L/dIVsDTYy 3TUbxi4QfXViftBsP/MM2bhlRkl07QLKa7cMXE43WUJcLmfY56GiARpWB8eBA+dHbWHm8M klBm/L3zbKNtGIlhVxaxotdqsClUCSQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tPVlavzi; spf=pass (imf27.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723822310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0jrsSyad4bi8H3lpUYriVJm9XxumsRDBv0smimR0KCY=; b=hfRrnFzX7oammVklTCwXwehGsPkCSNAA32NulXhEuqThHQ7HVsRCfAe0wmHbWVufaedGAS JrQZuXVCyTUVEYoJirGHxt7SshE1yG1Fc1jVV/2rcvQlN9BQ2JkBaLlLPTW/Vurswlw8Bp s5zQDaOyH8zvJxguq9tVI/iGJ9yARt0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BD4BF62229; Fri, 16 Aug 2024 15:32:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67E49C4AF0B; Fri, 16 Aug 2024 15:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723822346; bh=2/SyteaEDgLjslhjK5Qrg9vsTkx+4CL4Pn+Rur8QC18=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tPVlavzii20FYM/2odXn3dc4J0pC/bFkESC3D+bRAYJ60xDKKbQDYU7wLO92oko/9 I0igy24KZcT6i753jJI9WxsYUU6D68lkfP9VPCfYKB9F5uUoX7c1EdnvFBs6qCWc+4 D+ly54JIrs5pIPKeHAVaFMTESgVSdKBPQBvD45Le70/UO5fD86Y5/6p19KuZnkt8px XF07CnZ9evf7RwPPBLQ4UKPDxTwFwVLHTmmhV5OByZ8TaO3m2MEuHcoHcj7oCGaAHK OqmY+UmluMV9KFtA93H1zXF/fAIGQQwntdR7E/Kym2bSphGLZxNh0c6eYNBAdDv/5U Nq6MGN86ZajLw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1seywB-004K1i-3k; Fri, 16 Aug 2024 16:32:23 +0100 Date: Fri, 16 Aug 2024 16:32:22 +0100 Message-ID: <86cym8zdo9.wl-maz@kernel.org> From: Marc Zyngier To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 07/29] KVM: arm64: Save/restore POE registers In-Reply-To: <20240816151301.GA138302@e124191.cambridge.arm.com> References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-8-joey.gouly@arm.com> <86ed6ozfe8.wl-maz@kernel.org> <20240816151301.GA138302@e124191.cambridge.arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: joey.gouly@arm.com, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Stat-Signature: yx1ehth6ex4anon1qruqidb1poert1xs X-Rspamd-Queue-Id: AFC044001A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1723822347-481830 X-HE-Meta: U2FsdGVkX19dvmMPbCKiARXJdBmOVQ8dgGpTJCxezYqeZobreAjoG69lDhZfEfNUjrNeU/iuBnEIH1o8ro3yvg2JuK99H+GtInvXAiZR3sPnVj25TQokX4PqDo32btWRpJp3Bhx/b/tLSE/whHaeaUnMZaCnWShmD2zy1Jr5nKDnBwSThDDZSDIECWylpNwQgAOKgBaIjHpwPQeD6o66fm+Cp/hndd5ZwLQHpz3djivWflVjtcUx4sx5kuFaSmPSbxjUARMkZ5VjaotbzYqMt/uFQ48fPyRkAXeAQKog6el9s+tpXLp0NMP6j5EnJOhewdWOLiPSW6IHHvxTMRICHfqak+pslMX2NCjQOjecqUuw9SOV5jGR62GeHtbAnK4aKlt6l1yX/hivwCC1vJlzcMcoedES9rDgw1+IMEIEXpXXY0Xp+ocs089atLJN9kecgvlUrm1GyVr4QoOOcAxdD6tuqKAtO9L0tZblKhjfy83qZ4jwUk6Cen8KHh5cTHG77gQYxfjUpGf2zU9I6ZiT6frt46KeTfOae0Bf87J3ClNhGTpuZ7DoLGLZ83KkvHwutAbb56veo+rwSI7cbeDSMJNC1EmGlgFS4Dpd+WLKFZB9t9OpP3O4PjtAu/xm4UXdjIRPoo9UWIVE/8CfEFVsYIV+l9SFy+oVkMjU3NlwK3K6GoGwr2w/TEov8LJo14Lb0plwJBZYt5h3O7k8ze62h53AMnfP36K4Lj1NmjKvDYn1wchdOv49aEcRVRj07AUcpG/4ONiRCrozbwGeOahEiS0A8ZE7u3WeiEplJxjMdcEfEpC5SHHLIoMZtkt1J1j2DYtrRUiri7KCrVTToor4EI5TzHb9Vue2RySkMSIDaH2F/HyQfL4l837fb/a9hTGd7UCt7LyqJKyo8iogUqOyCNPT+eenWMi95vxebMEl8k0cLLIIwHUGz5zBgOMK9OvbX935g0bIJaWJCsUjuCt ZQQE8YX6 V0DhtvbJFFb4WAX9IvMzdAlsKlCwxO9pEe+0Rc1K1Tl+wueRfyt+fvkFA6gAfx2vUs/QpRA4o8g/pDLKpgxqyzypX/rZKYVEJOKiG8A+BXDgb5luAcrZQb3ikCDWmd+9BGy5/mdEhE9n3fEZPm8IzqQoIAwyOPet/UCsvRGX3jnTI+RlPmzl5oNeFSQkbfHe4y2L1S62Pp9eVrfJqch9dQI7yyQ3lE5TRnwcIJ+Lhl4ljR/54N8cTpKRjzFUQFxzm3wVJZCgXTQrWBhNy2kG3sQvyq/j1O+PtDRQT7DhnGeIr6FgEPkfRj70dbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 16 Aug 2024 16:13:01 +0100, Joey Gouly wrote: > > On Fri, Aug 16, 2024 at 03:55:11PM +0100, Marc Zyngier wrote: > > On Fri, 03 May 2024 14:01:25 +0100, > > Joey Gouly wrote: > > > > > > + if (!kvm_has_feat(kvm, ID_AA64MMFR3_EL1, S1POE, IMP)) > > > + kvm->arch.fgu[HFGxTR_GROUP] |= (HFGxTR_EL2_nPOR_EL1 | > > > + HFGxTR_EL2_nPOR_EL0); > > > + > > > > As Broonie pointed out in a separate thread, this cannot work, short > > of making ID_AA64MMFR3_EL1 writable. > > > > This can be done in a separate patch, but it needs doing as it > > otherwise breaks migration. > > > > Thanks, > > > > M. > > > > Looks like it's wrong for PIE currently too, but your patch here fixes that: > https://lore.kernel.org/kvmarm/20240813144738.2048302-11-maz@kernel.org/ > > If I basically apply that patch, but only for POE, the conflict can be resolved > later, or a rebase will fix it up, depending on what goes through first. If I trust my feature dependency decoder, you need to make both TCRX and POE writable: (FEAT_S1POE --> v8Ap8) (FEAT_S1POE --> FEAT_TCR2) (FEAT_S1POE --> FEAT_ATS1A) (FEAT_S1POE --> FEAT_HPDS) (FEAT_S1POE <-> (AArch64 ID_AA64MMFR3_EL1.S1POE >= 1)) (FEAT_TCR2 --> v8Ap0) (v8Ap9 --> FEAT_TCR2) ((FEAT_TCR2 && FEAT_AA64EL2) --> FEAT_HCX) (FEAT_TCR2 <-> (AArch64 ID_AA64MMFR3_EL1.TCRX >= 1)) Feel free to lift part of that patch as you see fit. M. -- Without deviation from the norm, progress is not possible.