From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A8D5C6FA82 for ; Thu, 22 Sep 2022 13:12:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3955940007; Thu, 22 Sep 2022 09:12:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E80F6B0072; Thu, 22 Sep 2022 09:12:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AF5E940007; Thu, 22 Sep 2022 09:12:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7D6B06B0071 for ; Thu, 22 Sep 2022 09:12:26 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2DAB7A0E2B for ; Thu, 22 Sep 2022 13:12:26 +0000 (UTC) X-FDA: 79939760292.28.DFD682A Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf08.hostedemail.com (Postfix) with ESMTP id 9432A160012 for ; Thu, 22 Sep 2022 13:12:24 +0000 (UTC) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MYFvZ2hmBz14S3x; Thu, 22 Sep 2022 21:08:10 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 21:12:18 +0800 Received: from [10.174.179.24] (10.174.179.24) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 21:12:18 +0800 Subject: Re: [PATCH v2 8/9] memory: replace IPC_CALLBACK_PRI with MM_BATCH_CALLBACK_PRI To: David Hildenbrand , Andrew Morton , Zefan Li , Waiman Long , Christoph Lameter References: <20220920025123.2868953-1-liushixin2@huawei.com> <20220920025123.2868953-9-liushixin2@huawei.com> <64944e1a-1791-f10a-9d36-965267025c76@redhat.com> CC: , Kefeng Wang From: Liu Shixin Message-ID: <86d23a24-377b-6670-f881-bd5cb9b3a341@huawei.com> Date: Thu, 22 Sep 2022 21:12:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <64944e1a-1791-f10a-9d36-965267025c76@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=liushixin2@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663852345; a=rsa-sha256; cv=none; b=D4MUfPtGcpAZ/dz4NqFjXxmddzexUSEC0lW2iqkpBPmP7GX1tGSwenzG+r7r3ZvrtxpJwo eJIcO/oi+/N5yLjVH/HtTVJHrga0XPOixJHw0WmDGcvvv87fuFG/G3DC4MotJnBp3ZZ3Zc Eo0ndfJmqlW+wkFNEsUd08GdimfWCH4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663852345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IZ2sLp/KHMtj7O0e5c6lKIRKyMLsIG/WcGAaim0jLYE=; b=czKjhoJM2mLDC+q6fwCxa4KtPiQVcLVUEWjC3xLvce4B0+JMIxq4Tiq1XDMtdGQEI/G6Zw UU+/gsUZHx0+j8SoyH/DFBsPtTn3ZGxd/9s02BBTZWNqI5ZLZ99ti1pJ0zhog580bvfkg8 oPI9YAoGwrqm4L9vTBv9G2YkThvA/zI= Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=liushixin2@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Stat-Signature: dieut3194cx3eopgx5dijzi1u98gpy7x X-Rspamd-Queue-Id: 9432A160012 X-Rspamd-Server: rspam09 X-HE-Tag: 1663852344-660229 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/20 20:07, David Hildenbrand wrote: > On 20.09.22 04:51, Liu Shixin wrote: >> Since there is nothing to do with ipc, it is strange to use IPC_CALLBACK_PRI >> here. Replace IPC_CALLBACK_PRI with MM_BATCH_CALLBACK_PRI for easy reading. > > Should this better be called MM_COMPUTE_BATCH_CALLBACK_PRI > > Not so sure if "CALLBACK" is really the right term to use here in general ... we're talking about the memory notifier priority. > "CALLBACK" is not mandatory. Just for the sake of being consistent with other macros. MM_COMPUTE_BATCH_CALLBACK_PRI is too long, maybe reduce to MM_COMPUTE_BATCH_PRI is better. Thanks,