From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55B1CC76192 for ; Mon, 15 Jul 2019 10:51:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1F50F20868 for ; Mon, 15 Jul 2019 10:51:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F50F20868 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B1F136B000D; Mon, 15 Jul 2019 06:51:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD19F6B000E; Mon, 15 Jul 2019 06:51:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 997416B0010; Mon, 15 Jul 2019 06:51:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by kanga.kvack.org (Postfix) with ESMTP id 788796B000D for ; Mon, 15 Jul 2019 06:51:33 -0400 (EDT) Received: by mail-qt1-f199.google.com with SMTP id y19so14478121qtm.0 for ; Mon, 15 Jul 2019 03:51:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:openpgp:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=if2pRzX3JOWhxfH3KWuYESGqLVkh4dwEpfCH7VJWtpM=; b=RGg4UBJSS+GoGtdckPnw0pOTTXiX+MrRMNS7joPweop+qHrFrS51jufQ5HTHXpROrO iv/s5sKCiyC6ADkOaEn5bDuQmavhW4NooaJvmdBnw4TalUR9xThhqKFHWSWHx4z6ZyGs bDhSYFy/+dwbLZ+ZKWLA4JkmGOsyRosiE6wNGu2SNfW4OUh5s2ws0SmzVQRprFCUIL6r 44+1P/YIAh7hQ/JVUIvy+q+fwH30ePiLk+KKf92/Sqn7br2jfxplgkx/iLA/yBdQOyJw JN/0fY2k/ZMNRnTDiDv6p4ZvQPalRUdu7tY7hlc3caGGwo85cqpOGL0QOjrcmlAi9kph 7esg== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAUi9hZkmWkU8pCRMU9kJymz6lndqpficmg10Jl41gbXdO1h/p0I IYhHUJQaKsBc90FF5lCSe8i/ppk00D6tegfZ3pLcdxuv0Kao8v7PiPLcax3NvmdULy06QwD6p7g PLOD0k5Cr92KSOMJcY7yMrT8/P97GGW4aVUgOOQFVFhwznK4FUKnoPUAnSw1hyTt81A== X-Received: by 2002:ac8:7b99:: with SMTP id p25mr17442872qtu.243.1563187893286; Mon, 15 Jul 2019 03:51:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqwVyiIbBDj5x2NKQoAdq134vi/NnvU8op7gxECdRL6kHLzXZcmym3xHpvRNCUenJWNVWQ6Q X-Received: by 2002:ac8:7b99:: with SMTP id p25mr17442848qtu.243.1563187892815; Mon, 15 Jul 2019 03:51:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563187892; cv=none; d=google.com; s=arc-20160816; b=rup55sM9tjaD8QkTb6g8XZe9Ah0+jsYWzG1iIfZXJFbqwllgXmbGrjz+DhbNuYdm5f C8DLnqQFlc5PpgmtZ4uXcwMUiz9B2CyHtkTQoB9wZwor4uicepTsSXerKW80tlu755M3 4ildFslgQUPrXTgBVv748r4NFAU7n+ylTEZRRWv/ghVEBCnidF7TM44GpJU1URP9OgtC 43BqZmzLYQdeADB37TVwJuB5z9BMeeNTCQttQLjxwDHXFlwn/JMMzGkpxpmxeLaQi3jc xUs8clmQ0SIZcKky011XiEjVdbZ/t4YKSskrB+Sp4uL5BhYgHRNp30iNPtWduOZhZMW9 CX9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:autocrypt:openpgp:from :references:cc:to:subject; bh=if2pRzX3JOWhxfH3KWuYESGqLVkh4dwEpfCH7VJWtpM=; b=J22qpvoXH8QRqx7hQ1ghhWdoPKrp2d9ZlAclWxo5d4XO6yI32ahAeA0VeELZfZSU8F cxlmaluPDDLC43JF5RjqcVSg+7Jx0fNFItV4M71AC86hiZzQAJlQ74TEIoWyQH/awisL 4z++RFYwfr+bfHibV5JD8TN2GoscGkYUHxekKJ3eQ1x5gK9r7JS1x1nz+amAGBx4rG+f bhKH35fexmlk2cssZe3awWKiSaPgikKXJtgYImlA1JDafILl3xeMX+s4kpKfp0J5Pm69 GTgva3lg4pdcf2WmFwiORytipm8wOviqk8J+QizwVW6bD54P/Cx488lrDbnXI9o6l8Ta bJzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id u38si6643153qtj.50.2019.07.15.03.51.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jul 2019 03:51:32 -0700 (PDT) Received-SPF: pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D41E9307D910; Mon, 15 Jul 2019 10:51:31 +0000 (UTC) Received: from [10.36.117.137] (ovpn-117-137.ams2.redhat.com [10.36.117.137]) by smtp.corp.redhat.com (Postfix) with ESMTP id A77F31001B17; Mon, 15 Jul 2019 10:51:28 +0000 (UTC) Subject: Re: [PATCH v3 02/11] s390x/mm: Fail when an altmap is used for arch_add_memory() To: Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, Dan Williams , Wei Yang , Igor Mammedov , Martin Schwidefsky , Heiko Carstens , Mike Rapoport , Vasily Gorbik , Oscar Salvador References: <20190527111152.16324-1-david@redhat.com> <20190527111152.16324-3-david@redhat.com> <20190701074306.GC6376@dhcp22.suse.cz> <20190701124628.GT6376@dhcp22.suse.cz> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: <86f3ff3d-d035-a806-88b7-b8c7b77c206e@redhat.com> Date: Mon, 15 Jul 2019 12:51:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190701124628.GT6376@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 15 Jul 2019 10:51:32 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.07.19 14:46, Michal Hocko wrote: > On Mon 01-07-19 09:43:06, Michal Hocko wrote: >> On Mon 27-05-19 13:11:43, David Hildenbrand wrote: >>> ZONE_DEVICE is not yet supported, fail if an altmap is passed, so we >>> don't forget arch_add_memory()/arch_remove_memory() when unlocking >>> support. >> >> Why do we need this? Sure ZONE_DEVICE is not supported for s390 and so >> might be the case for other arches which support hotplug. I do not see >> much point in adding warning to each of them. > > I would drop this one. If there is a strong reason to have something > like that it should come with a better explanation and it can be done on > top. > This was requested by Dan and I agree it is the right thing to do. In the context of paravirtualized devices (e.g., virtio-pmem), it makes sense to block functionality an arch does not support. I'll leave the decision to Andrew. -- Thanks, David / dhildenb