From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EB2CD379F for ; Tue, 3 Sep 2024 16:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D1FF8D01A8; Tue, 3 Sep 2024 12:24:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 581538D018A; Tue, 3 Sep 2024 12:24:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FA938D01A8; Tue, 3 Sep 2024 12:24:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2009D8D018A for ; Tue, 3 Sep 2024 12:24:32 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B88E01C19A6 for ; Tue, 3 Sep 2024 16:24:31 +0000 (UTC) X-FDA: 82523949942.11.5AE0104 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf07.hostedemail.com (Postfix) with ESMTP id C80D24001B for ; Tue, 3 Sep 2024 16:24:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Sg6V9ryn; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of maz@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=maz@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725380591; a=rsa-sha256; cv=none; b=c0dBqzr/pyBsbQUbOuNytKu89nQIPTNI2NYNS2PoxRPs8yZy6DL7XXoE/vUGtXs3nvR6C9 9F1uW1xCI1DVaVtk6jL/ol3Vq4atdtpchoZOXP9umXQqq+wUbtM3YT07PS82eTLACCI9YD Fq+VGzXJ2JPq0QJLcpmens+2YMKbIlk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Sg6V9ryn; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of maz@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=maz@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725380591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=syaCGMTwBPgyRpEft0FCKvldfW4g/j8c9HlaRBhkwZQ=; b=0HTc1YhCB69o/25xKeok8BnGXpsFfAHl9CG2ihfz6syM51th36foRWEFxsC4WFlkN03LSm mvvJUaHY+VZbsXUhbWO/Hh4KL7U9zuRYrtMn5u/7RNQYLarvxT2F7qTrqB+FQrWrvzr5lm NWCoOfC0jlTG6OJ23r7xW5JtfB1Iz2o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 96C16A43CC0; Tue, 3 Sep 2024 16:24:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66625C4CEC4; Tue, 3 Sep 2024 16:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725380667; bh=9iVOVu/9OW9hC1XMij8LOQYkL6JBtfZqflc0EqcwKzo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sg6V9rynIO66aMzDEBdKiQ0PGMnzTSeEnWtbuUwm1PMyXSw6Eb5HLrr+fSzCLg5VS RpTpcLZdH0/HhnyFmkx7TdZyKyFyZyb2qNdRz3JhkQrXjbDjTft5YAHYZX93CBNlS7 CJlI1eqDSRpSThx4MCtKO9jqYyuli7Keqv5WG70qcjiQ5cCbYfJf5Lv8ERlynMtaid lzVOPLg/KQ+9XmZQmpdlE39b4X7g4bqYuZVHPFpOgmTf1jNIgR/+ZnL/1E+0kWG8+i iua2ccNDnbGg78bfE4O5uA36r5FQCvCw5QYJDz5l7ZWpbwBbCiVV9kck1fdcGNeMcK dTaJAroCrhjDg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1slWKP-009J5x-7F; Tue, 03 Sep 2024 17:24:25 +0100 Date: Tue, 03 Sep 2024 17:24:24 +0100 Message-ID: <86r0a0vh6v.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas , Will Deacon , Mark Brown Cc: Jonathan Corbet , Andrew Morton , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v12 15/39] KVM: arm64: Manage GCS access and registers for guests In-Reply-To: <20240829-arm64-gcs-v12-15-42fec947436a@kernel.org> References: <20240829-arm64-gcs-v12-0-42fec947436a@kernel.org> <20240829-arm64-gcs-v12-15-42fec947436a@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, will@kernel.org, broonie@kernel.org, corbet@lwn.net, akpm@linux-foundation.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, arnd@arndb.de, oleg@redhat.com, ebiederm@xmission.com, shuah@kernel.org, rick.p.edgecombe@intel.com, debug@rivosinc.com, ardb@kernel.org, Szabolcs.Nagy@arm.com, kees@kernel.org, hjl.tools@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, fweimer@redhat.com, brauner@kernel.org, thiago.bauermann@linaro.org, ross.burton@arm.com, yury.khrustalev@arm.com, wilco.dijkstra@arm.com, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C80D24001B X-Stat-Signature: go91za7sefedbnk6wbrwsfxbryhc5ice X-Rspam-User: X-HE-Tag: 1725380668-459701 X-HE-Meta: U2FsdGVkX1/c7j3K6WcYyGLZHZlAdlYhRfeUbFWRHJCVJc3gR1NpgR08WilxUosL+gVD381m6CYgRwzhnQlR0a8uMwtcQaS3rrEE8PyrlOdJ9ig+pqt1IWVh2mgUwaPdU1xOd30J5BSxxYFTunsTvd1dHoA+T+3S5scsGMYV5mPPby6kKts77xTlI1ksMmsEFoSxqUBpOnoCK5sYvnY/kVXKbWqoFHVIVQGnM1HFYsBrPr4Mi4WJnrcwo5xpkitkbYr6MGx0MyW4PhYhIQsf39eTUtuLui7ndyICxW0vhAr7AcCJY7nSVFIfDmGdcuRNpZ8FZydPwfnwESlpfdT7X/jV+mz7UVFJF9hwpHbPabdevOlF4ClMlEEeTCmiWhmSfacsnQqHbvzULeG8L7uARm8Ss4H/2JxsRCvaZ/4k4NVuRgCsXwAG9rTJzLGD4yHZ2bXw/HwGdVPtrfD7gfJo1g/aOnn7fqLoNGKiipGcs8udgk3GO7PZBxmux1TrKp3DQWsXzPQvnPxY9/F5Ii+WhjalF0TKGtO+Ts4Dd80tLYY8JqU8xAJiM0yjsQ+hnu6knA6dWGyy/IxiSX5yi9PS/3zUJdgIY3+SpdeW172KSBViVTU0whg/joN7rd7UTz+hqhMtbuqPCfOahyVaKrmLMM8JUFL5zAT7iDEFWaayImixlNScWRZp8eIcZq8yQHw1phRDd4xb+QOpkNSpIyngH+UvrkshWvoNVnD0sjTyE5vHdk9g1pSuKhsyoDvSn4MfgtwLjNDmFW7Hhz5hBYwDwMF2tXfYgunaXeKVSvwzlr+i+KxyA8zb1u9nypmy71CJItF9AMqnnmALggMg3SHOIapl7iNZHAJ+ep0v0Ad7qyzqI2gNcaD0xtCz+UlhdD+DXo1d60kC1Eq1OwQNNxlJ2b0tE+zNejv2vcrCgRy+mFJD1Lztk8/N3HVHSNiu85ihaP1WssFyR9WYwQlJEwY 6IokE5EW z54eL9jB3S0X1NLQctCW5vYG8GTci876g1IVcwxHb0FP1FsoLsTzJsBTqwkkK6G6eY74+WRFNPNpJDRde7NjshlGSoaPK+Tc0isSCkb1UpOXePnBvuTTCECjnjxbYlTQHvezQttIejPTxD+j8/iHF7tZjbtrEMaDS++VXQ3fdHt2EHHfPUYG6sMvA/jqz5lly12+nIxz5TUirvOeO19IQSOnkjeHHCi0+lH/pgWLZ6Mey9kEuicnz+lBWaJlh1u6NZuiJ57i5GFJa6lV7IWawJM+l+cNFPHzggV7IwS36uv5YwjVSDfBHWIwJ3dIoJJiLKfCv4ulf2N8bHsQ1eKA1soF9m788Hy+uo2tSluN81k7Ucn+HzD4DVrc9Bg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 29 Aug 2024 00:27:31 +0100, Mark Brown wrote: > > GCS introduces a number of system registers for EL1 and EL0, on systems > with GCS we need to context switch them and expose them to VMMs to allow > guests to use GCS. > > In order to allow guests to use GCS we also need to configure > HCRX_EL2.GCSEn, if this is not set GCS instructions will be noops and > CHKFEAT will report GCS as disabled. Also enable fine grained traps for > access to the GCS registers by guests which do not have the feature > enabled. > > In order to allow userspace to control availability of the feature to > guests we enable writability for only ID_AA64PFR1_EL1.GCS, this is a > deliberately conservative choice to avoid errors due to oversights. > Further fields should be made writable in future. > > Reviewed-by: Thiago Jung Bauermann > Signed-off-by: Mark Brown > --- > arch/arm64/include/asm/kvm_host.h | 12 ++++++++ > arch/arm64/include/asm/vncr_mapping.h | 2 ++ > arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h | 49 ++++++++++++++++++++++++------ > arch/arm64/kvm/sys_regs.c | 27 +++++++++++++++- > 4 files changed, 79 insertions(+), 11 deletions(-) FWIW, this patch is going to conflict badly with -next, because of the "conservative" approach to dealing with ID_AA64PFR1_EL1 (thankfully, the *progressive* approach has been merged). If it gets stuck on a branch together with patch #11 (which seems to be the minimum for things to compile), I can take it independently and fix it myself. Just let me know. Thanks, M. -- Without deviation from the norm, progress is not possible.