From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB682C4167B for ; Mon, 4 Dec 2023 18:38:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41E766B02E4; Mon, 4 Dec 2023 13:38:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A75E6B02E6; Mon, 4 Dec 2023 13:38:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 221AC6B02E7; Mon, 4 Dec 2023 13:38:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0E4A66B02E4 for ; Mon, 4 Dec 2023 13:38:56 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BF7D180354 for ; Mon, 4 Dec 2023 18:38:55 +0000 (UTC) X-FDA: 81529997430.03.AD4EA4F Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf16.hostedemail.com (Postfix) with ESMTP id 6C3D3180005 for ; Mon, 4 Dec 2023 18:38:53 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=sok3OtZ7; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=T1VlFHiR; dmarc=none; spf=pass (imf16.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.26 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701715133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aGFZfyQ2WN2CydKNxY+nIAAd1dL39GKDKCTb2c27l2Y=; b=UD1TwuVR53CQeptjh3VX9MX7YgImvc/rZ8lBv8ApAqAYL8t8qze+/iCF0cJDYXiaQ1k4U/ jQN3GBVbjahoxjFF3kFpUV+xqFN+WCHN3uEuicMMJGgK5rgpNsDmXfOrnL7HE4S3Zv4Q98 aDhHlc0IuD0yrqdlTbs2Dc3d1lwcOUs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=sok3OtZ7; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=T1VlFHiR; dmarc=none; spf=pass (imf16.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.26 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701715133; a=rsa-sha256; cv=none; b=3AvYwVx80KLhvxal6Bh1e3vJ8o+N4aDtjfoJRKM4CseIMXzFVsBnfpMoyYENKYonyK6quB dgj2vplbXQcXUX3YXjlG8eSlXU/zDQqhqxnjc/WlygUHmH3xDbvzElyDV+S+a/NDGGNFyW gnOXXG1elUXDfLb1BLq0dX+v/I66S8E= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9E9895C0192; Mon, 4 Dec 2023 13:38:52 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 04 Dec 2023 13:38:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1701715132; x=1701801532; bh=aG FZfyQ2WN2CydKNxY+nIAAd1dL39GKDKCTb2c27l2Y=; b=sok3OtZ7ib25Uk88kY wQyhlPVLg7PmmROS95H8TqOdy9YpSW29JBeSUu46aQ/6PTCTv9VDEMiHE8j0GtM/ 99kSyTpbwUzfKRMHECoc9bQwfaQGoQe8pnK80sEVdEvnY+oI/iErr2EH1Y1rpXYN qxVYFoXerQGiJ93WrEWdiQrNbq1PwE0dUWv2/wG3nry1IFyIrNJjuFEBeRw/Oaic +gGxp4Q9pFlZV6XBrDtQsdqJ7DutlfSXOrQpdFDmOwX9mhOvLtSZmCwoX32sk6dZ GyvKeYUWN8BmOvkYbUO0ug5a0zwqwbAFedPvgNxLbAlGMPtdX9VQRURcl10rj05B 4DHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701715132; x=1701801532; bh=aGFZfyQ2WN2Cy dKNxY+nIAAd1dL39GKDKCTb2c27l2Y=; b=T1VlFHiRlk2SsSY/P6XBGO3wPHk+Q W+SusPnURYnbAe6nInYPjykkFjxNp5FsH8OOB9Nb4uODPgfwdMwBOoRyAfKjEZXc 2Os5LDvaC550Y7kqqqv76ACJpqf0kMR3kYnH+O1bEwmRv1osyOftWpYm0G9sm7Z/ +B9TwKob916OUzb7gwDKFT04RdvAhm9afErxz9POkEPp0wHBjq/m23wPMLol38pR PQTCjFu/PFQQ8kMhtH+ZDijbkqC+2FFO4MhxW9QHucZbJyLLq6szePbXaD8mUQGI PZKT7FsssM/XgIsPjEOM4/2vGHUJVMvsYVSg9VF159TX6E2znjgOq3hlQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudejiedguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefuthgv fhgrnhcutfhovghstghhuceoshhhrhesuggvvhhkvghrnhgvlhdrihhoqeenucggtffrrg htthgvrhhnpefhgfejveduudehvdduvefguddvffefgffhieeuudefudfhhfeijeefjeff heelvdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepshhhrhesuggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Dec 2023 13:38:50 -0500 (EST) References: <20231201210930.2651725-1-shr@devkernel.io> <20231201210930.2651725-2-shr@devkernel.io> <20231204104547.GB22019@pevik> User-agent: mu4e 1.10.3; emacs 29.1 From: Stefan Roesch To: Petr Vorel Cc: kernel-team@fb.com, david@redhat.com, oliver.sang@intel.com, linux-mm@kvack.org, ltp@lists.linux.it, liwang@redhat.com Subject: Re: [PATCH v2 1/2] mem: disable KSM smart scan for ksm tests Date: Mon, 04 Dec 2023 10:38:14 -0800 In-reply-to: <20231204104547.GB22019@pevik> Message-ID: <871qc1sthk.fsf@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Stat-Signature: b4ju8rabj5gsju8yq9zk4s7w4g3iq8pe X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6C3D3180005 X-HE-Tag: 1701715133-502060 X-HE-Meta: U2FsdGVkX195t7jcj+NhruzbkMfyNkeOtd62dd9Y5GWNAi4KXPomsd0LEYhY0fcetwndlgeFsvkYzzHBYaG5rTT96p4lic++FrfS74NpNQxi+zclkljsb3nwadf0RYfKYSXen+1zm4kIXnoIKQucqaFOc2cwkUc5vvyxcDT1cj6ZXirxZ3mgO2LjzB8sV4eH7umO31EUMUH40xagLPvccdxIFgvjQfma4T2ILbYXQd9jLN99MiSUK3bp4LsqTRuVAJS06IU3G1pzWl42fWrVue8ftq8zNqixLq1+Uq2rNa0uHKxY4UE+SOiqXeBBW5iOHK7Gq6+RXNDARGpFBJvcX1dUHTAnw3jLP6wfAlwzhiYq/pxK9XHQ4sXzFSgXblPdrEGvhdCRObohyM/nAwY+IN/h5T45+LrqYVz0G56WqiOORD8iWGfTn9JQoXiHmbMtBhwZ6nOGquqZXMrqkI2RYdxxtbDUS68+XoIvO0tbS08Uy55UEDRRyhAG62jzKmgRtxPCSp+VPjInd3ZVmQkKIWXZoPD0Du0rhm4sS9o5vqkrrdU0nAINdYzGEFbohnLJ3iOxOJG+nhn0otDtATVVxhC8PTAiH7HH4qKwsbnVGsTupxLjT4OO1CnnQdI95y1DXmB1SB1Z677WAVTwTOjCjHJx+CC3wliIV5NmQnD/rBQuCFsXARMD0hMOizXf4zueVHPqx7OfI7C2zo4QfNsYX6AOXQjcsLIL9RLf8gOGLcJfzCFiKyvrmQ9+omDlg69pXeHjimWccDul+gfra3AI0Vi+SvFacpFP6iVGK+OurMG4aFoD0KSkLPhAFOQzN4EliWWP64R10HNU5ShEbLzhbF1GOYpZpQ2+d3oB8MZJJFfYeEBIeyME4lAfSkXajnQADqML8yjfbpUu+WSC1VLr6DX2mUOOv+KRAu09JpiGzX0NAoVKsWQMOi0DE+xg4MF1Nxuq6bC9qJH7RZ7fpBn i5kXTHax jnSVxH6uoLHbUySP0NxVQ+Kps+ZGLcPDNw6anwFDiU8kXQ9rGMg5InywXUK8J7HSfzPCnQfBpNkFyrLKntDF7oiQI9COAY0LtMH50oBuWbz+NB8ow+jMbHRxwC4Y8cYKXvee6W1SqkgI/fr7/zxf4yl07PZ1CRvJTq4GXOhKya/yzLoUiEPNwQwGpcn90hLpuVHulXgNMUQCXwqBQYkb7wxPPFv0L521FYOgAgb3eSuN6SnoEkY0ii3ZjibpACKx5WiPyoAzhj70e9v78E9ANvaOQQY9bovyrs669KVu3Itt1flUcUb8fhAykkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Petr Vorel writes: > Hi Stefan, > >> This disables the "smart scan" KSM feature to make sure that the volatile >> count remains at 0. > >> Signed-off-by: Stefan Roesch > >> Reported-by: kernel test robot >> Closes: https://lore.kernel.org/oe-lkp/202311161132.13d8ce5a-oliver.sang@intel.com >> --- >> testcases/kernel/mem/ksm/ksm01.c | 2 ++ >> testcases/kernel/mem/ksm/ksm02.c | 2 ++ >> testcases/kernel/mem/ksm/ksm03.c | 2 ++ >> testcases/kernel/mem/ksm/ksm04.c | 2 ++ > Li suggested in v1, that also ksm0[56].c should disable smart_scan (ksm05.c is > questionable, but since you prepared ksm07 it can IMHO be disable in both ksm0[56].c). > > https://lore.kernel.org/ltp/CAEemH2fqamX720diM1N+iN9a8HM30_5sHg8V0EMHgHdrh3iZPw@mail.gmail.com/ > > With that, you can add: > Reviewed-by: Petr Vorel > > Kind regards, > Petr The next version will also disable smart scan for ksm05 and ksm06