From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Kiper <daniel.kiper@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Tang Chen <tangchen@cn.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Xishi Qiu <qiuxishi@huawei.com>,
Mel Gorman <mgorman@techsingularity.net>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Igor Mammedov <imammedo@redhat.com>, Kay Sievers <kay@vrfy.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v2] memory-hotplug: add automatic onlining policy for the newly added memory
Date: Mon, 04 Jan 2016 15:28:12 +0100 [thread overview]
Message-ID: <871t9xto5f.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <568A560A.80906@citrix.com> (David Vrabel's message of "Mon, 4 Jan 2016 11:22:50 +0000")
David Vrabel <david.vrabel@citrix.com> writes:
> On 22/12/15 16:32, Vitaly Kuznetsov wrote:
>> @@ -1292,6 +1304,11 @@ int __ref add_memory_resource(int nid, struct resource *res)
>> /* create new memmap entry */
>> firmware_map_add_hotplug(start, start + size, "System RAM");
>>
>> + /* online pages if requested */
>> + if (online)
>> + online_pages(start >> PAGE_SHIFT, size >> PAGE_SHIFT,
>> + MMOP_ONLINE_KEEP);
>
> This will cause the Xen balloon driver to deadlock because it calls
> add_memory_resource() with the balloon_mutex locked and the online page
> callback also locks the balloon_mutex.
Currently xen ballon driver always calls add_memory_resource() with
online=false so this won't happen.
--
Vitaly
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-01-04 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 16:32 [PATCH v2] memory-hotplug: add automatic onlining policy for the newly added memory Vitaly Kuznetsov
2015-12-22 21:55 ` Andrew Morton
2015-12-22 22:26 ` David Rientjes
2016-01-04 10:47 ` Vitaly Kuznetsov
2016-01-04 12:30 ` Igor Mammedov
2016-01-04 11:22 ` David Vrabel
2016-01-04 14:28 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871t9xto5f.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=gregkh@linuxfoundation.org \
--cc=imammedo@redhat.com \
--cc=kay@vrfy.org \
--cc=konrad.wilk@oracle.com \
--cc=kys@microsoft.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=qiuxishi@huawei.com \
--cc=rientjes@google.com \
--cc=tangchen@cn.fujitsu.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox