From: Kalle Valo <kvalo@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Carl Huang <quic_cjhuang@quicinc.com>,
lkp@intel.com, kbuild@lists.01.org, kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
ath11k@lists.infradead.org, Wen Gong <quic_wgong@quicinc.com>
Subject: Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.
Date: Fri, 06 May 2022 11:46:43 +0300 [thread overview]
Message-ID: <8735hn9hfw.fsf@kernel.org> (raw)
In-Reply-To: <20220505055817.GQ4031@kadam> (Dan Carpenter's message of "Thu, 5 May 2022 08:58:17 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote:
>> Hi Kalle,
>>
>> Is the below the same fix that you have already applied to ath.git?
>>
>> [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() -
>> Patchwork (kernel.org)
>> <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/
>> >
>
> That looks good. It's sort of annoying for me to send a bug report a
> month after the fix has been applied... Sorry about that.
My ath.git tree is not included in linux-wireless builds so there's also
a delay before linux-next sees the fix.
> 1) These are kbuild warnings. The zero day bot generates the
> warnings and I look them over and hit send. I don't know why the kbuild
> bot seems to get confused by -mm. The subject says 408/8237 which is
> pretty crazy. Maybe I should just ignore the -mm patches?
Yeah, I have been also wondering about using -mm for ath11k reports.
Does anyone know why that's happening?
> 2) The blamed patch came from a git tree but it had a Link tag to
> lore.kernel.org so we could have used that as an In-Reply-to tag.
> In an ideal world, all the bug reports for a patch would go to a
> standard location.
>
> Link:
> https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com
Yeah, that would be nice.
> 3) Another idea is that the kbuild bot could search lore for Fixes to
> the original commit and include links to those threads?
Yeah. Also searching for all references to the commit id from git log
would be nice.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-05-06 8:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 8:46 [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex' Dan Carpenter
2022-05-04 16:23 ` Kalle Valo
2022-05-05 1:29 ` Carl Huang
2022-05-05 5:58 ` Dan Carpenter
2022-05-06 8:46 ` Kalle Valo [this message]
2022-05-06 9:58 ` [kbuild-all] " Chen, Rong A
2022-05-06 10:24 ` Dan Carpenter
2022-05-06 13:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735hn9hfw.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=quic_cjhuang@quicinc.com \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).