From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA7FBC4167B for ; Tue, 5 Dec 2023 12:26:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F049E6B007D; Tue, 5 Dec 2023 07:26:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB6726B0080; Tue, 5 Dec 2023 07:26:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D56496B0082; Tue, 5 Dec 2023 07:26:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C53126B007D for ; Tue, 5 Dec 2023 07:26:57 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 705C8C0198 for ; Tue, 5 Dec 2023 12:26:57 +0000 (UTC) X-FDA: 81532688874.03.78ACA37 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 04EA980022 for ; Tue, 5 Dec 2023 12:26:54 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cR++U4cK; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701779215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aRJJ7WemOgSJ/YKJxC2Of+DlQT2AvNtfSGJVPMHu4Qk=; b=uKwRQPuxd8bBZbgaj4jvyOFzUSEETgczCQOrs9voovmxv2mWj7SL+ihO+djxW7OXDHLy+y TmjSHftuum/q5RS+gionomFuPSANovRrfQR1eu+M577cp9BobSh9/nc2BsoIq6WUqFuv86 /JyOijKy/B0W8iP88rbwSZgK4/a4pDg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cR++U4cK; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701779215; a=rsa-sha256; cv=none; b=h8bXv2A/gGDpXTzhjXmR+ipyd37Y3lO8gt97Z4dkZBehegXug/04KzrAOQ0VFLCqwZHPJU bvlvi8aVRjCOKtu9XgV9MUEdwkRfZ7MN6JKRLoS9p/QKdtjw47zS6zch9TlLk8nmMeRCmH 28q7nSDi9q6pYxwyfaGP5gUNohSgTZ0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701779214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aRJJ7WemOgSJ/YKJxC2Of+DlQT2AvNtfSGJVPMHu4Qk=; b=cR++U4cKBKAPNxv8Calyd25cbRpfPDKO0HafhiW5I3ttYWF+HmiIqfcB7AGB2RKJJS7Xqc i5liGwrEKORKi+qMvtJrIcGgS1QL9gqHdvr9ZOgSjpfsvBOc9ucJAsvfa7uJZav0PWppGD ctCdHsPd3rUx0kIOZAKH1aOOi3DJraM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-N4pmIc7wMqakredrB392-A-1; Tue, 05 Dec 2023 07:26:53 -0500 X-MC-Unique: N4pmIc7wMqakredrB392-A-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-333503fd5bdso1222012f8f.3 for ; Tue, 05 Dec 2023 04:26:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701779212; x=1702384012; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aRJJ7WemOgSJ/YKJxC2Of+DlQT2AvNtfSGJVPMHu4Qk=; b=JCT2FN0VR66ylCyTTQKGK4n2WyuERyMCjVkgXJQ2GyTHxnNgjHHi6JDWSmZ4RLgsoE qT8l7jx2KPVGvVc3eNpapZVwr/TWefMn4j2Mhhncu2ilvqlMYCUTjCFa6QiH4J/hhcOD 90PDPA1pSzAGWd0h2zG3ZRfNzLL00FeM6kWfiroY1eTJVA1UiIPGkccUECsj32BW0ztP KOXl7nA+8kWtRDAAcbYbdTPmY+grzvGF9bIpz7QNP4DoxC9NC2R+xHJN6gy4PhmmTNIo pHli7pq8AxxgfIgZjrs2Y34HV6gofvbEv/TeaJS/X8KMwE7fOrxrUAnCR3vyv+khx/Pm EhIA== X-Gm-Message-State: AOJu0Yzm+N+qTGcZ8ZsweDfoQWxRcQAx0KiGi3uXP19AGKGgHCeCs45Z /2HsKN2i/gwfw4n9Yuyf04ORae+jy82PBwZjTRDaU4xGPMg0FGx6ruMd26AsNs1dfg9TRx27yjB 7E9/Aq+obr7Q= X-Received: by 2002:adf:ec49:0:b0:333:2fd2:4ad6 with SMTP id w9-20020adfec49000000b003332fd24ad6mr4418261wrn.82.1701779211891; Tue, 05 Dec 2023 04:26:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IH09dPnOmOq6/dF7W10zHPUIN4xZlZcALzyxuO/bZ2wbNgxbyciYV01JtNU2vpFry2DvcCwhw== X-Received: by 2002:adf:ec49:0:b0:333:2fd2:4ad6 with SMTP id w9-20020adfec49000000b003332fd24ad6mr4418247wrn.82.1701779211519; Tue, 05 Dec 2023 04:26:51 -0800 (PST) Received: from ?IPV6:2003:cb:c72f:300:1ec7:2962:8889:ef6? (p200300cbc72f03001ec7296288890ef6.dip0.t-ipconnect.de. [2003:cb:c72f:300:1ec7:2962:8889:ef6]) by smtp.gmail.com with ESMTPSA id a10-20020a5d53ca000000b0033330ace23asm12044230wrw.73.2023.12.05.04.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 04:26:50 -0800 (PST) Message-ID: <873e12ec-c153-445c-aaa3-a68c59a01fe8@redhat.com> Date: Tue, 5 Dec 2023 13:26:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 15/39] mm/huge_memory: batch rmap operations in __split_huge_pmd_locked() To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231204142146.91437-1-david@redhat.com> <20231204142146.91437-16-david@redhat.com> <3c03d009-6a46-4321-a38b-9707b4558618@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <3c03d009-6a46-4321-a38b-9707b4558618@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 04EA980022 X-Rspam-User: X-Stat-Signature: jz368b6nba6fh6x5a6umz5r9639w7ao4 X-Rspamd-Server: rspam01 X-HE-Tag: 1701779214-518227 X-HE-Meta: U2FsdGVkX1/hhk0D49upmkZUT2Ubf+7H9qW8E0iM+2Ix8DU3ZbKEKyeqvGMUpwJ2Pc54WEFZwFzRETBbTpkcURqNAS0SYaU8WAiHHLQF7sh8u4bEiD3bZsIyt/VbkG62YJJ9VMrSuY9yhfnKpDxYbAacCHceaW4WhswPd8SYTr6RRn9mivBy1g+kEofItOLjm/9HEhh4plZ8CxeFtIUTN8d+l92yMpKpyPi+nbSFga+A30kjteqBW5JNocvMpd1/DQdN/1wAMKQzMj6STdFrl0gmUqpSt+aUP0kr2rRCruZVBb0x+GWBJlarXaKLxKKM70CqHKLWGeefPd/Wrf1GVWptWD2noMqkvCvxadAX5DO1Ff62Qxp7oHnTgTUBjPrvURlZhwuEuiiG73XxEHrLwQnI6WqyC1+m2UYHxk275k8DWvM7tbbgpbiBKbewGsCLhDRonCp7bofF4tj2R9pqQ9RLRnSO6HSaDtA749WudGdFMEPGT5Dlyxbt3pkoo6GyYcrfgod+kvB2E93B2CtaBzwDG/wTcsFbLTF7IM8SO+z11rjjk/P4C3tRWg+XOhSi8iWpQn+ErikohA5FQa5tpD+Nj/l8dDg4PL+csPBE4IozI0JkmFNAWXkD1Ldu6U14hcXOUXOdrETS9bFFOjiyE4cnHkoO/v3cGP23WxoTBMStE/Cfj3QoRrwFvRPrZWvdoDPFgBvdP4psfNWZmpQtg057GaOJ4XwFl7nA5ipVNI9Ap335aIlVfhzILJduiu4sDSqG3SIg6FPgLF12VA5LFDPhe3JbjRwyBkSwPv9NwthVxhbFPysjnD1JNEa45cmbhECcmgM0GtGzgfgCs/EPgP6OW6sZUo+EgDJliKxWhHmvbf7i++iaotUuixj0tnAUatKysOuOYJedmwWHQY2pGPPaCOp/Gy/W7wa/Ol0a2wQuKjyx5TG1hGkF8EyV7pLwOisKDfWipWDJgy+WG1C iKt/axtO 4ZJ0SnkhYiKA6qmRn9olFrYpVjiD/J+jgEWQu1fBDWEB9RZ7WNai9LmYikvGPUFrOSyys7wjkSYssXuuK9EYJ9srgZqUZtgi4N2FZaICdKKguW+J9CrfNyjABr8IDDSiR9hi3eo+q9jbI8L39Bm6OMpkcv+d1FCcw8PIFI3EV7wg/wj5SDcnwJPynOAm1/9o4WxP4SlNgzbQJATyR2ywAQes/DoR9FzyPTojyZ0F798BC/KrKUMgJFdOuWglJWauyfkpw9aV6LgI0N4Z8aeZTD1vQ9yfxSE7nHztbVWPd1tjgAsYECduVsqELBmTizH1OtcZAi8tUauYuREkliEcTgYc+dr/iB5acEicrVZRijiz5lp6WE6WeP/zn9wM1s/AfouQOgOx3PKf0xe4JTDARsVWesRsGHvlM17J8ABa0Y66BLtlf8e4P4zKYBJFg3/9JeNhMbFYUSw6dU+0P//7nACsL2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.12.23 13:22, Ryan Roberts wrote: > On 04/12/2023 14:21, David Hildenbrand wrote: >> Let's use folio_add_anon_rmap_ptes(), batching the rmap operations. >> >> While at it, use more folio operations (but only in the code branch we're >> touching), use VM_WARN_ON_FOLIO(), and pass RMAP_COMPOUND instead of > > You mean RMAP_EXCLUSIVE? Indeed. [...] >> - if (!freeze) >> - page_ref_add(page, HPAGE_PMD_NR - 1); >> + if (!freeze) { >> + rmap_t rmap_flags = RMAP_NONE; >> + >> + folio_ref_add(folio, HPAGE_PMD_NR - 1); >> + if (anon_exclusive) >> + rmap_flags = RMAP_EXCLUSIVE; > > nit: I'd be inclined to make this |= since you're accumulating optional falgs. > Yes, its the only one so it still works as is... Make sense! -- Cheers, David / dhildenb