From: Thomas Gleixner <tglx@kernel.org>
To: David Laight <david.laight.linux@gmail.com>,
Thorsten Blum <thorsten.blum@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Andy Lutomirski <luto@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Kees Cook <kees@kernel.org>, Andy Shevchenko <andy@kernel.org>,
Yury Norov <yury.norov@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] vdso: move offset_in_page() from linux/mm.h to vdso/page.h
Date: Thu, 21 May 2026 13:45:22 +0200 [thread overview]
Message-ID: <875x4hvve5.ffs@tglx> (raw)
In-Reply-To: <20260521103029.561d5c02@pumpkin>
On Thu, May 21 2026 at 10:30, David Laight wrote:
> On Thu, 21 May 2026 11:06:57 +0200
> Thorsten Blum <thorsten.blum@linux.dev> wrote:
>> +#include <vdso/page.h>
>
> That is already picked up otherwise PAGE_MASK would be undefined.
>
> The whole vdso headers is a mess.
> I moved one of the definitions (to do with bitmasks) back into its main header.
> The vdso compiled fine because all the 'normal' kernel headers get included
> in vdso builds.
Which is just wrong and we had subtle issues due to that in the
past.
VDSO is a pure user space library and just because it compiles does not
mean it is correct.
Thanks,
tglx
next prev parent reply other threads:[~2026-05-21 11:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 9:06 [PATCH v2 0/2] mm/vdso: make offset_in_page() usable without linux/mm.h Thorsten Blum
2026-05-21 9:06 ` [PATCH v2 1/2] vdso: move offset_in_page() from linux/mm.h to vdso/page.h Thorsten Blum
2026-05-21 9:30 ` David Laight
2026-05-21 11:45 ` Thomas Gleixner [this message]
2026-05-21 11:15 ` Lorenzo Stoakes
2026-05-21 14:56 ` Lorenzo Stoakes
2026-05-21 18:34 ` Andy Shevchenko
2026-05-22 10:52 ` Lorenzo Stoakes
2026-05-22 12:18 ` Thorsten Blum
2026-05-21 14:03 ` Yury Norov
2026-05-21 9:06 ` [PATCH v2 2/2] string: use offset_in_page() in sized_strscpy() Thorsten Blum
2026-05-21 11:31 ` Lorenzo Stoakes
2026-05-21 13:47 ` Thorsten Blum
2026-05-21 14:53 ` Lorenzo Stoakes
2026-05-21 11:33 ` [PATCH v2 0/2] mm/vdso: make offset_in_page() usable without linux/mm.h Lorenzo Stoakes
2026-05-21 13:59 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x4hvve5.ffs@tglx \
--to=tglx@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=david@kernel.org \
--cc=kees@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=luto@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=thorsten.blum@linux.dev \
--cc=vbabka@kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox