linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Tal Zussman <tz2294@columbia.edu>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Ingo Molnar <mingo@kernel.org>, Rik van Riel <riel@surriel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	x86@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH 1/2] x86/tlb/trace: Export the TLB_REMOTE_WRONG_CPU enum
Date: Wed, 28 May 2025 11:06:10 +0200	[thread overview]
Message-ID: <876f65d0-e873-4c08-b404-db89e542e7a3@redhat.com> (raw)
In-Reply-To: <20250528-tlb-trace-fix-v1-1-2e94c58f450d@columbia.edu>

On 28.05.25 07:35, Tal Zussman wrote:
> When the TLB_REMOTE_WRONG_CPU enum was introduced for the tlb_flush
> tracepoint, the enum was not exported to userspace. Add it to the
> appropriate macro definition to enable parsing by userspace tools, as
> per [0].
> 
> [0] Link: https://lore.kernel.org/all/20150403013802.220157513@goodmis.org
> 
> Fixes: 2815a56e4b72 ("x86/mm/tlb: Add tracepoint for TLB flush IPI to stale CPU")
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
> ---
>   include/trace/events/tlb.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/tlb.h b/include/trace/events/tlb.h
> index b4d8e7dc38f8..725a75720a23 100644
> --- a/include/trace/events/tlb.h
> +++ b/include/trace/events/tlb.h
> @@ -13,7 +13,8 @@
>   	EM(  TLB_REMOTE_SHOOTDOWN,	"remote shootdown" )		\
>   	EM(  TLB_LOCAL_SHOOTDOWN,	"local shootdown" )		\
>   	EM(  TLB_LOCAL_MM_SHOOTDOWN,	"local mm shootdown" )		\
> -	EMe( TLB_REMOTE_SEND_IPI,	"remote ipi send" )
> +	EM(  TLB_REMOTE_SEND_IPI,	"remote ipi send" )		\
> +	EMe( TLB_REMOTE_WRONG_CPU,	"remote wrong CPU" )

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb



  reply	other threads:[~2025-05-28  9:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-28  5:35 [PATCH 0/2] x86, mm: minor tlb_flush tracepoint adjustments Tal Zussman
2025-05-28  5:35 ` [PATCH 1/2] x86/tlb/trace: Export the TLB_REMOTE_WRONG_CPU enum Tal Zussman
2025-05-28  9:06   ` David Hildenbrand [this message]
2025-06-02 16:52     ` Steven Rostedt
2025-05-28 14:25   ` Rik van Riel
2025-05-28  5:35 ` [PATCH 2/2] mm: Remove tlb_flush_reason::NR_TLB_FLUSH_REASONS Tal Zussman
2025-05-28  9:06   ` David Hildenbrand
2025-05-28 14:26   ` Rik van Riel
2025-05-28  9:09 ` [PATCH 0/2] x86, mm: minor tlb_flush tracepoint adjustments David Hildenbrand
2025-06-03 22:52   ` Tal Zussman
2025-06-17 20:43 ` Tal Zussman
2025-08-04  9:15   ` Tal Zussman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=876f65d0-e873-4c08-b404-db89e542e7a3@redhat.com \
    --to=david@redhat.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mhocko@suse.com \
    --cc=mingo@kernel.org \
    --cc=riel@surriel.com \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=tz2294@columbia.edu \
    --cc=vbabka@suse.cz \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).