[PATCH 0/2] x86, mm: minor tlb_flush tracepoint adjustments

[PATCH 0/2] x86, mm: minor tlb_flush tracepoint adjustments

[Tal Zussman]

One minor fix and one minor cleanup related to the tlb_flush tracepoint.

As an aside, include/trace/events/tlb.h isn't covered by MAINTAINERS,
along with other mm related files under include/trace/events/. Flagging
this since I see there's a recent effort to overhaul the mm MAINTAINERS
entries.

It's been a while since I've submitted patches to the mailing list --
please let me know if anything looks off. Thanks!

Signed-off-by: Tal Zussman <tz2294@columbia.edu>
---
Tal Zussman (2):
      x86/tlb/trace: Export the TLB_REMOTE_WRONG_CPU enum
      mm: Remove tlb_flush_reason::NR_TLB_FLUSH_REASONS

 include/linux/mm_types.h   | 1 -
 include/trace/events/tlb.h | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
base-commit: 200577f69f29a58c90c67c83a0df6d12850e1d09
change-id: 20250528-tlb-trace-fix-eb9b6fc7bb26

Best regards,
-- 
Tal Zussman <tz2294@columbia.edu>

[PATCH 1/2] x86/tlb/trace: Export the TLB_REMOTE_WRONG_CPU enum

[Tal Zussman]

When the TLB_REMOTE_WRONG_CPU enum was introduced for the tlb_flush
tracepoint, the enum was not exported to userspace. Add it to the
appropriate macro definition to enable parsing by userspace tools, as
per [0].

[0] Link: https://lore.kernel.org/all/20150403013802.220157513@goodmis.org

Fixes: 2815a56e4b72 ("x86/mm/tlb: Add tracepoint for TLB flush IPI to stale CPU")
Signed-off-by: Tal Zussman <tz2294@columbia.edu>
---
 include/trace/events/tlb.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/trace/events/tlb.h b/include/trace/events/tlb.h
index b4d8e7dc38f8..725a75720a23 100644
--- a/include/trace/events/tlb.h
+++ b/include/trace/events/tlb.h
@@ -13,7 +13,8 @@
 	EM(  TLB_REMOTE_SHOOTDOWN,	"remote shootdown" )		\
 	EM(  TLB_LOCAL_SHOOTDOWN,	"local shootdown" )		\
 	EM(  TLB_LOCAL_MM_SHOOTDOWN,	"local mm shootdown" )		\
-	EMe( TLB_REMOTE_SEND_IPI,	"remote ipi send" )
+	EM(  TLB_REMOTE_SEND_IPI,	"remote ipi send" )		\
+	EMe( TLB_REMOTE_WRONG_CPU,	"remote wrong CPU" )
 
 /*
  * First define the enums in TLB_FLUSH_REASON to be exported to userspace

-- 
2.39.5

Re: [PATCH 1/2] x86/tlb/trace: Export the TLB_REMOTE_WRONG_CPU enum

[David Hildenbrand]

On 28.05.25 07:35, Tal Zussman wrote:
> When the TLB_REMOTE_WRONG_CPU enum was introduced for the tlb_flush
> tracepoint, the enum was not exported to userspace. Add it to the
> appropriate macro definition to enable parsing by userspace tools, as
> per [0].
> 
> [0] Link: https://lore.kernel.org/all/20150403013802.220157513@goodmis.org
> 
> Fixes: 2815a56e4b72 ("x86/mm/tlb: Add tracepoint for TLB flush IPI to stale CPU")
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
> ---
>   include/trace/events/tlb.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/tlb.h b/include/trace/events/tlb.h
> index b4d8e7dc38f8..725a75720a23 100644
> --- a/include/trace/events/tlb.h
> +++ b/include/trace/events/tlb.h
> @@ -13,7 +13,8 @@
>   	EM(  TLB_REMOTE_SHOOTDOWN,	"remote shootdown" )		\
>   	EM(  TLB_LOCAL_SHOOTDOWN,	"local shootdown" )		\
>   	EM(  TLB_LOCAL_MM_SHOOTDOWN,	"local mm shootdown" )		\
> -	EMe( TLB_REMOTE_SEND_IPI,	"remote ipi send" )
> +	EM(  TLB_REMOTE_SEND_IPI,	"remote ipi send" )		\
> +	EMe( TLB_REMOTE_WRONG_CPU,	"remote wrong CPU" )

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb

Re: [PATCH 1/2] x86/tlb/trace: Export the TLB_REMOTE_WRONG_CPU enum

[Steven Rostedt]

On Wed, 28 May 2025 11:06:10 +0200
David Hildenbrand <david@redhat.com> wrote:

> > diff --git a/include/trace/events/tlb.h b/include/trace/events/tlb.h
> > index b4d8e7dc38f8..725a75720a23 100644
> > --- a/include/trace/events/tlb.h
> > +++ b/include/trace/events/tlb.h
> > @@ -13,7 +13,8 @@
> >   	EM(  TLB_REMOTE_SHOOTDOWN,	"remote shootdown" )		\
> >   	EM(  TLB_LOCAL_SHOOTDOWN,	"local shootdown" )		\
> >   	EM(  TLB_LOCAL_MM_SHOOTDOWN,	"local mm shootdown" )		\
> > -	EMe( TLB_REMOTE_SEND_IPI,	"remote ipi send" )
> > +	EM(  TLB_REMOTE_SEND_IPI,	"remote ipi send" )		\
> > +	EMe( TLB_REMOTE_WRONG_CPU,	"remote wrong CPU" )  
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

I'm guessing this will go through the mm tree?

-- Steve

Re: [PATCH 1/2] x86/tlb/trace: Export the TLB_REMOTE_WRONG_CPU enum

[Rik van Riel]

On Wed, 2025-05-28 at 01:35 -0400, Tal Zussman wrote:
> When the TLB_REMOTE_WRONG_CPU enum was introduced for the tlb_flush
> tracepoint, the enum was not exported to userspace. Add it to the
> appropriate macro definition to enable parsing by userspace tools, as
> per [0].
> 
> [0] Link:
> https://lore.kernel.org/all/20150403013802.220157513@goodmis.org
> 
> Fixes: 2815a56e4b72 ("x86/mm/tlb: Add tracepoint for TLB flush IPI to
> stale CPU")
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>

Good catch. Thank you!

Reviewed-by: Rik van Riel <riel@surriel.com>

-- 
All Rights Reversed.

[PATCH 2/2] mm: Remove tlb_flush_reason::NR_TLB_FLUSH_REASONS

[Tal Zussman]

This has been unused since it was added 11 years ago in commit
d17d8f9dedb9 ("x86/mm: Add tracepoints for TLB flushes").

Signed-off-by: Tal Zussman <tz2294@columbia.edu>
---
 include/linux/mm_types.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index 3e934dc6057c..8b91362fcf8e 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -1539,7 +1539,6 @@ enum tlb_flush_reason {
 	TLB_LOCAL_MM_SHOOTDOWN,
 	TLB_REMOTE_SEND_IPI,
 	TLB_REMOTE_WRONG_CPU,
-	NR_TLB_FLUSH_REASONS,
 };
 
 /**

-- 
2.39.5

Re: [PATCH 2/2] mm: Remove tlb_flush_reason::NR_TLB_FLUSH_REASONS

[David Hildenbrand]

On 28.05.25 07:35, Tal Zussman wrote:
> This has been unused since it was added 11 years ago in commit
> d17d8f9dedb9 ("x86/mm: Add tracepoints for TLB flushes").
> 
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
> ---
>   include/linux/mm_types.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> index 3e934dc6057c..8b91362fcf8e 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -1539,7 +1539,6 @@ enum tlb_flush_reason {
>   	TLB_LOCAL_MM_SHOOTDOWN,
>   	TLB_REMOTE_SEND_IPI,
>   	TLB_REMOTE_WRONG_CPU,
> -	NR_TLB_FLUSH_REASONS,
>   };
>   
>   /**
> 


Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb

Re: [PATCH 2/2] mm: Remove tlb_flush_reason::NR_TLB_FLUSH_REASONS

[Rik van Riel]

On Wed, 2025-05-28 at 01:35 -0400, Tal Zussman wrote:
> This has been unused since it was added 11 years ago in commit
> d17d8f9dedb9 ("x86/mm: Add tracepoints for TLB flushes").
> 
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
> 
Reviewed-by: Rik van Riel <riel@surriel.com>


-- 
All Rights Reversed.

Re: [PATCH 0/2] x86, mm: minor tlb_flush tracepoint adjustments

[David Hildenbrand]

On 28.05.25 07:35, Tal Zussman wrote:
> One minor fix and one minor cleanup related to the tlb_flush tracepoint.
> 
> As an aside, include/trace/events/tlb.h isn't covered by MAINTAINERS,
> along with other mm related files under include/trace/events/. Flagging
> this since I see there's a recent effort to overhaul the mm MAINTAINERS
> entries.

Thanks for pointing that out.

It should likely go under "MMU GATHER AND TLB INVALIDATION"

diff --git a/MAINTAINERS b/MAINTAINERS
index 0ecc6063b2b5e..0e88ea5de5b73 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16509,6 +16509,7 @@ L:      linux-mm@kvack.org
  S:     Maintained
  F:     arch/*/include/asm/tlb.h
  F:     include/asm-generic/tlb.h
+F:     include/trace/events/tlb.h
  F:     mm/mmu_gather.c

  MN88472 MEDIA DRIVER


-- 
Cheers,

David / dhildenb

Re: [PATCH 0/2] x86, mm: minor tlb_flush tracepoint adjustments

[Tal Zussman]

Sent a patch here:
https://lore.kernel.org/linux-mm/20250603-tlb-maintainers-v1-1-726d193c6693@columbia.edu/

Thanks!

On Wed, May 28, 2025 at 5:09 AM David Hildenbrand <david@redhat.com> wrote:
>
> On 28. 05. 25 07: 35, Tal Zussman wrote: > One minor fix and one minor cleanup related to the tlb_flush tracepoint. > > As an aside, include/trace/events/tlb. h isn't covered by MAINTAINERS, > along with other mm related files under
> ZjQcmQRYFpfptBannerStart
> This Message Is From an External Sender
> This message came from outside your organization.
>
> ZjQcmQRYFpfptBannerEnd
>
> On 28.05.25 07:35, Tal Zussman wrote:
> > One minor fix and one minor cleanup related to the tlb_flush tracepoint.
> >
> > As an aside, include/trace/events/tlb.h isn't covered by MAINTAINERS,
> > along with other mm related files under include/trace/events/. Flagging
> > this since I see there's a recent effort to overhaul the mm MAINTAINERS
> > entries.
>
> Thanks for pointing that out.
>
> It should likely go under "MMU GATHER AND TLB INVALIDATION"
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0ecc6063b2b5e..0e88ea5de5b73 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16509,6 +16509,7 @@ L:      linux-mm@kvack.org
>   S:     Maintained
>   F:     arch/*/include/asm/tlb.h
>   F:     include/asm-generic/tlb.h
> +F:     include/trace/events/tlb.h
>   F:     mm/mmu_gather.c
>
>   MN88472 MEDIA DRIVER
>
>
> --
> Cheers,
>
> David / dhildenb
>

Re: [PATCH 0/2] x86, mm: minor tlb_flush tracepoint adjustments

[Tal Zussman]

On Wed, May 28, 2025 at 1:35 AM Tal Zussman <tz2294@columbia.edu> wrote:
>
> One minor fix and one minor cleanup related to the tlb_flush tracepoint.
>
> As an aside, include/trace/events/tlb.h isn't covered by MAINTAINERS,
> along with other mm related files under include/trace/events/. Flagging
> this since I see there's a recent effort to overhaul the mm MAINTAINERS
> entries.
>
> It's been a while since I've submitted patches to the mailing list --
> please let me know if anything looks off. Thanks!

I don't see this series in any of the mm trees -- anything else that needs to be
done to get this in?

Thanks,
Tal

Re: [PATCH 0/2] x86, mm: minor tlb_flush tracepoint adjustments

[Tal Zussman]

Hi Andrew,

On Tue, Jun 17, 2025 at 11:43 PM Tal Zussman <tz2294@columbia.edu> wrote:
>
> On Wed, May 28, 2025 at 1:35 AM Tal Zussman <tz2294@columbia.edu> wrote:
> >
> > One minor fix and one minor cleanup related to the tlb_flush tracepoint.
> >
> > As an aside, include/trace/events/tlb.h isn't covered by MAINTAINERS,
> > along with other mm related files under include/trace/events/. Flagging
> > this since I see there's a recent effort to overhaul the mm MAINTAINERS
> > entries.
> >
> > It's been a while since I've submitted patches to the mailing list --
> > please let me know if anything looks off. Thanks!
>
> I don't see this series in any of the mm trees -- anything else that needs to be
> done to get this in?

Just wanted to follow up on this, as it seems like this series missed the
-mm branches for 6.17.

Thanks,
Tal