From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E38DCFC274 for ; Tue, 15 Oct 2024 08:22:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DB386B0088; Tue, 15 Oct 2024 04:22:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88C4D6B008A; Tue, 15 Oct 2024 04:22:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 752AE6B008C; Tue, 15 Oct 2024 04:22:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 576656B0088 for ; Tue, 15 Oct 2024 04:22:23 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 690641C6AAC for ; Tue, 15 Oct 2024 08:22:13 +0000 (UTC) X-FDA: 82675144356.22.80B13E9 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf19.hostedemail.com (Postfix) with ESMTP id 37B1C1A000B for ; Tue, 15 Oct 2024 08:22:12 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BkFV7djM; spf=pass (imf19.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728980399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gSbjcDDQQ4bzhuGeYvy25HeVmQJUWahcI9kmdF2A54o=; b=ritq9MGe4XVTbWvrI8GVtlcQqRn6HOm+3JbENDAgWc9x79S6D+J4gYQuBOyUeY0Y9Ns3zd rLkbcUkQ5Af4tsANtEHQ2q+WoPkDoFyXQXtkZdiz9mZtK1LtnuyWqXNMQ5qnCj63T/3Kcb +L4utAiGCykvnR49FBApDsRlsOjgv0Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728980399; a=rsa-sha256; cv=none; b=JnsZQUWNApdex/J+6lvhQTRrS0edOFoJ84IADtwbvJpOVjnns/ReeWKw3jOKcf1rL+TIzZ yuIDrB0AStejltjxtCMx0/z4ZuDXj6HxZALHFvus6nQ0Nx9KF6j6sSszRpciqMTDVH6TOY 5rk6uzvPpoPoXuf4+x95VZypvJp83go= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BkFV7djM; spf=pass (imf19.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20ce65c8e13so15967065ad.1 for ; Tue, 15 Oct 2024 01:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728980540; x=1729585340; darn=kvack.org; h=content-transfer-encoding:mime-version:references:message-id:date :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=gSbjcDDQQ4bzhuGeYvy25HeVmQJUWahcI9kmdF2A54o=; b=BkFV7djMBAxU30Pcsq6o3qWzu0gP8oU6yX/oeZilBmpYraV5AfhYGV5WdHI+X4Ejld BXES85rFWCquZxL6/UwNYuiqfezO8MmghLLBrNNidh+I7FfQnRvZR7Ks1Ftl531wG1jL y/F/YsugDGkAHQc06RXpYYy7wzdSIhApGck2Wdf1iMEcqx0GNVKkaF8cJq0Ax5FUTQ9H qWaX+KwKsY3AQ+MaFHqsawwICwW/zJkMdoqptyFoIAiRvDkXJjqtAJN934nM+5Fvsv/V mOM82KOD2AUXg898uFfs3NRoclG4wbFSWyoXgdzY5DONW0aegdg4WGOEMK4NvVH12zYu HfHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728980540; x=1729585340; h=content-transfer-encoding:mime-version:references:message-id:date :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gSbjcDDQQ4bzhuGeYvy25HeVmQJUWahcI9kmdF2A54o=; b=GKZvunZ8aWInjGBLilcII2OJIUa3DUKYT5lF6lZqUd+qUjU6bz91mxTXWdh0B333AL SezGer2/qf44kP87n5Bma2t1BqYJEi6sHR0h4I78eQ8d294O5If8Khc7uf7r6UiDbsOt J1I7xQtbbrTd7GGWbyi9/3PndOCJjSTMR72friVG1+9WwHx3UgkdHt8G/vaTf7SiXIKJ bBE3F1v8zpQrd7si27iuLTf6cm/ej/LGYzhVaizRO36zu5wgzUMcNlcR5cLfpkYowqEO 6LIUaDSRuMbBtSpiSgFeC/7CoJ4wH1e6Omw12kqvUtrTyy8PIiPBaiIMA/UZGLhEWUTE IdDQ== X-Forwarded-Encrypted: i=1; AJvYcCUCYFvJDedeYfmDPbIbJhLGyeBsSFeV2dMv0xfYd3IEFYSc01y4YBR7ey3QGKSrjpwO28lGVTwwTQ==@kvack.org X-Gm-Message-State: AOJu0Yx3ZPkuQaRzpfHag8R741s28MWeYDL6ZoSXBy37M7WjV63EHbaA 21uA27R9C7y6jjfqvlZCyezf8YRX9/UGUu+9Fov9HuexFE/g5M6O X-Google-Smtp-Source: AGHT+IHa2gX9C4jAt0fiNSJu1J2m6zAiD1t3r4LEmOIsmYCZ5gXCIMP/YN4CTViiCc9odAQA4YjWww== X-Received: by 2002:a17:902:e5ca:b0:20c:805a:524 with SMTP id d9443c01a7336-20ca16be1b7mr170171755ad.39.1728980539523; Tue, 15 Oct 2024 01:22:19 -0700 (PDT) Received: from dw-tp ([171.76.80.151]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d17fa48b9sm7087565ad.85.2024.10.15.01.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 01:22:18 -0700 (PDT) From: Ritesh Harjani (IBM) To: Christophe Leroy , linuxppc-dev@lists.ozlabs.org Cc: kasan-dev@googlegroups.com, linux-mm@kvack.org, Marco Elver , Alexander Potapenko , Heiko Carstens , Michael Ellerman , Nicholas Piggin , Madhavan Srinivasan , Hari Bathini , "Aneesh Kumar K . V" , Donet Tom , Pavithra Prakash , LKML , Disha Goel Subject: Re: [RFC RESEND v2 02/13] powerpc: mm: Fix kfence page fault reporting In-Reply-To: <660a2cf7-24f9-4558-87df-5e4c13362380@csgroup.eu> Date: Tue, 15 Oct 2024 13:49:46 +0530 Message-ID: <877ca9zskd.fsf@gmail.com> References: <6bf523aa03e72d701d24aca49b51864331eed2d5.1728954719.git.ritesh.list@gmail.com> <660a2cf7-24f9-4558-87df-5e4c13362380@csgroup.eu> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 37B1C1A000B X-Stat-Signature: uax1ftczxrpbok9egfkojtz9jufekzmy X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728980532-409125 X-HE-Meta: U2FsdGVkX19tyvN+xuO30StdEplrnKpFOOXgf2B2cyL0L2t5cJRulQ2LuK4V5SxcFe9OrElGtutzqUPHM1r0W5IGzoNG0j6/i/TrhZE/VIR2MHsRfpq40wHwiiqZet6SiKvBodELce6r0chl/Um/ulpzCIzVk47VEwlCgyr5meoqhC56Rnii7lu5PyThP6Q2WrUVZ0akfrjBoyCbjhD3jNTMEAZLqqAu/qV6eJN9PTYRqXUvYP4ea/0DWe0/oN5xEv8dPQ9GueZD6sJC1hB20uAvwl3q1/qVipSEDMuIOrQlBmKTc7E8CWmXxQoMFBQ40kTofBPN1kLEXqZ94BtiRdjDld0jgz5KVgDIqt1s8MswatJQS2GKS+dCZ7wxOf4wvvjviME69mlGJgUCDv6IL7Ad2iRPBte0fikBoBh12zN/sDUeeDCKNqvcFt2GxTAU/xBo7+wz+hddVG4lGzOa4vuVFPBcJ6Fv4n0DPeFFhzrfB3DZ7vdbYRoNJR4x/LOsCYNh2K4ieJU6YD6p/uzZ3cPtvBrFOvGgK4jEwZATZ0Mk2Rc8ihhTC51BfHlKuVWO19wPgKwNri8SoNaw7LJCZgt7eU0Ogpiv/pEbUcmu8dBN+qQxsl6zlC67Vx415u1EpyLXncxAYIzXx4taj4PwiX1VyNsXQrMtZo8dzt2ON6jQyPgO9eUbpRtmTMxUkajgTyw6MiaWDOmzvfr53CwjW1F3idXfdcptATx5Ies1GodAp3QnX4YQoK5P+BB7GapC6KNm4BgzrkXJqIE0LfZYItP8b7YXYo+6DtT/CVXrZKW8gau4el1A+KuLMaqpnmwmtPwzEvvPQSlU5p7DG2acgTWA7/ueqYpXiQo5YFhMrFok/a/UtM1tTzLe5F5UVqfFQppTD0jfGcdI4mKN2v4cEXCQZtFD13kf3kSrM7XXrjortbcizsffJ9a3CUOuuPrLZzeTtcFdUr5B6XQ16s7 PzpUXPYz nRCEf6FHimUmyrMFz2MVah9gXxlh9tDdGY3G9Ya8r7pw94ukhadZp5NvtSmUqnA7ZpnRBbF7e3YbcB8NYvNh7uLHELimABwg7EHGeqEjlWzA1d3F0naC/NLJK9x01CKrbsZN0HBgT6DnIIjGQI4wWQXVwF5CAgTf+qj2gdvIn0jXt3+WQwiZeb3IEfm4s9HH4IdFTduJrFASihDqaRkTKMjQF5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Christophe Leroy writes: > Le 15/10/2024 à 03:33, Ritesh Harjani (IBM) a écrit : >> copy_from_kernel_nofault() can be called when doing read of /proc/kcore. >> /proc/kcore can have some unmapped kfence objects which when read via >> copy_from_kernel_nofault() can cause page faults. Since *_nofault() >> functions define their own fixup table for handling fault, use that >> instead of asking kfence to handle such faults. >> >> Hence we search the exception tables for the nip which generated the >> fault. If there is an entry then we let the fixup table handler handle the >> page fault by returning an error from within ___do_page_fault(). >> >> This can be easily triggered if someone tries to do dd from /proc/kcore. >> dd if=/proc/kcore of=/dev/null bs=1M >> >> >> =============================== >> BUG: KFENCE: invalid read in copy_from_kernel_nofault+0xb0/0x1c8 >> Invalid read at 0x000000004f749d2e: >> copy_from_kernel_nofault+0xb0/0x1c8 >> 0xc0000000057f7950 >> read_kcore_iter+0x41c/0x9ac >> proc_reg_read_iter+0xe4/0x16c >> vfs_read+0x2e4/0x3b0 >> ksys_read+0x88/0x154 >> system_call_exception+0x124/0x340 >> system_call_common+0x160/0x2c4 >> >> BUG: KFENCE: use-after-free read in copy_from_kernel_nofault+0xb0/0x1c8 >> Use-after-free read at 0x000000008fbb08ad (in kfence-#0): >> copy_from_kernel_nofault+0xb0/0x1c8 >> 0xc0000000057f7950 >> read_kcore_iter+0x41c/0x9ac >> proc_reg_read_iter+0xe4/0x16c >> vfs_read+0x2e4/0x3b0 >> ksys_read+0x88/0x154 >> system_call_exception+0x124/0x340 >> system_call_common+0x160/0x2c4 >> >> Guessing the fix should go back to when we first got kfence on PPC32. >> >> Fixes: 90cbac0e995d ("powerpc: Enable KFENCE for PPC32") >> Reported-by: Disha Goel >> Signed-off-by: Ritesh Harjani (IBM) >> --- >> arch/powerpc/mm/fault.c | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c >> index 81c77ddce2e3..fa825198f29f 100644 >> --- a/arch/powerpc/mm/fault.c >> +++ b/arch/powerpc/mm/fault.c >> @@ -439,9 +439,17 @@ static int ___do_page_fault(struct pt_regs *regs, unsigned long address, >> /* >> * The kernel should never take an execute fault nor should it >> * take a page fault to a kernel address or a page fault to a user >> - * address outside of dedicated places >> + * address outside of dedicated places. >> + * >> + * Rather than kfence reporting false negatives, let the fixup table >> + * handler handle the page fault by returning SIGSEGV, if the fault >> + * has come from functions like copy_from_kernel_nofault(). >> */ >> if (unlikely(!is_user && bad_kernel_fault(regs, error_code, address, is_write))) { >> + >> + if (search_exception_tables(instruction_pointer(regs))) >> + return SIGSEGV; > > This is a heavy operation. It should at least be done only when KFENCE > is built-in. > > kfence_handle_page_fault() bails out immediately when > is_kfence_address() returns false, and is_kfence_address() returns > always false when KFENCE is not built-in. > > So you could check that before calling the heavy weight > search_exception_tables(). > > if (is_kfence_address(address) && > !search_exception_tables(instruction_pointer(regs)) && > kfence_handle_page_fault(address, is_write, regs)) > return 0; > Yes, thanks for the input. I agree with above. I will take that in v3. I will wait for sometime for any review comments on other patches before spinning a v3, though. > > > > + return SIGSEGV; > >> + >> if (kfence_handle_page_fault(address, is_write, regs)) >> return 0; >> -ritesh