From: Thomas Gleixner <tglx@linutronix.de>
To: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Keith Lucas <keith.lucas@oracle.com>,
Jeff Xu <jeffxu@chromium.org>,
"rick.p.edgecombe@intel.com" <rick.p.edgecombe@intel.com>,
Jorge Lucangeli Obes <jorgelo@chromium.org>,
Kees Cook <keescook@chromium.org>,
"sroettger@google.com" <sroettger@google.com>,
"jannh@google.com" <jannh@google.com>
Subject: Re: [PATCH v7 2/5] x86/pkeys: Add helper functions to update PKRU on the sigframe
Date: Thu, 01 Aug 2024 22:18:54 +0200 [thread overview]
Message-ID: <877cd02dzl.ffs@tglx> (raw)
In-Reply-To: <BB4AA839-1CF6-4C48-B3ED-24F9E425837D@oracle.com>
On Thu, Aug 01 2024 at 20:14, Aruna Ramakrishna wrote:
>> On Aug 1, 2024, at 1:57 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>> On Thu, Aug 01 2024 at 06:51, Aruna Ramakrishna wrote:
>>>
>>> +extern void __user *get_xsave_addr_user(struct xregs_state *xsave, int xfeature_nr);
>>
>> *xsave lacks __user
>>
> Did you get a chance to review the rest of the patchset? If you have any
> additional comments/suggestions, I can batch those fixes into v8.
I did not find anything problematic.
If you spin up a V8 you could polish your changelogs a bit and give them
some structure. They mostly consist of one big lump. See:
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog
for some examples.
Thanks,
tglx
next prev parent reply other threads:[~2024-08-01 20:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 6:51 [PATCH v7 0/5] x86/pkeys: update PKRU to enable pkey 0 before Aruna Ramakrishna
2024-08-01 6:51 ` [PATCH v7 1/5] x86/pkeys: Add PKRU as a parameter in signal handling functions Aruna Ramakrishna
2024-08-01 6:51 ` [PATCH v7 2/5] x86/pkeys: Add helper functions to update PKRU on the sigframe Aruna Ramakrishna
2024-08-01 8:57 ` Thomas Gleixner
2024-08-01 20:14 ` Aruna Ramakrishna
2024-08-01 20:18 ` Thomas Gleixner [this message]
2024-08-01 6:51 ` [PATCH v7 3/5] x86/pkeys: Update PKRU to enable all pkeys before XSAVE Aruna Ramakrishna
2024-08-01 6:51 ` [PATCH v7 4/5] x86/pkeys: Restore altstack before sigcontext Aruna Ramakrishna
2024-08-01 6:51 ` [PATCH v7 5/5] selftests/mm: Add new testcases for pkeys Aruna Ramakrishna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cd02dzl.ffs@tglx \
--to=tglx@linutronix.de \
--cc=aruna.ramakrishna@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=jannh@google.com \
--cc=jeffxu@chromium.org \
--cc=jorgelo@chromium.org \
--cc=keescook@chromium.org \
--cc=keith.lucas@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=sroettger@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).