From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA10C10F04 for ; Fri, 1 Dec 2023 20:06:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9F448D0074; Fri, 1 Dec 2023 15:06:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4FEF8D0001; Fri, 1 Dec 2023 15:06:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9185E8D0074; Fri, 1 Dec 2023 15:06:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 81BAE8D0001 for ; Fri, 1 Dec 2023 15:06:17 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4024580307 for ; Fri, 1 Dec 2023 20:06:17 +0000 (UTC) X-FDA: 81519331194.07.C611BA7 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by imf10.hostedemail.com (Postfix) with ESMTP id 21555C0014 for ; Fri, 1 Dec 2023 20:06:14 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=E09av+jX; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="mtlVJD/T"; dmarc=none; spf=pass (imf10.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.27 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701461175; a=rsa-sha256; cv=none; b=bLkSllm+gKg6mKwcrlVoovNKDXOtd8TOKdEpNmHInPACG1NSRxo4dERJsJ6trXF1ZJRd3l 0lwl4DHZwO6T9gnglXnI7FnsypxdGpl3+fyjppXygMUqbuZpNGjMCabRslPGxejRefaAo+ rCZJJ3LjUM0eSE/8hbAgJoeyGOfpkgw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=E09av+jX; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="mtlVJD/T"; dmarc=none; spf=pass (imf10.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.27 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701461175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3MpnxnJ9p0dPBD2wAv8t1shHRqUJ2V2PQWkP1HkspCo=; b=ozdnT0neh2ZgxQiKx7q32i1xoa043l3wTgMge1SI1cd6DjInaHhgNhdfB3UzlzE+yTQ/Sq 3nnqlQq200yCXT34Zdb/RYFdieZpYa8dXvIm2Bk6tMqKNxmLA1vYNgbAOsZzkhbBo21GPK fzbrtl0PH2OPl3Rydi46wBw8W88Vinw= Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3C2715C0067; Fri, 1 Dec 2023 15:06:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 01 Dec 2023 15:06:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1701461174; x=1701547574; bh=3M pnxnJ9p0dPBD2wAv8t1shHRqUJ2V2PQWkP1HkspCo=; b=E09av+jX+JsoZNWG27 8IQprqDZgcVWWb/SyxbR19/47u4cYGJp1dAwqp4Q7vE2ohrZflLFqvhqYAYwiEHA tY5FuvnStXDC0SdAfgT6iWTllZ6ZeKwwliQS8NyJNpqPSiA6sv8w/WIVpoZtdYdf +fDpjhd5yVKF99ttFaxU6NuzaXnb4UXz+XIcL96Mdunv2/BzJB1VM+V9ez7EsePp j8/Y1O8yFUup965slU/hPMnLsizGEhyKPBtzgg1pkhYqtOmWOLPg0BU0hezqNj3t zPmWXSZHUHuFvTdEGWcbVtfAtCMmKn7tuOtZivvuow6rT+Z7W9V1syV7rfTBoQ+j AarA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701461174; x=1701547574; bh=3MpnxnJ9p0dPB D2wAv8t1shHRqUJ2V2PQWkP1HkspCo=; b=mtlVJD/TKcPDDgVo4BuvO7DKBD17G OucQlT2mkYx4S8w87TMsD1dBh83o9JSapTEemex+BDWaIhA3lDURbfAgBoi2rEOS pCLbcTjMXyyHH85iDg1Js1HCdcbRSStvEWkpeiJSAds9jlAnILqnjFFOHrSfE4UK 9xaU/J6+h29ENY1ev7noYBdrIqDAUR3P9N+SiR7WHXUAlNaG2WF0hgm9FqyzxSj+ hM208Lct5/2Y9tmuWJf1JwO/+u8bgsJinCl6UJeoZrEZ9K6GpW3hwEPCdMRJsN5F RhV6a9TMuYQWbWj/++rui+MavMtfbmGY1S+0/3BymmApqai7+OOeGcaCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeiledgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefuthgv fhgrnhcutfhovghstghhuceoshhhrhesuggvvhhkvghrnhgvlhdrihhoqeenucggtffrrg htthgvrhhnpeegtedvkeegleefffeuueevjeeijefhjeelhfefheeiheeiveehveevhfej tdfhieenucffohhmrghinhepkhgvrhhnvghlrdhorhhgpdhgihhthhhusgdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehshhhrsegu vghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Dec 2023 15:06:11 -0500 (EST) References: <20231127174517.2369593-1-shr@devkernel.io> <20231128074626.GA298624@pevik> User-agent: mu4e 1.10.3; emacs 29.1 From: Stefan Roesch To: Petr Vorel Cc: kernel-team@fb.com, linux-mm@kvack.org, david@redhat.com, oliver.sang@intel.com, ltp@lists.linux.it Subject: Re: [LTP] [PATCH v1] mem: disable KSM smart scan for ksm tests Date: Fri, 01 Dec 2023 12:02:22 -0800 In-reply-to: <20231128074626.GA298624@pevik> Message-ID: <878r6d6633.fsf@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 21555C0014 X-Stat-Signature: 6i5xasiooq3a8rqd4jqrzfq11m8emdx9 X-HE-Tag: 1701461174-299403 X-HE-Meta: U2FsdGVkX1+TlYGU2q0JKWXHq3tENfDx9RnC55hv11mMJ0oazE1uRvGc9tc3U+OG8XH8ijWzpK7bKHm2v7JYNOdzqlDEHQ0l6krgFk/7giXop0GeeIv+SSpfrFGtAovIt5TZ5v3dgQKlAkcIbM+ABoOb0SRFr4aTvdY7RKZCp+X7mp3DNLeUK9FZfV/R9RnvA2VED8pLdvVDyJYttpaPeGksg9jkVUeM5psiruHNqDB526S4+074icQbrAXpZmXZ+H4ZGAU95UWszJsc0f8BlP2yFFSDPmrW5Susxed0d8158NvablonpJTnM1znqC0+BJ0SnncCLtzuwUKgquOwVDJA0ot1ZyRKKKuSWl00bhLrHsXOne8h5tjsUUe1H8lRguYd7t6Ir4pwDM3deyGdg7YN4vrk+vFBmkbnOEZYc1Ug4cLlBRICfpQJSZNMoIC6GYtWxSUDUUe+6zt0ffaUWYHKMTYvyIH+DDvA0KnXrKjayFQxD3Uo4dzWeZN+Dm0V1Pjd8iF7Q3MxUAFqOfOM1S0EcS3LIoJQtOCVX7dEktNux3BiUJOf3XuVB0q+sznCJdDSOe2g3RMVQXD1LFF+4D1rmF35APkwhYgQCZ9RX/OJR2PyXJo7kg9+u26o6d3vUHuvMkLeO94jo6B7YgUymyuGFFvkucVO+hxoBC89AS/YrrMnnA0e5FEP0qJLU0XR/JxwQEsBkVr8mF6JqJLcSNPLjrSI8wXQXc8IaGwiu3C4JmWFZ6MUoUiTwWutXhJj0HqyYteeDC4vt9bwtHbUVx8usvm+Yy0V+BTD3awkD3yr6pjUzzS7HJf8AeljILEZME62d6+uY97YW/XmQ6ZAkusYgy3li6o/ZGAOLXZG+ISOc97+l8TDrvFiJXuv2UzxiSJlshvm47dA6pkzZH88SYZhE9K32fGQ9F6xKuMLVxGXxwqR04T3bJFmty/YkoeMQKJymf4x8Umj5xDCAZz 0YHLxo3O vbOFQtbAgNh/O/+1k3jxto2AXAtJSWaxsGgoAsKj9zGCgza4pKwgMA0QqHkWSFKk126RopZ9aZT2xUDs+7L7lF+6pED3ysWfMa7E+DVi6ZnUjUiXpRcqslq7FWPOzsqBkF+0WSFSmhAdimSasGbNVdF9vWDqXH0vg1pk5FzXNsKZWKMLQ/eKCOl6dI6dgdq6b3FxaP/DJp4cJlRQwKOFR22lm8VgjyFBWSv8hiIusF4ADzVQ5VhNqyNulvt7gdtlA0D/JTbfbY86LMtb3OsoJaHWbAq4CqdQ+XoN8iV/y7dp0l7rQiiGbN++KZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Petr Vorel writes: > Hi Stefan, > >> This disables the "smart scan" KSM feature to make sure that the volatile >> count remains at 0. > >> Signed-off-by: Stefan Roesch > nit: you forgot 'shr@' > Signed-off-by: Stefan Roesch > Thanks, will be fixed with the next version. >> Reported-by: kernel test robot >> Closes: https://lore.kernel.org/oe-lkp/202311161132.13d8ce5a-oliver.sang@intel.com >> --- >> testcases/kernel/mem/lib/mem.c | 4 ++++ >> 1 file changed, 4 insertions(+) > >> diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c >> index fbfeef026..ef274a3ac 100644 >> --- a/testcases/kernel/mem/lib/mem.c >> +++ b/testcases/kernel/mem/lib/mem.c >> @@ -454,6 +454,9 @@ void create_same_memory(int size, int num, int unit) >> {'a', size*MB}, {'a', size*MB}, {'d', size*MB}, {'d', size*MB}, >> }; > >> + /* Disable smart scan for correct volatile counts. */ >> + SAFE_FILE_PRINTF(PATH_KSM "smart_scan", "0"); > NOTE, this fails on the systems without /sys/kernel/mm/ksm/smart_scan: > > mem.c:458: TBROK: Failed to open FILE '/sys/kernel/mm/ksm/smart_scan' for writing: EACCES (13) > > NOTE, we normally handle the setup like this in test setup function. > > But new API has .save_restore which is more robust for tasks like this. > It's already used in ksm01.c, you need just to add this line: > {"/sys/kernel/mm/ksm/smart_scan", "0", TST_SR_SKIP}, > I'll add it with the next version > (instead of both SAFE_FILE_PRINTF) > > See: > https://github.com/linux-test-project/ltp/wiki/C-Test-API#127-saving--restoring-procsys-values > > I wonder if ksm01.c is the only ksm test which needs to disable this. > Other tests will also need it. They also use the create_same_memory() function. > also nit: there is a wrong indent (spaces instead of tabs), please be consistent > with the file content. > > NOTE: while this fixes problem on 6.7.0-rc1-2.g86e46c2-default (openSUSE), > it does not fixes other problem on 6.5.10 on Debian (16 errors like these below): > > mem.c:252: TFAIL: pages_shared is not 2 but 5038. > mem.c:252: TFAIL: pages_sharing is not 98302 but 593629. > mem.c:252: TFAIL: pages_volatile is not 0 but 391. > mem.c:252: TFAIL: pages_unshared is not 0 but 149157. > > I have no idea if this is a real bug which needs to be fixed or test false > positive to be fixed, or whether the problem has already been fixed in newer > kernels. > This is a different problem. "Smart scan was introduced with 6.7" >> + >> ps = sysconf(_SC_PAGE_SIZE); >> pages = MB / ps; > >> @@ -526,6 +529,7 @@ void create_same_memory(int size, int num, int unit) > >> tst_res(TINFO, "stop KSM."); >> SAFE_FILE_PRINTF(PATH_KSM "run", "0"); >> + SAFE_FILE_PRINTF(PATH_KSM "smart_scan", "1"); > nit: Again, wrong indent. You could have seen it also in the generated patch. > > Kind regards, > Petr > >> final_group_check(0, 0, 0, 0, 0, 0, size * pages * num); > >> while (waitpid(-1, &status, 0) > 0) > >> base-commit: 8c89ef3d451087ed6e18750bd5eedd10e5ab3d2e