Re: [PATCH v2 8/9] irqentry: define irqentry_exit_allow_resched()

Ankur Arora
2023-09-11T17:25:37Z

Peter Zijlstra <peterz@infradead.org> writes:

> On Wed, Aug 30, 2023 at 11:49:57AM -0700, Ankur Arora wrote:
>
>> +#ifdef TIF_RESCHED_ALLOW
>> +#define irqentry_exit_cond_resched_dynamic_disabled irqentry_exit_allow_resched
>> +#else
>> #define irqentry_exit_cond_resched_dynamic_disabled NULL
>> +#endif
>
> per ^, the below comments are not entirely accurate, since not every
> architecture has TIF_RESCHED_ALLOW, perhaps make it:
>
>> @@ -8692,25 +8694,25 @@ EXPORT_SYMBOL(__cond_resched_rwlock_write);
>> *
>> *
>> * NONE:
>> - * cond_resched <- __cond_resched
>> - * might_resched <- RET0
>> - * preempt_schedule <- NOP
>> - * preempt_schedule_notrace <- NOP
>> - * irqentry_exit_cond_resched <- NOP
>> + * cond_resched <- __cond_resched
>> + * might_resched <- RET0
>> + * preempt_schedule <- NOP
>> + * preempt_schedule_notrace <- NOP
>> + * irqentry_exit_cond_resched <- irqentry_exit_allow_resched
>
> + * irqentry_exit_cond_resched <- NOP / irqentry_exit_allow_resched
>
> Or something.
>
> Also, why did you add that extra whilespace all over? Makes it a bit
> harder to see what actually changed.

Yeah, not sure why I didn't catch that. Will fix.

--
ankur