Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: Hongfu Li <hongfu.li@linux.dev>,
	akpm@linux-foundation.org, surenb@google.com, mhocko@suse.com,
	brendan.jackman@linux.dev, hannes@cmpxchg.org, ziy@nvidia.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Hongfu Li <lihongfu@kylinos.cn>
Subject: Re: [PATCH] mm/page_owner: preserve original free_pid/free_tgid during folio migration
Date: Thu, 3 Sep 2026 11:43:31 +0200	[thread overview]
Message-ID: <87a29ae1-6a4f-4083-bd4f-7ff0295ff046@kernel.org> (raw)
In-Reply-To: <20260903092126.24685-1-hongfu.li@linux.dev>

On 9/3/26 11:21, Hongfu Li wrote:
> From: Hongfu Li <lihongfu@kylinos.cn>
> 
> __update_page_owner_free_handle() accepts pid and tgid, but ignores
> them, always storing current->pid and current->tgid.
> 
> __folio_copy_owner() forwards the original free pid/tgid during folio
> migration, yet these values were overwritten by the migrating task.
> 
> Store the passed-in pid/tgid so the migrated folio keeps the original
> free attribution.
> 
> Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>

Fixes: ea4b5b33bf8a ("mm,page_owner: update metadata for tail pages")

(not critical enough stable@ imho)

Acked-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>

Thanks!

> ---
>  mm/page_owner.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index 3fc37d9b908e..cfc31c92d765 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -307,8 +307,8 @@ static inline void __update_page_owner_free_handle(struct page *page,
>  			page_owner->free_handle = handle;
>  		}
>  		page_owner->free_ts_nsec = free_ts_nsec;
> -		page_owner->free_pid = current->pid;
> -		page_owner->free_tgid = current->tgid;
> +		page_owner->free_pid = pid;
> +		page_owner->free_tgid = tgid;
>  	}
>  	rcu_read_unlock();
>  }



      reply	other threads:[~2026-09-03  9:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  9:21 [PATCH] mm/page_owner: preserve original free_pid/free_tgid during folio migration Hongfu Li
2026-09-03  9:43 ` Vlastimil Babka (SUSE) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a29ae1-6a4f-4083-bd4f-7ff0295ff046@kernel.org \
    --to=vbabka@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=brendan.jackman@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=hongfu.li@linux.dev \
    --cc=lihongfu@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=surenb@google.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox