From: Will Newton <will.newton@gmail.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Minchan Kim <minchan.kim@gmail.com>, Mel Gorman <mel@csn.ul.ie>,
linux-mm@kvack.org, Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Commit f50de2d38 seems to be breaking my oom killer
Date: Fri, 8 Jan 2010 11:18:01 +0000 [thread overview]
Message-ID: <87a5b0801001080318o29a5f560u1cce8a45849dee6d@mail.gmail.com> (raw)
In-Reply-To: <20100108130742.C138.A69D9226@jp.fujitsu.com>
On Fri, Jan 8, 2010 at 4:08 AM, KOSAKI Motohiro
<kosaki.motohiro@jp.fujitsu.com> wrote:
>> > And while I review all_zones_ok'usage in balance_pgdat,
>> > I feel it's not consistent and rather confused.
>> > How about this?
>>
>> Can you please read my patch?
>
> Grr. I'm sorry. such thread don't CCed LKML.
> cut-n-past here.
>
>
> ----------------------------------------
> Umm..
> This code looks a bit risky. Please imazine asymmetric numa. If the system has
> very small node, its nude have unreclaimable state at almost time.
>
> Thus, if all zones in the node are unreclaimable, It should be slept. To retry balance_pgdat()
> is meaningless. this is original intention, I think.
>
> So why can't we write following?
Hi Kosaki,
This patch fixes the problem for me too, thanks!
Tested-by: Will Newton <will.newton@gmail.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-08 11:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 12:34 Commit f50de2d38 seems to be breaking my oom killer Will Newton
2010-01-07 13:58 ` Mel Gorman
2010-01-07 14:15 ` Will Newton
2010-01-07 14:49 ` Mel Gorman
2010-01-08 1:58 ` Minchan Kim
2010-01-08 2:56 ` KOSAKI Motohiro
2010-01-08 4:08 ` KOSAKI Motohiro
2010-01-08 4:53 ` Minchan Kim
2010-01-08 5:10 ` Rik van Riel
2010-01-08 9:25 ` Mel Gorman
2010-01-08 9:32 ` KOSAKI Motohiro
2010-01-08 11:18 ` Will Newton [this message]
2010-01-10 14:37 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5b0801001080318o29a5f560u1cce8a45849dee6d@mail.gmail.com \
--to=will.newton@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).