From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 386E6D18140 for ; Tue, 15 Oct 2024 02:34:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EEB86B00A9; Mon, 14 Oct 2024 22:34:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99E106B00AA; Mon, 14 Oct 2024 22:34:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88C966B00AB; Mon, 14 Oct 2024 22:34:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6C5F16B00A9 for ; Mon, 14 Oct 2024 22:34:17 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 849CBAC341 for ; Tue, 15 Oct 2024 02:34:00 +0000 (UTC) X-FDA: 82674267060.03.F6EA369 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) by imf29.hostedemail.com (Postfix) with ESMTP id E5587120005 for ; Tue, 15 Oct 2024 02:34:03 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=B+0g4H8p; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.118 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728959550; a=rsa-sha256; cv=none; b=ht/fHpkc2BzzOfFCdxtztf5U724okhg8DIE1SYHqOu+BxQWD9x6yEZ1mmFLDc9EH/+KIhB KbVY3JzOXSQK4R14+jQSkpmXnRvLTQtql1iMPbP9463ACxalZMNj9mMrGRv6qBD1NuoFIN qya0FNqpJkIOb6JB2+EERV7R7kRbCYw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=B+0g4H8p; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.118 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728959550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5SWTPrpRWV5oTpc4vCe8QJknxozDoWmECEzjBVIQIOY=; b=TrmJZ8UUIMm7oyHYXAn1pqF0NK3CxOICZhrkgJxDqbH8cIMN2qTXlxWzF2n1V/uXsafSq3 t/1AqVE91Ab/pFdBK68rmpStbBzeHkIRK3WWffnwLoLsN7CZ4knUMpWXFdZZ32s3vGz8T9 Wu12o9DPhx8x/ONJhb+TTYz/lzTvezw= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1728959648; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=5SWTPrpRWV5oTpc4vCe8QJknxozDoWmECEzjBVIQIOY=; b=B+0g4H8pvC5/w3dnyQLs2N2PLdp03vheluIpPJi5lz9jzQaflXY7f7YmMwEEi6LPZwIFB7KIg+Xg6wj2219jse1u9KSTO8kKMNLGbgRDAurR+EuHDR8adclKBJxorlu2Hv5UQkRbAA4O3ToB0t5G9IolCtRcnoA5mgI7R5BSH10= Received: from 30.74.144.137(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WHBZZRf_1728959646 cluster:ay36) by smtp.aliyun-inc.com; Tue, 15 Oct 2024 10:34:06 +0800 Message-ID: <87af6d7a-3a55-4f7d-979d-820cc390e855@linux.alibaba.com> Date: Tue, 15 Oct 2024 10:34:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: mm: fix the incorrect usage() info of khugepaged To: Nanyong Sun , akpm@linux-foundation.org, shuah@kernel.org, zokeefe@google.com Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com References: <20241015020257.139235-1-sunnanyong@huawei.com> From: Baolin Wang In-Reply-To: <20241015020257.139235-1-sunnanyong@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E5587120005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pyw8c9kcb7gnzjrbrdsja6mhqdja9ihr X-HE-Tag: 1728959643-152655 X-HE-Meta: U2FsdGVkX19xVe3ZIRcnlKpEkXPQIXse9Wdo/TvM8EH0lZGqqHOMyOhrvGwv7wXkaRREeW4qhFzb39iOWoDBciqvc0cfvGpytPWbWnFUdXDOXI+5AKaNhbctWPjbZPc6FETA5HPaheA7YsgdMrhGJ2Lk2JhFKYTFdqGnWSsvvWsqgvY/5LnfM04ZU3D3k2RPjuTIyh7bLApNnP2welTooZI7JG/iEK3Sq+UxOVg9vx2ku3tCLyCMBwtOniTtMHlH9/YQusYtPPy2a3YFZbmCQZiDotBOXlMS0Zj8uYnvDcFnrwxItcNTl9EzZ7WZSKLVBsif9R0eeLxLiLI6qucAGdyx2Yb/J3O3iTuXE13npecouwwkTZbg9TuROtjEvdI32LlU0IE+ctUPcD2Qp9oouwAkwerfdz3fJgQmec10tGJxlHo2QOW/ypwFOM49DLTXATaScOOin59MBmLpkOx3SvUupQgy3dScw1XZE35VL0SXMLkihuIrMQlcryhw91F6i0yoxMIwYfoJiet7DeGSpPAwVkKnRyqQd9rXbF3K8mZ4WDN7zkWIRQJh0HAX1qqmDED3D5vmzn6a7F3Ql6nwIXBZkeTcJBLnWXL/FRxehLLiPV9b3SISgQPWmhu0+7UNY/uFhdAmwu6qIf7J+n9Hw4Xt4DLfZ9WDp5Yr6U+L+90eiwLFrPQiXPXhTvmeTVX5buB2L9iVrJBDTJmOobcWPP+ZvGxdn7ckwW3PHLEE5Hg5hzN5sLOG1H/kmJ+vQ6IHR+819iJ3cvC4hpHNFPuKBSZATQmhxhPiA51dWV3TdyAdwgifcDAAvZeTX0noWs6gcUL+q/fDYHhqp94KtThiutYRVj0CkL5Z6XqDjuLf6pRge2L9fdUkanSjHohIXp+H286J0lPHF/J8m/aR2bKsRTJzjivhvjzc/Q1CdsyWelUejZg/mKZBtz0bBXThCWTJ87oUHuRAAwiKJKk+BIJ gsVi+UGF 6MAleMvz1i753C4YzjDlO8EdxV5c5Vogvar7zt8ZZnCTs7BX3H9TI2VPyhkGpNh4LxIjKf0Cel34fRffBSkH4HBB61XgDh/C3au2VorUQvwFgxYY5T+9hcN1qUsOJPcPjujJTrXgiUdnpff/Sx6UB6WzhNfhVNjkpbZbB+cTcuswze1CGK0SZftj/B/HGZFTLquBHcRTYBQyCjKcnd96Mcmc8um1pup+IPkDjUbeTziRhJIiN56s/3FQusfwTmHa2KLTHARjGc+v4R6u5eTbT9u/X3SdhBwT6/ByDmBI8nsEV6is= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/15 10:02, Nanyong Sun wrote: > The mount option of tmpfs should be huge=advise, not madvise > which is not supported and may mislead the users. > > Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing") > Signed-off-by: Nanyong Sun LGTM. Reviewed-by: Baolin Wang > --- > tools/testing/selftests/mm/khugepaged.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c > index 56d4480e8d3c..8a4d34cce36b 100644 > --- a/tools/testing/selftests/mm/khugepaged.c > +++ b/tools/testing/selftests/mm/khugepaged.c > @@ -1091,7 +1091,7 @@ static void usage(void) > fprintf(stderr, "\n\t\"file,all\" mem_type requires kernel built with\n"); > fprintf(stderr, "\tCONFIG_READ_ONLY_THP_FOR_FS=y\n"); > fprintf(stderr, "\n\tif [dir] is a (sub)directory of a tmpfs mount, tmpfs must be\n"); > - fprintf(stderr, "\tmounted with huge=madvise option for khugepaged tests to work\n"); > + fprintf(stderr, "\tmounted with huge=advise option for khugepaged tests to work\n"); > fprintf(stderr, "\n\tSupported Options:\n"); > fprintf(stderr, "\t\t-h: This help message.\n"); > fprintf(stderr, "\t\t-s: mTHP size, expressed as page order.\n");