From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31676C3DA59 for ; Wed, 17 Jul 2024 02:05:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2CA06B009A; Tue, 16 Jul 2024 22:05:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADC486B009B; Tue, 16 Jul 2024 22:05:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A4626B009C; Tue, 16 Jul 2024 22:05:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7CD076B009A for ; Tue, 16 Jul 2024 22:05:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1CE551A085A for ; Wed, 17 Jul 2024 02:05:11 +0000 (UTC) X-FDA: 82347602022.07.F5BC008 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 470BD4001C for ; Wed, 17 Jul 2024 02:05:09 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="Krce/Whf"; spf=pass (imf07.hostedemail.com: domain of thiago.bauermann@linaro.org designates 209.85.215.172 as permitted sender) smtp.mailfrom=thiago.bauermann@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721181878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i8QRegxtd6+FgIkF6diGK9DWIR0YDnVslVz04u7ogUM=; b=j3zNs5WsaWQuRLuZgYJxuNZo7AnQk60y+jO4eVV0L6kky/dE0lMvZ1sRmODnQynxv5WAWZ 87fLa3ylwo0m7efnkvnaLpuA4TyJ0FYvxNLQ+wD1Guab9Z6sHDS8wDeVN91W9oQSavcMdt I7k8oMBLjUlvMcaYHmrNxUWjwvtB/ak= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="Krce/Whf"; spf=pass (imf07.hostedemail.com: domain of thiago.bauermann@linaro.org designates 209.85.215.172 as permitted sender) smtp.mailfrom=thiago.bauermann@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721181878; a=rsa-sha256; cv=none; b=0ctDn+Ha7oF1TDJ1KleoCFhJUJc78VcIIoJ7Xk4PYvzfK0xT6ngFDRbp+89fJkw5M2hg9Z ZGhxWAB9ihWYItsD1biaONIDEzTUFdPVckboxSKl+w4I5vMewuMx7scO75jKOV1m+xt7sH NexTMn/HIIS+9RHlK1v7ATwS7o4nz3Y= Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-78135be2d46so4562104a12.0 for ; Tue, 16 Jul 2024 19:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721181908; x=1721786708; darn=kvack.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=i8QRegxtd6+FgIkF6diGK9DWIR0YDnVslVz04u7ogUM=; b=Krce/WhfxNAC+4s2PBI8jHTl4/6Thm8/TZSZmv8iU0a2SN8R6nmkjyUubq5hjfxEiG MXUcIWzibfo5Rm8QjX3BLJet+gDXaurmzgPEvokvfX7cfpgN1uLMnCvTffW5Xrvie5w8 8cNKKXJ30Z6ew8WjJZFwlktjMYE1c4XwHySskX/h84mRCGM/YtYvEzQQvYxyJrRmO9JM fCE8n10WaIjUUIdrq/LjpHaqDl+a+z4SZz5eHr2rE0ouSlWfxFlmOV3AUGQV+DQePLxg LC3+qlaftCPKb0MGAuMl9cKENeM6Ed5ARZ3yBUoHRv9Z6KRKdSJy5Ij78uBlPw3xJJhB kEow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721181908; x=1721786708; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i8QRegxtd6+FgIkF6diGK9DWIR0YDnVslVz04u7ogUM=; b=OO1MfKSnQA6E4d1qp+NhLTq6zeK+m+crY8dwHdeILha0dYMfpuc6Azzmx0ZOU6Fx64 0mhz3UTyeGKpNRUdduzwtKOohp/6THCKF0x4zxYYnTL5JWuynS5Kl+tQGPfre77lkl02 eNMwFNr3XIbYlGuBBUPohJMeaJqUkN7OjOK/Rl6BZkLxtpe3c0Hka/NFaCDCt3DOOZbX 14qeSTOQl1ySUXsOwcmrghgIc/8gik8YV5Lwt0Q2KPh9BsFRfEn9SnM3RpFOZZNeDOLd puUOCODC9SmRHYnBxVjfVThjCD1jDJLkT+5xU+xAmauvpAsTue1AMnKiJLLNu4+dIkN5 FfUg== X-Forwarded-Encrypted: i=1; AJvYcCXOynf+v4nswLnErkh9kTsegJ1E1/e0TxMOcPfMl1of/eGItSw/2ieSYe0/6QirUD8Sfhe142SyPVHSMXUXE50s4u8= X-Gm-Message-State: AOJu0YyGtpQfO3hMWL1CzmWrA+H+AY00Og1pzC4TBTSXJ9q4vQzOig1o HIxetIDIFapvPbMQ8RSxEAcag/xpPKEpF3EbdIK4NBccPhbU1fr8FtGbGmqAWcc= X-Google-Smtp-Source: AGHT+IE2KzNPcTth+gMo267NV2Jd+oHot7f6l6m3xb5YAhTJAAFsLZacsEiGAChpR0B8dRp+Zw50zg== X-Received: by 2002:a05:6a21:710a:b0:1c2:8e3f:a49 with SMTP id adf61e73a8af0-1c3fdcc006fmr450858637.3.1721181907982; Tue, 16 Jul 2024 19:05:07 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:4ae3:bddc:48f7:36a0]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2caedbf733esm7067534a91.20.2024.07.16.19.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 19:05:07 -0700 (PDT) From: Thiago Jung Bauermann To: Mark Brown Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Ross Burton , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v9 20/39] arm64/gcs: Ensure that new threads have a GCS In-Reply-To: <20240625-arm64-gcs-v9-20-0f634469b8f0@kernel.org> (Mark Brown's message of "Tue, 25 Jun 2024 15:57:48 +0100") References: <20240625-arm64-gcs-v9-0-0f634469b8f0@kernel.org> <20240625-arm64-gcs-v9-20-0f634469b8f0@kernel.org> Date: Tue, 16 Jul 2024 23:05:04 -0300 Message-ID: <87bk2wu627.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: gffrca6mj7eeojxuzu93txfohn375c5z X-Rspam-User: X-Rspamd-Queue-Id: 470BD4001C X-Rspamd-Server: rspam02 X-HE-Tag: 1721181909-600254 X-HE-Meta: U2FsdGVkX18JPBW2HnAjLhNUbcBSSIlmZfsgNUqzBgE/K10NikVvvh4BRo4J9QFOtNeUUAu5OrGO07Xq4yYVrMANEBu/b0Zf2YQVcNpQzcjerwDUhiuVQBxlHB7hQtOoZGw8XaayNJyfuLE943kiIvHCH1tXm8iqwO2xxngIWzrfk7BbWthp2fhBKdCMdvVq/Z9q2Vs6KiUIWPs774lmbyJ45THRUHGpbsYhU/eWh2+n5GNEQEqSsYfTDftUVxRJbdlt/5HkvApVWed5+OhF9iWQWJcGPlMFAEuCZTpzW9n066ZE33ny6JPgPHsjPle8dcUloM/xja2Xlm3wRq2nbNNsLImkbEs2vRefgtCkqq/OSgosQE8V1hj1+XgH1Acv4byDGkOH/NPqgDUFUWc4tXGHCxaB6dLlaGhWumTIV9gM/8mEHX30pAeGkspfsKQwavnNrHHRX7AuUrlUb0qyLfUJbTU2i8WzMK+4MeL5mOsINozjF6c1CbLOFD5N8SksL2xXUD152vP7O6r3Oaok6nsS8Y2NQpUr9QdALXwto0Fim6gSfPwR4yLGcrhGJaNSNAonduBkiyyitwy/MkdDpKI48XLfYewF/1KUaASUtQTca3wr9gbIaJFYyEhRcscVvZUVgsPuo471T3nHyvZo/DsPTbuHt/BesyTqgv/zoz1bckB8vkaPPR6OKLxySDqbKJ8Ig+EKLFFiPl6A9hZSFFaRhlwsT8RvslihH5LiPFtsDERVOrNshCplD5jtIfm+m/vZW3NvzpbnNMNr1OpXa7LEY7oWu9d6ugoZBzX0vK9yznD9pFuxn+EOEHc7dKNdJgWyD2omDSaYnMUHGC3L5F/V7+ZrX+MWW9MkcYkAX+g1wHxiIpppqMsVQWGc9D25srn/AGJKfemiCQdvOWrxfWaJT8HIYY3sSEfg5d/tzc8//P6gbRqHFli9euxwi46ZuN2FPrJMRqpEiFCBlCs iHRLXA8f 124SVwmeoIj5+GKpGzj7844Dgo70KWyUAYFy3VxEQfLiqJ0AqhRvFtEBcScc92htResYWbVcIyAwuXZPGnLi9/CrE+0qCR5v/KTHM55JH5+cnN5VXS96khQ+jpkdged+ATtL0DeZYyFpwMRILglrtEjC+ezAcVl1PHd4XOFTmsMqbhKO2V7kLQNqo1ycgSix7qB8o4/oJDTvPTIe/j7vFGcnFdxBRnp/w6oOHi3nj0ACRdqd/kv9/tgvqHPf9vMhbhkhuuzEtd5q6hjCtQjpnV4jNP1zAbFm3+jZ5g+wAida3N+bwsbMNFeZV6YMDwHdOUHpVRlHAzDze9osLqPcRKS8UL6/4YdLxWEJ8wVzyM4u7pu03bPW+bmBmUVERr7GePbOcoF6yuTCjmZq7Zi4jDntOWbP2O/fdxLM1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Mark Brown writes: > diff --git a/arch/arm64/mm/gcs.c b/arch/arm64/mm/gcs.c > index b0a67efc522b..4a3ce8e3bdfb 100644 > --- a/arch/arm64/mm/gcs.c > +++ b/arch/arm64/mm/gcs.c > @@ -8,6 +8,139 @@ > #include > #include > > +static unsigned long alloc_gcs(unsigned long addr, unsigned long size, > + unsigned long token_offset, bool set_res_tok) The token_offset and set_res_tok arguments aren't used in this function, so they can be removed. > +{ > + int flags = MAP_ANONYMOUS | MAP_PRIVATE; > + struct mm_struct *mm = current->mm; > + unsigned long mapped_addr, unused; > + > + if (addr) > + flags |= MAP_FIXED_NOREPLACE; > + > + mmap_write_lock(mm); > + mapped_addr = do_mmap(NULL, addr, size, PROT_READ | PROT_WRITE, flags, > + VM_SHADOW_STACK, 0, &unused, NULL); > + mmap_write_unlock(mm); > + > + return mapped_addr; > +} > + > +static unsigned long gcs_size(unsigned long size) > +{ > + if (size) > + return PAGE_ALIGN(size); > + > + /* Allocate RLIMIT_STACK/2 with limits of PAGE_SIZE..2G */ > + size = PAGE_ALIGN(min_t(unsigned long long, > + rlimit(RLIMIT_STACK) / 2, SZ_2G)); > + return max(PAGE_SIZE, size); > +} > + > +static bool gcs_consume_token(struct mm_struct *mm, unsigned long user_addr) > +{ > + u64 expected = GCS_CAP(user_addr); > + u64 val; > + int ret; > + > + /* This should really be an atomic cpmxchg. It is not. */ s/cpmxchg/cmpxchg/ The same typo is also in arch/x86/kernel/shstk.c, from the "fork: Support shadow stacks in clone3()" patch series. > + ret = access_remote_vm(mm, user_addr, &val, sizeof(val), > + FOLL_FORCE); > + if (ret != sizeof(val)) > + return false; > + > + if (val != expected) > + return false; > + > + val = 0; > + ret = access_remote_vm(mm, user_addr, &val, sizeof(val), > + FOLL_FORCE | FOLL_WRITE); > + if (ret != sizeof(val)) > + return false; > + > + return true; > +} -- Thiago