From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 313DAC001DC for ; Mon, 31 Jul 2023 16:22:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF09E6B0105; Mon, 31 Jul 2023 12:22:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A79B56B0106; Mon, 31 Jul 2023 12:22:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91B966B0107; Mon, 31 Jul 2023 12:22:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7EE0F6B0105 for ; Mon, 31 Jul 2023 12:22:01 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4FA4BC02D5 for ; Mon, 31 Jul 2023 16:22:01 +0000 (UTC) X-FDA: 81072423642.10.9342CCB Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf01.hostedemail.com (Postfix) with ESMTP id 8A7304001C for ; Mon, 31 Jul 2023 16:21:59 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=sckhwr7U; dkim=pass header.d=linutronix.de header.s=2020e header.b=NX+OtYFc; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf01.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690820519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KqkYv1GwuT7wrNuSLgatJf7BkiAxad+peRj/ArOIh1c=; b=U63Ii04YE2BCNGeksfGlsnO0vAmUy10Oyyhpc95BJd21947DoPfy7oB30MxesznBbHgWcB ZN5ls+T5am1zfLAAGocazpMjP3tylA9yew7IapJZ4r1pDw+LM/2jdbyxovbKw25A3NXmPd BW95nD6Zns2vxVQ99wfJvvBA1qvnIqg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=sckhwr7U; dkim=pass header.d=linutronix.de header.s=2020e header.b=NX+OtYFc; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf01.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690820519; a=rsa-sha256; cv=none; b=TsnXUCKGibsCv8zzIP3tec8FfwsrjnRjC3pn1eHQ09eT6abB7zIX2x+4vV8Xs5Y+mAQQAH ob27rd6qg8NF8v4yrfpusLMuPMXcaSJwctGHkSpLfnfEe1I/7Fm4+qARf8IseQ/BayMxO6 aYsoypKN+mz/bpCOOcU35LQ+gHwhMxk= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690820517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KqkYv1GwuT7wrNuSLgatJf7BkiAxad+peRj/ArOIh1c=; b=sckhwr7Uz+RKelUdW5qGzRpZ0c2pnzHYh9SQc/bMxR/eHv1AO/vTg+Csa/ihN/ODxcgf6o 2YwoG9bk8lB/ubmmQhurUo88OHIbluDwa3lcxsUSRZJu4YJaeq6hgEqe5FwdOh8Piqb3p4 9AkoTuN+MdUHKQ4tUHsV5Zim9XLegbsO27TLbqVjOcCEwwZ7HlZDWmAzvvMF4mb/FAPcqp Td0awpldp1PzAbRfqSRPPsLiM/iteufMUncIwMEaNsTRQLbiyTxHnVYIuh7yNORUzPZqrV p+CeymM4TjbcYQf4L2qS7CfIlurt1KqK6m4+6cIa8bfyTdNSy4SI90DmU6YEow== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690820517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KqkYv1GwuT7wrNuSLgatJf7BkiAxad+peRj/ArOIh1c=; b=NX+OtYFcIBDOl4WbWlYOcOEiLzOWm76tHMyXWS4bgnvGOMXbvRouoiH2ep1IWP2Zxmbl9R qua8oOIpFoYwoxAQ== To: Peter Zijlstra , axboe@kernel.dk Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 03/14] futex: Flag conversion In-Reply-To: <20230721105743.887106899@infradead.org> References: <20230721102237.268073801@infradead.org> <20230721105743.887106899@infradead.org> Date: Mon, 31 Jul 2023 18:21:56 +0200 Message-ID: <87bkfsnja3.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8A7304001C X-Stat-Signature: zx6985pd69g4nigkj48roh8g6tmrbmp1 X-Rspam-User: X-HE-Tag: 1690820519-746418 X-HE-Meta: U2FsdGVkX1+Jsf/85dkcnwiz9HfU9JqCNYVQ/dz0GWJzCiobumF42vts2ALHB9jpte43+pXV6i5BtbMlzwbgcrm6l3uGrxV43lNkaDY1B8K0437VHUvCmBwvoA1BUjrsmwErq/yiQG7SWi7k/ehYm0t6IcypjbX+C96gJXcJ9LHbXfZRF9pPeY1HG3/5hyMQ0l3dk3HT4crgDJTfDEE59bdhA4+ai3kgC+UliRg2oO80IPxAsKmKWpmwA1Vqox8SWLZOxGYbUjSoNi22PxBYIdru1Nn2VHVu2uuy3XIOh1mKdoE1HKPU7cSTATEzQ6b4sgm7rM9Od226ALuzGauqh9yH4d8CnA8bl9IYRFZ+5vjzINNdXWskvFPmj/TDr2J42gW5SScJxihf2p8HEKPRz0edkhEmJPmMr8zQnMiMsa8MS4YiJSgH51LAleIEGNZbjbSbKx2Cx9MzEex8rbyPZ1Zfn3nTmjKp6o6cMGpliqeDEJ6QAqXjvG/sZDDRWLAJrlOkKpRvGZLH4/+ugURXdseOAl9EGV8SGebf456NdyEANMcZM/vQlIa+OHQ5wig3zcw2DEYKV1fr4KNtzC37XHy1058VPFXO/+Vk8mHUv30GS1oW3VTb03lgsaKiEPUeVzSlrqTBA4OFnNYq1Fj71/kDSIWE2Hj2eeuj80Fr7QO6IdEsV9OYWQ1wE09ZchwaD3cnn9y0zZwCgczCRdAKW9s9Mku0qYZoW0dFL9n/KgonRqeo3eavZXO6ro1+uw8iQwQgmvzauk2PmdwLIJv0QlDDXKzH8FKhFZnOfFq/zNCA1S4U+/jBriYVyb95ZZoBC6uP9ohMlrXTg3Gptz7F0rkoDc4kFmNBJ7MaoHB7/83zpde/Vx2CG+5rX9A7Q/O5OjQDfyyPCIX8aryoJAwNGO/OQwabtReEreffrFGuS09nXeNhlZaaZjxcldGbzBBbQxT4Kxoyw0NOtW+8Toz d49GmCvZ IgvZ/JRjRP3lZggU20rko0MRwIza2uCKjoWuTHEA5Q/WOfeM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote: > + > +static inline bool futex_flags_valid(unsigned int flags) > +{ > + /* Only 64bit futexes for 64bit code */ > + if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall()) { > + if ((flags & FLAGS_SIZE_MASK) == FLAGS_SIZE_64) > + return false; > + } > + > + /* Only 32bit futexes are implemented -- for now */ > + if ((flags & FLAGS_SIZE_MASK) != FLAGS_SIZE_32) > + return false; > + > + return true; > +} > + > +static inline unsigned int futex_size(unsigned int flags) > +{ > + unsigned int size = flags & FLAGS_SIZE_MASK; > + return 1 << size; /* {0,1,2,3} -> {1,2,4,8} */ Lacks a new line and the comment is both misplaced and kinda obvious, no? Other than that, this looks abour right.