From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24459C28B20 for ; Wed, 2 Apr 2025 14:10:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 869D8280003; Wed, 2 Apr 2025 10:10:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81A32280001; Wed, 2 Apr 2025 10:10:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69389280003; Wed, 2 Apr 2025 10:10:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4B0B0280001 for ; Wed, 2 Apr 2025 10:10:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B8B22161A59 for ; Wed, 2 Apr 2025 14:10:50 +0000 (UTC) X-FDA: 83289289860.12.EEC396F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 41DF98000D for ; Wed, 2 Apr 2025 14:10:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ce8m/WH9"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743603048; a=rsa-sha256; cv=none; b=sU/CpLluEXBzTb763EWPdcHZEPCYYR+8oJFdyJDr0qGe5wGTHTkLyrwgPOckYK2W4aaFue +Z9QXbWwH8Um0qiY1VJjRZbvAxwiQ4NK7SWRJd7qbUwMrHDuUJgwM6jEdcF4asnBgIkupo zxQBX3YKWGleZbUJDKM1HNNnDsHmFsc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ce8m/WH9"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743603048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MbKTHiaLmAweSAwT0igRmFjsf2YylXp8ikC2EQZZfqY=; b=7sOiKr0YqwdnXxWnCjfXDWaT0lFR0GA8rm8uS6Vfl4lUdcmVMHZv66FSOuUn+cyr2SFBv9 WczrmwRrkQEL3Oa/7cnoL/02OYtppKZUvvy4WFkrNHUVnQEaOENfxixfGa2cBnNnfbJPIs IUKcc0pyiRRShXt3D7s9y1jOubdh6ho= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743603047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MbKTHiaLmAweSAwT0igRmFjsf2YylXp8ikC2EQZZfqY=; b=Ce8m/WH9UvRKp0xC9IXiRi7Y8fRqTZ10hszJXLdnsK1tZ9/zbBRmznbSMj21B+8a2QQEDI a7P0hKzampJ970IYaZA2LdsaV5pqwwnDI1qYQbEMQ7o5TnZjXschBEjwmCTyO1UUrXpKU/ s5254Md5HD1C8WRADnzgbR+4tLe2ncA= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-BKjBymWENcmS0swIY87Tpw-1; Wed, 02 Apr 2025 10:10:43 -0400 X-MC-Unique: BKjBymWENcmS0swIY87Tpw-1 X-Mimecast-MFC-AGG-ID: BKjBymWENcmS0swIY87Tpw_1743603042 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5499c383444so3787105e87.2 for ; Wed, 02 Apr 2025 07:10:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743603041; x=1744207841; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MbKTHiaLmAweSAwT0igRmFjsf2YylXp8ikC2EQZZfqY=; b=xFP2/PshMOuCdWDNmjHWy1QuHCBKK5OefKIignCHJLUXSP8I4qIy7YCUvqwYnmx/4B FNl83KV89e/N7+e12VFJgrjMe3pXz7wR+PGkVjhlxMuk838cMtDMOFOawiQe6g3Fmu5h LfmrnJ8deZslfg9AtAgKmCZk1TVxfAyPw5G3d9WxpCW5i7qodZxio/3wV+9M1UIgcHmg PWtFY6zuoFGZcI7m6VXdh8JTaTVTPJ4XfVn4olNFSDDCafAoYmDPJZhdAeUvBTLkO77C wSndaxe7iDrvCj3wShn3mvzfWqQVUYfqQnmisX50wANf6+gIFv4Uc7it5x2kFp7ayCHQ K+Gg== X-Forwarded-Encrypted: i=1; AJvYcCW98ptudwcl9ikdqzpCX7T9Ql45XyQJWe4nVDX+uBwrKmQRPjtLeSPdM3Mv0ZWTx23S9TSoMerm8w==@kvack.org X-Gm-Message-State: AOJu0Yx02xJAd50Uk8c8kpunir2c54474LLr727U+sGk8a3bfivdAtPl RHaYJQwiXvm1EDgA0cG2DA/ZK1DRj44qcvxF29KdVHqHddjWiEDI4+1nSlw8hh+u8NTp7UrB21w I/ucFqtB1pI1StQo2JrJ0buZPVNLyepSTu3zjg0ap03AU+7Zk X-Gm-Gg: ASbGncuT4OP/KRHT0PBofMt/lqWse72h2dJTfwGPzSKUAoasGE2nM841P/6jcXtHvhC v2+iCIE5N/nTK/uyyKV8pJwACQrJiRyBmd0KeDxp0vQhEVqT2JCmyMba2SZ29Td4z2Dfk0TAlbg IlQWqrBKXC2gWJFuNle+RTmJ7ZX8Ekv075VHFkdh+/Xa39SKBwg5xuZe3uRG1gAamjvRSeLFGuy Nutui4JqhLsnhOMJ3TzAzs82dL4y8bcxcwhumUZVwA7CEYhymARV/pJRcxPLK/mKPSREQmfuebU a4tnrI0ulBzr X-Received: by 2002:a05:6512:1386:b0:545:8a1:5379 with SMTP id 2adb3069b0e04-54b111242bbmr5823781e87.43.1743603041551; Wed, 02 Apr 2025 07:10:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEMxC2U1r1cpFgYr/EJLzybppo1QongF+LooghSXPmyLtE3Ffn5xOTN3LHvx9mbOxE4Ua83cw== X-Received: by 2002:a05:6512:1386:b0:545:8a1:5379 with SMTP id 2adb3069b0e04-54b111242bbmr5823766e87.43.1743603041173; Wed, 02 Apr 2025 07:10:41 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54b0e703fa4sm1433452e87.169.2025.04.02.07.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Apr 2025 07:10:40 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 8BCB118FD3EA; Wed, 02 Apr 2025 16:10:39 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Pavel Begunkov , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, Qiuling Ren , Yuying Ma Subject: Re: [PATCH net-next v6 2/2] page_pool: Track DMA-mapped pages and unmap them when destroying the pool In-Reply-To: <2c5821c8-0ba5-42a3-bcdd-330d8ef736d0@gmail.com> References: <20250401-page-pool-track-dma-v6-0-8b83474870d4@redhat.com> <20250401-page-pool-track-dma-v6-2-8b83474870d4@redhat.com> <3e0eb1fa-b501-4573-be9f-3d8e52593f75@gmail.com> <87jz82n7j3.fsf@toke.dk> <2c5821c8-0ba5-42a3-bcdd-330d8ef736d0@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 02 Apr 2025 16:10:39 +0200 Message-ID: <87ecyamz6o.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XooMatcnaT_DVC93a6jiL3IcW5RD-FhQ412JpteW9dE_1743603042 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 41DF98000D X-Stat-Signature: prxigk7reqo9aeermqhyy3kmbcgxeijb X-Rspam-User: X-HE-Tag: 1743603048-915036 X-HE-Meta: U2FsdGVkX1+phU7+QZr+PUOYU0RJ/DMhoh3AWEMChkEezzjMfWRDgxkppYvy5mR5MNitEoN/wNvD4zR3bnx5D32neagqjPetWpe/ggxuRyCTDNDauKM09UQe0SGAjfvgez2/CMmSrJNrBQRQc55qFS6qXEB8RAKBySzTnB9qIXKRtBs3R7WuRopeYbQ2LVibWw40ARRRPBMMd6C4KCo1x9d/u7Yx1vSKbA7/kpM8LLKQwHm43cLpOMiJru1d6f3fveKfao0/qmWYJqXNv5kebH55pYOObKghh5sAG4ssQ6U/EOr87y0B8cX3kgtTg/ZE1E7p05OG7gfO8/8ald7B+mJe3f0C1BTbPpmFBIJvGA2TerhfwfFaxCctDYizWLGWC0KjVlvVXF9S1rhaApkDea2btJY+rzekeIfcH5RqxZU3SDIh6XtJFTWzbkW2R5G7GoJ7YiAXKBYgbPSg6ojwZnhz73mCgyOOLeD9xI20w9IU3+LL9PLrcMS6Auzh0u/E7v9ppqYe2fGQPmqq590Y+6gXx75UT+R3fTWsxLuPtxCxDhDK2d+cObC2cmJxSru0lTcQvxhcs1w0VT0IX1Lk+IQfZpM/sujC82D0YLkgWu5SDna5o4BJErY7NVQ1E2D8Otyv7RsaKEMRGWmPFPgwGvUxwGju3hwqYSfVeaGO8BpgBX8g/mpWoOPfNgYcFW5jOTtJEBCY6WjHoPErH4GS01trg9eN9QyyJ32xUSQ+F2mTXGii9dfuA+njZJT2LZz4ENhpiKXrclfl9s67B0Y1MKy6hDfArD6JNfXca65DX7T6an+tfcG4y0JIdzT1V560OIPsIthl5hRERv9rYqwkMgkqkZofbZe7Ih+yII4hM3TvG3w4RoNkI+0wtuUwUoqY5wPyvfZPAPpzAN025/3//+sDKlMNegyQMfkedGDTBwi3x0oi8QnxO10S+v6cvusi5kNuAIgtO9sfx84JwgK A8uA5v6V hAxM5ZmtNR296cyMSzecOUVfur66TqAA1OZFjtyq5d/BLpKN92n2bUEme5i0puLTnOcRmA3zrXt64thC7d2HFstRK7JIZyjbXXJItC5RdLdjZ6FxIX6E2akJz6Zgn2gqDPS/ah2wckfLJwVKNJD4NPYnCsW210q/nlt2EHym/WnL22pLIyTtwvf5Dp8jdnWuQHbVa2JuNGw1TI1qgv7TA6XMIIfz7vEWItZgZSCjJ0XhjjDw+Ad0ock2Zz1eUyNF82GbJLejSRl30lcvJWCJBmOdrYbu6Yo+8o8eDW7kxfP8zxSBEUiAAcRI+y8GyelB7fx3rWL/chh8mPxyeKpbEhYa9IkvuTKaEmy7RygJP7Zl40uUleVA6ojRCKfMyB82D3HtYoZhrA5N7dEUpHWDX7UUkdcgH2Oa+gwPmblD5HnsBjH2qWlEiHqQ14DKezaY+vr4+m8KjiR/o0fujZLOiEs9NTHsWh2sC78zMC/S8oczC4DfqfqbCqogjtZlk0GsP5zxEztjf/vM/wMh8anUIZvV/8G0eU4Lm+yKp6unAbso0ZNk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Pavel Begunkov writes: >>>> + if (err) { >>>> + WARN_ONCE(1, "couldn't track DMA mapping, please report to netdev@"); >>> >>> That can happen with enough memory pressure, I don't think >>> it should be a warning. Maybe some pr_info? >> >> So my reasoning here was that this code is only called in the alloc >> path, so if we're under memory pressure, the page allocation itself >> should fail before the xarray alloc does. And if it doesn't (i.e., if >> the use of xarray itself causes allocation failures), we really want to >> know about it so we can change things. Hence the loud warning. > > There is a gap between allocations, one doesn't guarantee > another. I'd say the mental test here is whether we can reasonably > cause it from user space (including by abusive users), because crash > on warning setups exist, and it'll let you know about itself too > loudly, when it could've been tolerated just fine. Not going to > insist though. Right, I do see what you mean - it's not guaranteed to be coupled. However, my feeling is nonetheless that it's better for this to be loud to weed out any new issues that may arise from this, so I'm inclined to keep it as-is. -Toke